TokenFactoryTest - Code Metrics - Inspection of "WIP: Added Phpunit Tests & Travis configuration (#..." - yokai-php/security-token-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3e963f...fbd0cf )

by Yann

created 2017-04-02 13:19 UTC

TokenFactoryTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	104
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

Metric	Value
wmc	4
lcom	1
cbo	6
dl	0
loc	104
rs	10
c	0
b	0
f	0

4 Methods

Rating	Name	Size	Complexity
A	setUp()	5	1
A	tearDown()	7	1
A	factory()	8	1
A	it_create_token_according_to_configuration()	65	1

<?php

namespace Yokai\SecurityTokenBundle\Tests\Factory;

use DateTime;
use Prophecy\Prophecy\ObjectProphecy;
use Yokai\SecurityTokenBundle\Configuration\TokenConfiguration;
use Yokai\SecurityTokenBundle\Configuration\TokenConfigurationRegistry;
use Yokai\SecurityTokenBundle\Entity\Token;
use Yokai\SecurityTokenBundle\Factory\TokenFactory;
use Yokai\SecurityTokenBundle\Generator\TokenGeneratorInterface;
use Yokai\SecurityTokenBundle\InformationGuesser\InformationGuesserInterface;
use Yokai\SecurityTokenBundle\Manager\UserManagerInterface;

/**
 * @author Yann Eugoné <[email protected]>
 */
class TokenFactoryTest extends \PHPUnit_Framework_TestCase
{
    /**
     * @var InformationGuesserInterface|ObjectProphecy
     */
    private $informationGuesser;

    /**
     * @var UserManagerInterface|ObjectProphecy
     */
    private $userManager;

    protected function setUp()
    {
        $this->informationGuesser = $this->prophesize(InformationGuesserInterface::class);
        $this->userManager = $this->prophesize(UserManagerInterface::class);
    }

    protected function tearDown()
    {
        unset(
            $this->informationGuesser,
            $this->userManager
        );
    }

    protected function factory(array $configuration)
    {
        return new TokenFactory(
            new TokenConfigurationRegistry($configuration),
            $this->informationGuesser->reveal(),
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            $this->userManager->reveal()
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        );
    }

    /**
     * @test
     */
    public function it_create_token_according_to_configuration()
    {
        /** @var TokenGeneratorInterface|ObjectProphecy $generator */
        $generator1 = $this->prophesize(TokenGeneratorInterface::class);
        $generator1->generate()
            ->shouldBeCalledTimes(1)
            ->willReturn('uniquetoken-1');
        $user1 = 'user-1';

        /** @var TokenGeneratorInterface|ObjectProphecy $generator */
        $generator2 = $this->prophesize(TokenGeneratorInterface::class);
        $generator2->generate()
            ->shouldBeCalledTimes(1)
            ->willReturn('uniquetoken-2');
        $user2 = 'user-2';

        $configuration = [
            new TokenConfiguration('test-1', $generator1->reveal(), '+1 minute'),
            new TokenConfiguration('test-2', $generator2->reveal(), '+2 minute'),
        ];

        $this->userManager->getClass($user1)
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->shouldBeCalledTimes(1)
            ->willReturn('string');
        $this->userManager->getClass($user2)
            ->shouldBeCalledTimes(1)
            ->willReturn('string');

        $this->userManager->getId($user1)
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->shouldBeCalledTimes(1)
            ->willReturn('u1');
        $this->userManager->getId($user2)
            ->shouldBeCalledTimes(1)
            ->willReturn('u2');

        $this->informationGuesser->get()
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->shouldBeCalledTimes(2)
            ->willReturn(['some', 'precious', 'information']);

        $token1 = $this->factory($configuration)->create($user1, 'test-1');

        self::assertInstanceOf(Token::class, $token1);
        self::assertSame('string', $token1->getUserClass());
        self::assertSame('u1', $token1->getUserId());
        self::assertSame(['some', 'precious', 'information'], $token1->getCreatedInformation());
        self::assertSame('test-1', $token1->getPurpose());
        self::assertSame('uniquetoken-1', $token1->getValue());
        self::assertInstanceOf(DateTime::class, $token1->getCreatedAt());
        self::assertInstanceOf(DateTime::class, $token1->getExpiresAt());
        self::assertNull($token1->getUsedAt());
        self::assertNull($token1->getUsedInformation());

        $token2 = $this->factory($configuration)->create($user2, 'test-2');

        self::assertInstanceOf(Token::class, $token2);
        self::assertSame('string', $token2->getUserClass());
        self::assertSame('u2', $token2->getUserId());
        self::assertSame(['some', 'precious', 'information'], $token2->getCreatedInformation());
        self::assertSame('test-2', $token2->getPurpose());
        self::assertSame('uniquetoken-2', $token2->getValue());
        self::assertInstanceOf(DateTime::class, $token2->getCreatedAt());
        self::assertInstanceOf(DateTime::class, $token2->getExpiresAt());
        self::assertNull($token2->getUsedAt());
        self::assertNull($token2->getUsedInformation());
    }
}


1			<?php
2
3			namespace Yokai\SecurityTokenBundle\Tests\Factory;
4
5			use DateTime;
6			use Prophecy\Prophecy\ObjectProphecy;
7			use Yokai\SecurityTokenBundle\Configuration\TokenConfiguration;
8			use Yokai\SecurityTokenBundle\Configuration\TokenConfigurationRegistry;
9			use Yokai\SecurityTokenBundle\Entity\Token;
10			use Yokai\SecurityTokenBundle\Factory\TokenFactory;
11			use Yokai\SecurityTokenBundle\Generator\TokenGeneratorInterface;
12			use Yokai\SecurityTokenBundle\InformationGuesser\InformationGuesserInterface;
13			use Yokai\SecurityTokenBundle\Manager\UserManagerInterface;
14
15			/**
16			* @author Yann Eugoné <[email protected]>
17			*/
18			class TokenFactoryTest extends \PHPUnit_Framework_TestCase
19			{
20			/**
21			* @var InformationGuesserInterface\|ObjectProphecy
22			*/
23			private $informationGuesser;
24
25			/**
26			* @var UserManagerInterface\|ObjectProphecy
27			*/
28			private $userManager;
29
30			protected function setUp()
31			{
32			$this->informationGuesser = $this->prophesize(InformationGuesserInterface::class);
33			$this->userManager = $this->prophesize(UserManagerInterface::class);
34			}
35
36			protected function tearDown()
37			{
38			unset(
39			$this->informationGuesser,
40			$this->userManager
41			);
42			}
43
44			protected function factory(array $configuration)
45			{
46			return new TokenFactory(
47			new TokenConfigurationRegistry($configuration),
48			$this->informationGuesser->reveal(),
			0 ignored issues – show Bug introduced 2017-04-01 21:32 UTC by Report Bug Copy Issue Report The method `reveal` does only exist in `Prophecy\Prophecy\ObjectProphecy`, but not in `Yokai\SecurityTokenBundl...rmationGuesserInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
49			$this->userManager->reveal()
			0 ignored issues – show Bug introduced 2017-04-01 21:32 UTC by Report Bug Copy Issue Report The method `reveal` does only exist in `Prophecy\Prophecy\ObjectProphecy`, but not in `Yokai\SecurityTokenBundl...er\UserManagerInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
50			);
51			}
52
53			/**
54			* @test
55			*/
56			public function it_create_token_according_to_configuration()
57			{
58			/** @var TokenGeneratorInterface\|ObjectProphecy $generator */
59			$generator1 = $this->prophesize(TokenGeneratorInterface::class);
60			$generator1->generate()
61			->shouldBeCalledTimes(1)
62			->willReturn('uniquetoken-1');
63			$user1 = 'user-1';
64
65			/** @var TokenGeneratorInterface\|ObjectProphecy $generator */
66			$generator2 = $this->prophesize(TokenGeneratorInterface::class);
67			$generator2->generate()
68			->shouldBeCalledTimes(1)
69			->willReturn('uniquetoken-2');
70			$user2 = 'user-2';
71
72			$configuration = [
73			new TokenConfiguration('test-1', $generator1->reveal(), '+1 minute'),
74			new TokenConfiguration('test-2', $generator2->reveal(), '+2 minute'),
75			];
76
77			$this->userManager->getClass($user1)
			0 ignored issues – show Bug introduced 2017-04-01 21:32 UTC by Report Bug Copy Issue Report The method `getClass` does only exist in `Yokai\SecurityTokenBundl...er\UserManagerInterface`, but not in `Prophecy\Prophecy\ObjectProphecy`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
78			->shouldBeCalledTimes(1)
79			->willReturn('string');
80			$this->userManager->getClass($user2)
81			->shouldBeCalledTimes(1)
82			->willReturn('string');
83
84			$this->userManager->getId($user1)
			0 ignored issues – show Bug introduced 2017-04-01 21:32 UTC by Report Bug Copy Issue Report The method `getId` does only exist in `Yokai\SecurityTokenBundl...er\UserManagerInterface`, but not in `Prophecy\Prophecy\ObjectProphecy`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
85			->shouldBeCalledTimes(1)
86			->willReturn('u1');
87			$this->userManager->getId($user2)
88			->shouldBeCalledTimes(1)
89			->willReturn('u2');
90
91			$this->informationGuesser->get()
			0 ignored issues – show Bug introduced 2017-04-01 21:32 UTC by Report Bug Copy Issue Report The method `get` does only exist in `Yokai\SecurityTokenBundl...rmationGuesserInterface`, but not in `Prophecy\Prophecy\ObjectProphecy`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
92			->shouldBeCalledTimes(2)
93			->willReturn(['some', 'precious', 'information']);
94
95			$token1 = $this->factory($configuration)->create($user1, 'test-1');
96
97			self::assertInstanceOf(Token::class, $token1);
98			self::assertSame('string', $token1->getUserClass());
99			self::assertSame('u1', $token1->getUserId());
100			self::assertSame(['some', 'precious', 'information'], $token1->getCreatedInformation());
101			self::assertSame('test-1', $token1->getPurpose());
102			self::assertSame('uniquetoken-1', $token1->getValue());
103			self::assertInstanceOf(DateTime::class, $token1->getCreatedAt());
104			self::assertInstanceOf(DateTime::class, $token1->getExpiresAt());
105			self::assertNull($token1->getUsedAt());
106			self::assertNull($token1->getUsedInformation());
107
108			$token2 = $this->factory($configuration)->create($user2, 'test-2');
109
110			self::assertInstanceOf(Token::class, $token2);
111			self::assertSame('string', $token2->getUserClass());
112			self::assertSame('u2', $token2->getUserId());
113			self::assertSame(['some', 'precious', 'information'], $token2->getCreatedInformation());
114			self::assertSame('test-2', $token2->getPurpose());
115			self::assertSame('uniquetoken-2', $token2->getValue());
116			self::assertInstanceOf(DateTime::class, $token2->getCreatedAt());
117			self::assertInstanceOf(DateTime::class, $token2->getExpiresAt());
118			self::assertNull($token2->getUsedAt());
119			self::assertNull($token2->getUsedInformation());
120			}
121			}
122

yokai-php / security-token-bundle

Push — master ( 3e963f...fbd0cf )

TokenFactoryTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like