DeleteArchivist::archive() - Code Metrics - Inspection of "3.0" - yokai-php/security-token-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#32)

by Yann

created 2018-10-13 07:22 UTC

DeleteArchivist::archive() A

↳ Parent: DeleteArchivist

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	19
c	0
b	0
f	0
ccs	0
cts	16
cp	0
rs	9.6333
cc	2
nc	2
nop	1
crap	6

<?php

namespace Yokai\SecurityTokenBundle\Archive;

use DateTime;
use Doctrine\ORM\EntityRepository;

/**
 * This archivist is removing all outdated tokens based on the `keepUntil` property.
 *
 * @author Yann Eugoné <[email protected]>
 */
class DeleteArchivist implements ArchivistInterface
{
    /**
     * @var EntityRepository
     */
    private $tokenRepository;

    /**
     * @param EntityRepository $tokenRepository The token entity repository
     */
    public function __construct(EntityRepository $tokenRepository)
    {
        $this->tokenRepository = $tokenRepository;
    }

    /**
     * @inheritDoc
     */
    public function archive(string $purpose = null): int
    {
        $builder = $this->tokenRepository->createQueryBuilder('token')
            ->delete($this->tokenRepository->getClassName(), 'token');

        $builder
            ->where($builder->expr()->lt('token.keepUntil', ':now'))
            ->setParameter('now', new DateTime())
        ;

        if ($purpose) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $builder
                ->andWhere($builder->expr()->eq('token.purpose', ':purpose'))
                ->setParameter('purpose', $purpose)
            ;
        }

        return intval($builder->getQuery()->execute());
    }
}


1			<?php
2
3			namespace Yokai\SecurityTokenBundle\Archive;
4
5			use DateTime;
6			use Doctrine\ORM\EntityRepository;
7
8			/**
9			* This archivist is removing all outdated tokens based on the `keepUntil` property.
10			*
11			* @author Yann Eugoné <[email protected]>
12			*/
13			class DeleteArchivist implements ArchivistInterface
14			{
15			/**
16			* @var EntityRepository
17			*/
18			private $tokenRepository;
19
20			/**
21			* @param EntityRepository $tokenRepository The token entity repository
22			*/
23			public function __construct(EntityRepository $tokenRepository)
24			{
25			$this->tokenRepository = $tokenRepository;
26			}
27
28			/**
29			* @inheritDoc
30			*/
31			public function archive(string $purpose = null): int
32			{
33			$builder = $this->tokenRepository->createQueryBuilder('token')
34			->delete($this->tokenRepository->getClassName(), 'token');
35
36			$builder
37			->where($builder->expr()->lt('token.keepUntil', ':now'))
38			->setParameter('now', new DateTime())
39			;
40
41			if ($purpose) {
			0 ignored issues – show Bug Best Practice introduced 2018-10-12 20:50 UTC by Report Bug Copy Issue Report The expression `$purpose` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
42			$builder
43			->andWhere($builder->expr()->eq('token.purpose', ':purpose'))
44			->setParameter('purpose', $purpose)
45			;
46			}
47
48			return intval($builder->getQuery()->execute());
49			}
50			}
51

yokai-php / security-token-bundle

Pull Request — master (#32)

DeleteArchivist::archive() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like