Issues in Notification.php (master) - Issues in master - yokai-php/messenger-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Issues (8)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Entity/Notification.php (1 issue)

Labels

Bug 1

Severity

Major 1

Matthieu Crinquand 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Yokai\MessengerBundle\Entity;

use DateTime;
use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\Common\Collections\Collection;
use Doctrine\Common\Util\ClassUtils;
use Yokai\MessengerBundle\Recipient\IdentifierRecipientInterface;

/**
 * @author Yann Eugoné <[email protected]>
 */
class Notification
{
    /**
     * @var int
     */
    private $id;

    /**
     * @var string
     */
    private $subject;

    /**
     * @var string
     */
    private $body;

    /**
     * @var NotificationAttachment|Collection
     */
    private $attachments;

    /**
     * @var DateTime
     */
    private $recordedAt;

    /**
     * @var string
     */
    private $recipientClass;

    /**
     * @var string
     */
    private $recipientId;

    /**
     * @var DateTime|null
     */
    private $deliveredAt;

    /**
     * @param string                       $subject
     * @param string                       $body
     * @param IdentifierRecipientInterface $recipient
     */
    public function __construct($subject, $body, IdentifierRecipientInterface $recipient)
    {
        $this->subject = $subject;
        $this->body = $body;
        $this->recipientClass = ClassUtils::getClass($recipient);
        $this->recipientId = $recipient->getId();
        $this->recordedAt = new DateTime('now');

        $this->attachments = new ArrayCollection();
    }

    /**
     * @return integer
     */
    public function getId()
    {
        return $this->id;
    }

    /**
     * @return string
     */
    public function getSubject()
    {
        return $this->subject;
    }

    /**
     * @return string
     */
    public function getBody()
    {
        return $this->body;
    }

    /**
     * @return NotificationAttachment[]
     */
    public function getAttachments()
    {
        return $this->attachments->toArray();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * @return string
     */
    public function getRecipientClass()
    {
        return $this->recipientClass;
    }

    /**
     * @return string
     */
    public function getRecipientId()
    {
        return $this->recipientId;
    }

    /**
     * @return DateTime
     */
    public function getRecordedAt()
    {
        return $this->recordedAt;
    }

    /**
     * @return bool
     */
    public function isDelivered()
    {
        return null !== $this->deliveredAt;
    }

    /**
     * @return DateTime|null
     */
    public function getDeliveredAt()
    {
        return $this->deliveredAt;
    }

    /**
     */
    public function setDelivered()
    {
        if (null !== $this->deliveredAt) {
            return; //immutable
        }

        $this->deliveredAt = new DateTime('now');
    }

    /**
     * @param NotificationAttachment $attachment
     */
    public function addNotificationAttachment(NotificationAttachment $attachment)
    {
        $this->attachments->add($attachment);
    }
}


1		<?php
2
3		namespace Yokai\MessengerBundle\Entity;
4
5		use DateTime;
6		use Doctrine\Common\Collections\ArrayCollection;
7		use Doctrine\Common\Collections\Collection;
8		use Doctrine\Common\Util\ClassUtils;
9		use Yokai\MessengerBundle\Recipient\IdentifierRecipientInterface;
10
11		/**
12		* @author Yann Eugoné <[email protected]>
13		*/
14		class Notification
15		{
16		/**
17		* @var int
18		*/
19		private $id;
20
21		/**
22		* @var string
23		*/
24		private $subject;
25
26		/**
27		* @var string
28		*/
29		private $body;
30
31		/**
32		* @var NotificationAttachment\|Collection
33		*/
34		private $attachments;
35
36		/**
37		* @var DateTime
38		*/
39		private $recordedAt;
40
41		/**
42		* @var string
43		*/
44		private $recipientClass;
45
46		/**
47		* @var string
48		*/
49		private $recipientId;
50
51		/**
52		* @var DateTime\|null
53		*/
54		private $deliveredAt;
55
56		/**
57		* @param string $subject
58		* @param string $body
59		* @param IdentifierRecipientInterface $recipient
60		*/
61	3	public function __construct($subject, $body, IdentifierRecipientInterface $recipient)
62		{
63	3	$this->subject = $subject;
64	3	$this->body = $body;
65	3	$this->recipientClass = ClassUtils::getClass($recipient);
66	3	$this->recipientId = $recipient->getId();
67	3	$this->recordedAt = new DateTime('now');
68
69	3	$this->attachments = new ArrayCollection();
70	3	}
71
72		/**
73		* @return integer
74		*/
75	1	public function getId()
76		{
77	1	return $this->id;
78		}
79
80		/**
81		* @return string
82		*/
83	2	public function getSubject()
84		{
85	2	return $this->subject;
86		}
87
88		/**
89		* @return string
90		*/
91	2	public function getBody()
92		{
93	2	return $this->body;
94		}
95
96		/**
97		* @return NotificationAttachment[]
98		*/
99		public function getAttachments()
100		{
101		return $this->attachments->toArray();
		0 ignored issues – show Bug introduced 2016-10-11 13:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `toArray` does only exist in `Doctrine\Common\Collections\Collection`, but not in `Yokai\MessengerBundle\En...\NotificationAttachment`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
102		}
103
104		/**
105		* @return string
106		*/
107	2	public function getRecipientClass()
108		{
109	2	return $this->recipientClass;
110		}
111
112		/**
113		* @return string
114		*/
115	2	public function getRecipientId()
116		{
117	2	return $this->recipientId;
118		}
119
120		/**
121		* @return DateTime
122		*/
123	1	public function getRecordedAt()
124		{
125	1	return $this->recordedAt;
126		}
127
128		/**
129		* @return bool
130		*/
131	1	public function isDelivered()
132		{
133	1	return null !== $this->deliveredAt;
134		}
135
136		/**
137		* @return DateTime\|null
138		*/
139	2	public function getDeliveredAt()
140		{
141	2	return $this->deliveredAt;
142		}
143
144		/**
145		*/
146	2	public function setDelivered()
147		{
148	2	if (null !== $this->deliveredAt) {
149	1	return; //immutable
150		}
151
152	2	$this->deliveredAt = new DateTime('now');
153	2	}
154
155		/**
156		* @param NotificationAttachment $attachment
157		*/
158		public function addNotificationAttachment(NotificationAttachment $attachment)
159		{
160		$this->attachments->add($attachment);
161		}
162		}
163

yokai-php / messenger-bundle

Issues (8)

Security Analysis no request data

Entity/Notification.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like