Yokai\MessengerBundle\Channel\DoctrineChannel

Complexity

Total Complexity

5

Size/Duplication

Total Lines	60
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	7

Test Coverage

Coverage

79.17%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	supports()	0	4	1
A	configure()	0	6	1
A	handle()	0	23	2

<?php

namespace Yokai\MessengerBundle\Channel;

use Doctrine\ORM\EntityManager;
use Symfony\Component\Filesystem\Filesystem;
use Symfony\Component\OptionsResolver\OptionsResolver;
use Yokai\MessengerBundle\Delivery;
use Yokai\MessengerBundle\Entity\Notification;
use Yokai\MessengerBundle\Entity\NotificationAttachment;
use Yokai\MessengerBundle\Recipient\IdentifierRecipientInterface;

/**
 * @author Yann Eugoné <eugone.yann@gmail.com>
 */
class DoctrineChannel implements ChannelInterface
{
    /**
     * @var EntityManager
     */
    private $manager;

    /**
     * @param EntityManager $manager
     */
    public function __construct(EntityManager $manager)

You have injected the EntityManager via parameter $manager. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via getManager() each time you need it.

    {
        $this->manager = $manager;
    }

    /**
     * @inheritdoc
     */
    public function supports($recipient)
    {
        return $recipient instanceof IdentifierRecipientInterface;
    }

    /**
     * @inheritdoc
     */
    public function configure(OptionsResolver $resolver)
    {
        $resolver
            ->setDefined(['attachments_path'])
        ;
    }

    /**
     * @inheritdoc
     */
    public function handle(Delivery $delivery)
    {
        $options = $delivery->getOptions();

        $notification = new Notification(
            $delivery->getSubject(),
            $delivery->getBody(),
            $delivery->getRecipient()
        );

        $fs = new Filesystem();
        foreach ($delivery->getAttachments() as $attachment) {
            $fs->copy(
                $attachment->getPathname(),
                sprintf('%s/%s', $options['attachments_path'], $attachment->getBasename())
            );
            $notificationAttachment = new NotificationAttachment($notification, $attachment->getBasename());
            $notification->addNotificationAttachment($notificationAttachment);
        }

        $this->manager->persist($notification);
        $this->manager->flush($notification);
    }
}