ConstantListTranslatedEnumTest::getEnum() - Code Metrics - yokai-php/enum-bundle - Measure and Improve Code Quality continuously with Scrutinizer

ConstantListTranslatedEnumTest::getEnum() A
last analyzed 2020-06-25 21:39 UTC

↳ Parent: ConstantListTranslatedEnumTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
rs	9.9332
c	0
b	0
f	0
cc	1
nc	1
nop	2

<?php declare(strict_types=1);

namespace Yokai\EnumBundle\Tests;

use Prophecy\Prophecy\ObjectProphecy;
use Symfony\Contracts\Translation\TranslatorInterface;
use Yokai\EnumBundle\ConstantExtractor;
use Yokai\EnumBundle\ConstantListTranslatedEnum;
use Yokai\EnumBundle\Tests\Fixtures\Vehicle;

/**
 * @author Yann Eugoné <[email protected]>
 */
class ConstantListTranslatedEnumTest extends TestCase
{
    /**
     * @var TranslatorInterface|ObjectProphecy
     */
    private $translator;

    protected function setUp(): void
    {
        $this->translator = $this->prophesize(TranslatorInterface::class);
    }

    public function getEnum(string $pattern, string $name): ConstantListTranslatedEnum
    {
        return new ConstantListTranslatedEnum(
            new ConstantExtractor(),
            $pattern,
            $this->translator->reveal(),
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            $name.'.%s',
            $name
        );
    }

    public function testVehicleEnums(): void
    {
        $type = $this->getEnum(Vehicle::class.'::TYPE_*', 'vehicle.type');
        $this->translator->trans('vehicle.type.bike', [], 'messages')->shouldBeCalledTimes(1)->willReturn('Moto');
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $this->translator->trans('vehicle.type.car', [], 'messages')->shouldBeCalledTimes(1)->willReturn('Voiture');
        $this->translator->trans('vehicle.type.bus', [], 'messages')->shouldBeCalledTimes(1)->willReturn('Bus');
        self::assertSame('vehicle.type', $type->getName());
        self::assertSame(
            ['bike' => 'Moto', 'car' => 'Voiture', 'bus' => 'Bus'],
            $type->getChoices()
        );

        $engine = $this->getEnum(Vehicle::class.'::ENGINE_*', 'vehicle.engine');
        $this->translator->trans('vehicle.engine.electic', [], 'messages')->shouldBeCalledTimes(1)->willReturn('Electrique');
        $this->translator->trans('vehicle.engine.combustion', [], 'messages')->shouldBeCalledTimes(1)->willReturn('Combustion');
        self::assertSame('vehicle.engine', $engine->getName());
        self::assertSame(
            ['electic' => 'Electrique', 'combustion' => 'Combustion'],
            $engine->getChoices()
        );

        $brand = $this->getEnum(Vehicle::class.'::BRAND_*', 'vehicle.brand');
        $this->translator->trans('vehicle.brand.renault', [], 'messages')->shouldBeCalledTimes(1)->willReturn('Renault');
        $this->translator->trans('vehicle.brand.volkswagen', [], 'messages')->shouldBeCalledTimes(1)->willReturn('Volkswagen');
        $this->translator->trans('vehicle.brand.toyota', [], 'messages')->shouldBeCalledTimes(1)->willReturn('Toyota');
        self::assertSame('vehicle.brand', $brand->getName());
        self::assertSame(
            ['renault' => 'Renault', 'volkswagen' => 'Volkswagen', 'toyota' => 'Toyota'],
            $brand->getChoices()
        );
    }
}


ConstantListTranslatedEnumTest::getEnum() A
last analyzed 2020-06-25 21:39 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

1			<?php declare(strict_types=1);
2
3			namespace Yokai\EnumBundle\Tests;
4
5			use Prophecy\Prophecy\ObjectProphecy;
6			use Symfony\Contracts\Translation\TranslatorInterface;
7			use Yokai\EnumBundle\ConstantExtractor;
8			use Yokai\EnumBundle\ConstantListTranslatedEnum;
9			use Yokai\EnumBundle\Tests\Fixtures\Vehicle;
10
11			/**
12			* @author Yann Eugoné <[email protected]>
13			*/
14			class ConstantListTranslatedEnumTest extends TestCase
15			{
16			/**
17			* @var TranslatorInterface\|ObjectProphecy
18			*/
19			private $translator;
20
21			protected function setUp(): void
22			{
23			$this->translator = $this->prophesize(TranslatorInterface::class);
24			}
25
26			public function getEnum(string $pattern, string $name): ConstantListTranslatedEnum
27			{
28			return new ConstantListTranslatedEnum(
29			new ConstantExtractor(),
30			$pattern,
31			$this->translator->reveal(),
			0 ignored issues – show Bug introduced 2020-06-25 21:38 UTC by Report Bug Copy Issue Report The method `reveal` does only exist in `Prophecy\Prophecy\ObjectProphecy`, but not in `Symfony\Contracts\Translation\TranslatorInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
32			$name.'.%s',
33			$name
34			);
35			}
36
37			public function testVehicleEnums(): void
38			{
39			$type = $this->getEnum(Vehicle::class.'::TYPE_*', 'vehicle.type');
40			$this->translator->trans('vehicle.type.bike', [], 'messages')->shouldBeCalledTimes(1)->willReturn('Moto');
			0 ignored issues – show Bug introduced 2020-06-25 21:38 UTC by Report Bug Copy Issue Report The method `trans` does only exist in `Symfony\Contracts\Translation\TranslatorInterface`, but not in `Prophecy\Prophecy\ObjectProphecy`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
41			$this->translator->trans('vehicle.type.car', [], 'messages')->shouldBeCalledTimes(1)->willReturn('Voiture');
42			$this->translator->trans('vehicle.type.bus', [], 'messages')->shouldBeCalledTimes(1)->willReturn('Bus');
43			self::assertSame('vehicle.type', $type->getName());
44			self::assertSame(
45			['bike' => 'Moto', 'car' => 'Voiture', 'bus' => 'Bus'],
46			$type->getChoices()
47			);
48
49			$engine = $this->getEnum(Vehicle::class.'::ENGINE_*', 'vehicle.engine');
50			$this->translator->trans('vehicle.engine.electic', [], 'messages')->shouldBeCalledTimes(1)->willReturn('Electrique');
51			$this->translator->trans('vehicle.engine.combustion', [], 'messages')->shouldBeCalledTimes(1)->willReturn('Combustion');
52			self::assertSame('vehicle.engine', $engine->getName());
53			self::assertSame(
54			['electic' => 'Electrique', 'combustion' => 'Combustion'],
55			$engine->getChoices()
56			);
57
58			$brand = $this->getEnum(Vehicle::class.'::BRAND_*', 'vehicle.brand');
59			$this->translator->trans('vehicle.brand.renault', [], 'messages')->shouldBeCalledTimes(1)->willReturn('Renault');
60			$this->translator->trans('vehicle.brand.volkswagen', [], 'messages')->shouldBeCalledTimes(1)->willReturn('Volkswagen');
61			$this->translator->trans('vehicle.brand.toyota', [], 'messages')->shouldBeCalledTimes(1)->willReturn('Toyota');
62			self::assertSame('vehicle.brand', $brand->getName());
63			self::assertSame(
64			['renault' => 'Renault', 'volkswagen' => 'Volkswagen', 'toyota' => 'Toyota'],
65			$brand->getChoices()
66			);
67			}
68			}
69

yokai-php / enum-bundle

ConstantListTranslatedEnumTest::getEnum() A last analyzed 2020-06-25 21:39 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

ConstantListTranslatedEnumTest::getEnum() A
last analyzed 2020-06-25 21:39 UTC