Issues in DDDGenerator.php (master) - Issues in master - yoghi/madda - Measure and Improve Code Quality continuously with Scrutinizer

Issues (325)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Generator/DDDGenerator.php (25 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Yoghi\Bundle\MaddaBundle\Generator;

/*
 * This file is part of the MADDA project.
 *
 * (c) Stefano Tamagnini <>
 *
 * This source file is subject to the GPLv3 license that is bundled
 * with this source code in the file LICENSE.
 */

use League\Flysystem\Adapter\Local;
use Psr\Log\LoggerInterface;
use Yoghi\Bundle\MaddaBundle\Model\Reader;

/**
 * @author Stefano Tamagnini <>
 */
class DDDGenerator
{
    /**
     * [$logger description].
     *
     * @var \Psr\Log\LoggerInterface
     */
    private $logger;

    /**
     * Reader model file.
     *
     * @var \Yoghi\Bundle\MaddaBundle\Model\Reader
     */
    private $rym;

    /**
     * Model classes: class -> namespace.
     *
     * @var array
     */
    private $modelClass;

    /**
     * Comments of model classes.
     *
     * @var array
     */
    private $modelComments;

    /**
     * Fields of model classes.
     *
     * @var array
     */
    private $fieldsClass;

    /**
     * Array process errors.
     *
     * @var array
     */
    private $errors;

    public function __construct()
    {
        $this->rym = new Reader();
        $this->errors = [];
        $this->modelClass = [];
    }

    public function setLogger(LoggerInterface $logger)
    {
        $this->logger = $logger;
    }

    /**
     * [analyze description].
     *
     * @param [type] $fullPathFile [description]

     *
     * @return [type] [description]

     */
    public function analyze($fullPathFile)
    {
        $this->rym->readYaml($fullPathFile);
    }

    /**
     * @param string $message
     */
    private function info($message, $context = [])
    {
        if (!is_null($this->logger)) {
            $this->logger->info($message, $context);
        }
    }

    /**
     * @param string $message
     */
    private function error($message, $context = [])
    {
        if (!is_null($this->logger)) {
            $this->logger->error($message, $context);
        }
    }

    /**
     * errori durante la generazione.
     *
     * @return array of string
     */
    public function getErrors()
    {
        return $this->errors;
    }

    /**
     * [generate description].
     *
     * @param Local $directoryOutput directory where write generated class
     */
    public function generate(Local $directoryOutput)
    {
        //$is_constructor_enable = true;

        //$ddd_is_root_aggregate = false;


        $specListClasses = $this->rym->getClassesDefinition();
        foreach ($specListClasses as $className => $properties) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $this->info('Generate class', ['class' => $className]); //, 'properties' => $properties

            if (!array_key_exists('ddd', $properties)) {
                $this->error('missing ddd section into yml for class', ['class' => $className]);
                $this->errors[] = 'missing ddd section into yml for class '.$className;
                $this->info('force '.$className.' to type class');
                $properties['ddd'] = [];
                $properties['ddd']['type'] = 'class';
            }

            $namespace = '';
            if (array_key_exists('namespace', $properties)) {
                $namespace = $properties['namespace'];
            }

            $classComments = 'No comment found on ddd model';
            if (array_key_exists('description', $properties)) {
                $classComments = $properties['description'];
                $this->info('Found description :'.$classComments);
            }

            //FIXME: switch with $dddType as key


            $generated = false;
            $dddType = $properties['ddd']['type'];
            if (in_array($dddType, ['interface'])) {

                $g = new ClassGenerator($namespace, $className, $classComments);
                $g->setLogger($this->logger);
                $config = new ClassConfig();
                $config->isInterface = true;
                $g->generateClassType($properties, $this->modelClass, $this->modelComments, $config);
                $g->createFileOnDir($directoryOutput);
                $generated = true; //FIXME: use $g for determinate! -> take error from generator

                if ($generated) {
                    $this->fieldsClass[$namespace.'\\'.$className] = $properties['fields']; //ONLY IF VALID!!!

                }
                // DOMANDA: perche' non passarle tutte??
                // if (array_key_exists('fields', $properties)) {

                //     $types_field[$className] = $properties['fields'];

                // }
                // $this->generateClassType($fileInterface, $interface, $properties, $types_reference, $types_description, false, true, true, false, false, $filesystem, $io);

            }

            // NOTE: class aren't ddd type, we haven't section on ddd definition
            if (in_array($dddType, ['class'])) {

                $g = new ClassGenerator($namespace, $className, $classComments);
                $g->setLogger($this->logger);
                $config = new ClassConfig();
                $config->isInterface = false;
                $config->haveConstructor = true;
                $g->generateClassType($properties, $this->modelClass, $this->modelComments, $config);
                $g->createFileOnDir($directoryOutput);
                $generated = true; //FIXME: use $g for determinate! -> take error from generator

                if ($generated) {
                    $this->fieldsClass[$namespace.'\\'.$className] = $properties['fields']; //ONLY IF VALID!!!

                }
                // DOMANDA: perche' non passarle tutte??
                // if (array_key_exists('fields', $properties)) {

                //     $types_field[$className] = $properties['fields'];

                // }
                // $this->generateClassType($fileInterface, $interface, $properties, $types_reference, $types_description, false, true, true, false, false, $filesystem, $io);

            }

            if (in_array($dddType, ['events'])) {
                //FIXME: impossible! events exist in relation on aggregateRoot

                $this->error('events exist in relation on aggregateRoot', ['class' => $className]);
                $this->errors[] = 'events exist in relation on aggregateRoot, event class '.$className.' cannot exist!';
            }

            if (!$generated) {
                $dddDefinition = $this->rym->getDomainDefinitionAttributes($dddType);

                if (is_null($dddDefinition)) {
                    $this->error('Missing ddd reference for : '.$dddType.' into '.$className, ['class' => $className]);
                    $this->errors[] = 'Missing ddd reference for : '.$dddType.' into '.$className;
                } else {
                    if (array_key_exists('package', $dddDefinition)) {
                        $namespace = $dddDefinition['package'];
                    }

                    if (empty($namespace)) {
                        $this->error('Missing namespace', ['class' => $className]);
                        $this->errors[] = 'Missing namespace for '.$className;
                    }

                    $createGetter = false;
                    $createSetter = false;
                    if (array_key_exists('getter', $dddDefinition)) {
                        $createGetter = $dddDefinition['getter'];
                    }
                    if (array_key_exists('setter', $dddDefinition)) {
                        $createSetter = $dddDefinition['setter'];
                    }

                    $isRootAggregate = $dddType == 'aggregate' && isset($properties['ddd']['root']) && boolval($properties['ddd']['root']) ? true : false;

                    $this->info('Method required', ['class' => $className, 'getter' => $createGetter, 'setter' => $createSetter, 'aggregateRoot' => $isRootAggregate]);

                    if (array_key_exists('extend', $dddDefinition)) {
                        $dddExtendDefinition = $dddDefinition['extend'];
                        if (!array_key_exists('extend', $properties)) {
                            $properties['extend'] = $dddExtendDefinition; //No multi-inheritance
                        }
                    }

                    $dddReferenceFields = [];
                    if (array_key_exists('fields', $dddDefinition)) {
                        foreach ($dddDefinition['fields'] as $key => $value) {
                            $dddReferenceFields[$key] = $value;
                        }
                    }

                    //TODO: gestire gli [] dentro la definizione del modello se serve...


                    //TODO: aggiungere le validazioni

                    // validationRule:
                    //   events:
                    //     create:
                    //       fields: [ id, sessione, tipologiaCampo]
                    //     delete:
                    //       fields: [ id ]
                    //     addDocument:
                    //       fields: [ id, documentoCorrelato ]

                    if (array_key_exists('events', $properties)) {
                        //genero altre classi per ogni evento!
                        $eventsProperties = $this->rym->getDomainDefinitionAttributes('events');
                        $eventsNamespace = $eventsProperties['package'];
                        $eventsImplement = '';
                        if (array_key_exists('implement', $eventsProperties)) {
                            $eventsImplement = $eventsProperties['implement'];
                        }

                        $eventsExtend = '';
                        if (array_key_exists('extend', $eventsProperties)) {
                            $eventsExtend = $eventsProperties['extend'];
                        }

                        if (!array_key_exists($eventsImplement, $this->modelClass)) {
                            $this->error('Missing implement class '.$eventsImplement, ['class' => $className]);
                            $this->errors[] = 'Missing implement '.$eventsImplement.' for '.$className;
                            continue;
                        }
                        $namespaceImplementClass = $this->modelClass[$eventsImplement];
                        $eventsImplementFull = $namespaceImplementClass.'\\'.$eventsImplement;

                        $eventsField = [];
                        if (array_key_exists('fields', $eventsProperties)) {
                            foreach ($eventsProperties['fields'] as $key => $value) {
                                $eventsField[$key] = $value;
                            }
                        }

                        //field's inheritance
                        if (array_key_exists($eventsImplementFull, $this->fieldsClass)) {
                            $fieldsImplementClass = $this->fieldsClass[$eventsImplementFull];
                            foreach ($fieldsImplementClass as $key => $value) {
                                $eventsField[$key] = $value;
                            }
                        }

                        $eventsToCreate = [];
                        if (array_key_exists('events', $properties)) {
                            $eventsToCreate = $properties['events'];
                        }

                        if (array_key_exists('events', $dddDefinition)) {
                            $eventsToCreate = array_merge($dddDefinition['events'], $eventsToCreate);
                        }

                        foreach ($eventsToCreate as $event) {
                            $eventClassName = $className.str_replace('_', '', ucwords($event, '_')).'Event';
                            $eventClassComments = 'Event '.$event.' for Aggregate Root '.$className;

                            $propertiesEventClass = [];
                            if (!empty($eventsExtend)) {
                                $propertiesEventClass['extend'] = $eventsExtend;
                            }
                            if (!empty($eventsImplement)) {
                                $propertiesEventClass['implements'] = $eventsImplementFull;
                            }

                            $propertiesEventClass['fields'] = $eventsField;

                            $this->info('Create Event', ['event' => $event, 'class' => $className, 'extend' => $eventsExtend, 'implement' => $eventsImplementFull, 'fields' => $eventsField]);

                            $g = new ClassGenerator($eventsNamespace, $eventClassName, $eventClassComments);
                            $g->setLogger($this->logger);
                            $config = new ClassConfig();
                            $config->isInterface = false;
                            $config->haveConstructor = true;
                            $config->isFinalClass = true; //don't wnat cycle dependency
                            $config->haveGetter = true;
                            $config->haveSetter = false;
                            $g->generateClassType($propertiesEventClass, $this->modelClass, $this->modelComments, $config);
                            $g->createFileOnDir($directoryOutput);
                            $generated = true;
                        }

                        if ($generated) {
                            $this->fieldsClass[$namespace.'\\'.$className] = $eventsField; //ONLY IF VALID!!!

                        }
                    }

                    if (array_key_exists('enum', $properties)) {
                        $enumClassList = $properties['enum'];
                        foreach ($enumClassList as $enumClassName) {
                            $enumNamespace = $namespace.'\\'.$className;
                            $propertiesEnumClass = [
                                'extend' => $namespace.'\\'.$className,
                            ];
                            $actionName = 'instance';
                            $propertiesEnumClass['methods'] = [];
                            $propertiesEnumClass['methods'][$actionName] = [];
                            $propertiesEnumClass['methods'][$actionName]['params'] = [];
                            $propertiesEnumClass['methods'][$actionName]['static'] = true;
                            $propertiesEnumClass['methods'][$actionName]['@return'] = $enumNamespace.'\\'.$enumClassName;
                            $body = 'self::$instance = new '.$enumClassName.'();';
                            $body .= 'return self::$instance;';
                            $propertiesEnumClass['methods'][$actionName]['body'] = $body;

                            //TODO: pensare se qui va bene cosi... potrebbe il ClassGenerator sapere come fare questo costruttore?

                            $actionName = '__construct';
                            $propertiesEnumClass['methods'][$actionName] = [];
                            $propertiesEnumClass['methods'][$actionName]['visibility'] = 'private';
                            $propertiesEnumClass['methods'][$actionName]['params'] = [];
                            $propertiesEnumClass['methods'][$actionName]['static'] = false;
                            $propertiesEnumClass['methods'][$actionName]['description'] = 'costruttore';
                            $body = '$this->name = \''.$enumClassName.'\';';
                            $propertiesEnumClass['methods'][$actionName]['body'] = $body;

                            $enumClassComments = 'Child of '.$className.' '.$enumClassName;
                            $g = new ClassGenerator($enumNamespace, $enumClassName, $enumClassComments);
                            $g->setLogger($this->logger);
                            $configEnum = new ClassConfig();
                            $configEnum->isInterface = false;
                            $configEnum->haveConstructor = true;
                            $configEnum->isFinalClass = true; //don't wnat cycle dependency
                            $configEnum->haveGetter = true;
                            $configEnum->haveSetter = false;
                            $g->generateClassType($propertiesEnumClass, $this->modelClass, $this->modelComments, $configEnum);
                            $g->createFileOnDir($directoryOutput);
                            $generated = true;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                        }

                        $properties['fields']['name'] = [
                            'primitive' => 'string',
                            'description' => 'nome esplicativo della enum',
                            'getter' => true,
                        ];

                        $config = new ClassConfig();
                        $config->isInterface = false;
                        $config->haveConstructor = false;
                        $config->isFinalClass = false;
                        $config->isEnum = true;
                        $config->haveGetter = $createGetter;
                        $config->haveSetter = $createSetter;
                    } else {
                        $config = new ClassConfig();
                        $config->isInterface = false;
                        $config->haveConstructor = true;
                        $config->isFinalClass = true; //don't wnat cycle dependency
                        $config->haveGetter = $createGetter;
                        $config->haveSetter = $createSetter;
                    }

                    //NORMAL GENERATION
                    $g = new ClassGenerator($namespace, $className, $classComments);
                    $g->setLogger($this->logger);
                    $g->generateClassType($properties, $this->modelClass, $this->modelComments, $config);
                    $g->createFileOnDir($directoryOutput);
                    $generated = true;
                }
            }

            if ($generated) {
                $this->modelClass[$className] = $namespace;
                $this->modelComments[$className] = $classComments;
            }
        } //end class generation
    }
}


1			<?php
2
3			namespace Yoghi\Bundle\MaddaBundle\Generator;
4
5			/*
6			* This file is part of the MADDA project.
7			*
8			* (c) Stefano Tamagnini <>
9			*
10			* This source file is subject to the GPLv3 license that is bundled
11			* with this source code in the file LICENSE.
12			*/
13
14			use League\Flysystem\Adapter\Local;
15			use Psr\Log\LoggerInterface;
16			use Yoghi\Bundle\MaddaBundle\Model\Reader;
17
18			/**
19			* @author Stefano Tamagnini <>
20			*/
21			class DDDGenerator
22			{
23			/**
24			* [$logger description].
25			*
26			* @var \Psr\Log\LoggerInterface
27			*/
28			private $logger;
29
30			/**
31			* Reader model file.
32			*
33			* @var \Yoghi\Bundle\MaddaBundle\Model\Reader
34			*/
35			private $rym;
36
37			/**
38			* Model classes: class -> namespace.
39			*
40			* @var array

yoghi / madda

Issues (325)

Security Analysis no request data

Generator/DDDGenerator.php (25 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like