Yoghi\Bundle\MaddaBundleTest\Utils\AbstractCommonLogTest

Complexity

Total Complexity

8

Size/Duplication

Total Lines	55
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	1
Bugs	1	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	readLog()	0	6	1
A	setUpBeforeClass()	0	4	1
A	setUp()	0	15	2
A	tearDown()	0	15	4

<?php

namespace Yoghi\Bundle\MaddaBundleTest\Utils;

use Monolog\Formatter\LineFormatter;
use Monolog\Handler\StreamHandler;
use Monolog\Logger;
use org\bovigo\vfs\vfsStream;

trait AbstractCommonLogTest
{
    private static $directoryV;

    /**
     * [$logger description].
     *
     * @var Psr\Log\LoggerInterface
     */
    private $logger;

    public static function setUpBeforeClass()
    {
        self::$directoryV = vfsStream::setup();
    }

    public function setUp()
    {
        $this->logger = new Logger('phpunit-logger');

It seems like new \Monolog\Logger('phpunit-logger') of type object<Monolog\Logger> is incompatible with the declared type object<Yoghi\Bundle\MaddaBundleTest\Utils\Psr\Log\LoggerInterface> of property $logger.

        $directoryLogOutput = self::$directoryV->url().'/log';
        if (!file_exists($directoryLogOutput)) {
            mkdir($directoryLogOutput, 0700, true);
        }
        $output = "%level_name% > %message% %context% %extra%\n";
        $formatter = new LineFormatter($output);
        $handler = new StreamHandler($directoryLogOutput.'/phpunit.log', Logger::DEBUG, true, null, false);
        touch($directoryLogOutput.'/phpunit.log');
        $handler->setFormatter($formatter);
        $this->logger->pushHandler($handler);
        $this->logger->info('Avviato test -> '.$this->getName());

It seems like getName() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    protected function readLog()
    {
        $fileLog = self::$directoryV->url().'/log/phpunit.log';

        return file_get_contents($fileLog);
    }

    public function tearDown()
    {
        $fileLog = self::$directoryV->url().'/log/phpunit.log';
        if ($this->hasFailed()) {

It seems like hasFailed() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            echo "\n---- LOG ----\n";
            if (is_readable($fileLog)) {
                echo file_get_contents($fileLog);
            }
            echo "------------\n";
        }
        if (file_exists($fileLog)) {
            unlink($fileLog);
        }
        $this->logger = null;
    }
}