Yoanm\SymfonyJsonRpcHttpServer\Infra\Resolver\ServiceNameResolver

Complexity

Total Complexity

3

Size/Duplication

Total Lines	16
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	resolve()	0	5	2
A	addMethodMapping()	0	3	1

<?php
namespace Yoanm\SymfonyJsonRpcHttpServer\Infra\Resolver;

use Yoanm\JsonRpcServerPsr11Resolver\Domain\Model\ServiceNameResolverInterface;

/**
 * Class ServiceNameResolver
 */
class ServiceNameResolver implements ServiceNameResolverInterface
{
    /** @var string[] */
    private $methodMappingList = [];

    public function resolve(string $methodName) : string
    {
        return array_key_exists($methodName, $this->methodMappingList)

The expression return array_key_exists($methodName, $this->methodMappingList) ? $this->methodMappingList[$methodName] : null could return the type null which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

            ? $this->methodMappingList[$methodName]
            : null
        ;
    }

    public function addMethodMapping(string $methodName, string $serviceId)
    {
        $this->methodMappingList[$methodName] = $serviceId;
    }
}