Yoanm\SymfonyJsonRpcHttpServerDoc\Endpoint\DocumentationEndpoint

Complexity

Total Complexity

3

Size/Duplication

Total Lines	54
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	httpOptions()	0	14	1
A	httpGet()	0	11	1

<?php
namespace Yoanm\SymfonyJsonRpcHttpServerDoc\Endpoint;

use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Yoanm\SymfonyJsonRpcHttpServerDoc\Finder\NormalizedDocFinder;

/**
 * Class DocumentationEndpoint
 */
class DocumentationEndpoint
{
    /** @var NormalizedDocFinder */
    private $normalizedDocFinder;

    /** @var string[] */
    private $allowedMethodList = [];

    /**
     * @param NormalizedDocFinder $normalizedDocFinder
     */
    public function __construct(NormalizedDocFinder $normalizedDocFinder)
    {
        $this->normalizedDocFinder = $normalizedDocFinder;
        $this->allowedMethodList = [Request::METHOD_GET, Request::METHOD_OPTIONS];
    }

    /**
     * @param Request $request
     *
     * @return Response
     */
    public function httpOptions(Request $request) : Response

The parameter $request is not used and could be removed.

    {
        $response = new Response();
        $response->headers->set('Content-Type', 'application/json');

        // Set allowed http methods
        $response->headers->set('Allow', $this->allowedMethodList);
        $response->headers->set('Access-Control-Request-Method', $this->allowedMethodList);

        // Set allowed content type
        $response->headers->set('Accept', 'application/json');
        $response->headers->set('Access-Control-Allow-Headers', 'Content-Type');

        return $response;
    }

    /**
     * @param Request $request
     *
     * @return Response
     */
    public function httpGet(Request $request) : Response
    {
        $filename = $request->get('filename');
        $response = new Response();
        $response->headers->set('Content-Type', 'application/json');

        $doc = $this->normalizedDocFinder->findFor($filename, $request->getHttpHost());

It seems like $filename can also be of type null; however, parameter $filename of Yoanm\SymfonyJsonRpcHttpServerDoc\Finder\NormalizedDocFinder::findFor() does only seem to accept string, maybe add an additional type check?

        $response->setContent(json_encode($doc));

        return $response;
    }
}