ResponseCreator::createResultResponse() - Code Metrics - Inspection of "UT" - yoanm/php-jsonrpc-server-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — release/3.0.0-dev (#32)

by Yo

created 2018-05-19 10:54 UTC

ResponseCreator::createResultResponse() A

↳ Parent: ResponseCreator

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	2
dl	0
loc	4
ccs	3
cts	3
cp	1
crap	1
rs	10
c	0
b	0
f	0

<?php
namespace Yoanm\JsonRpcServer\App\Creator;

use Yoanm\JsonRpcServer\Domain\Exception\JsonRpcExceptionInterface;
use Yoanm\JsonRpcServer\Domain\Exception\JsonRpcInternalErrorException;
use Yoanm\JsonRpcServer\Domain\Model\JsonRpcRequest;
use Yoanm\JsonRpcServer\Domain\Model\JsonRpcResponse;

/**
 * Class ResponseCreator
 */
class ResponseCreator
{
    /**
     * @param JsonRpcRequest|null $fromRequest
     *
     * @return JsonRpcResponse
     */
    public function createEmptyResponse(JsonRpcRequest $fromRequest = null) : JsonRpcResponse
    {
        if (null === $fromRequest) {
            return new JsonRpcResponse();
        }

        $response = (new JsonRpcResponse($fromRequest->getJsonRpc()))
                ->setIsNotification($fromRequest->isNotification())
        ;

        if ($fromRequest->getId()) {
            $response->setId($fromRequest->getId());
        }

        return $response;
    }

    /**
     * @param mixed               $result
     * @param JsonRpcRequest|null $fromRequest
     *
     * @return JsonRpcResponse
     */
    public function createResultResponse($result, JsonRpcRequest $fromRequest = null) : JsonRpcResponse
    {
        return $this->createEmptyResponse($fromRequest)
            ->setResult($result);
    }

    /**
     * @param \Exception          $exception
     * @param JsonRpcRequest|null $fromRequest
     *
     * @return JsonRpcResponse
     */
    public function createErrorResponse(\Exception $exception, JsonRpcRequest $fromRequest = null) : JsonRpcResponse
    {
        return $this->createEmptyResponse($fromRequest)
            ->setError(
                $exception instanceof JsonRpcExceptionInterface
                    ? $exception
                    : new JsonRpcInternalErrorException($exception)
            )
        ;
    }
}


1		<?php
2		namespace Yoanm\JsonRpcServer\App\Creator;
3
4		use Yoanm\JsonRpcServer\Domain\Exception\JsonRpcExceptionInterface;
5		use Yoanm\JsonRpcServer\Domain\Exception\JsonRpcInternalErrorException;
6		use Yoanm\JsonRpcServer\Domain\Model\JsonRpcRequest;
7		use Yoanm\JsonRpcServer\Domain\Model\JsonRpcResponse;
8
9		/**
10		* Class ResponseCreator
11		*/
12		class ResponseCreator
13		{
14		/**
15		* @param JsonRpcRequest\|null $fromRequest
16		*
17		* @return JsonRpcResponse
18		*/
19	7	public function createEmptyResponse(JsonRpcRequest $fromRequest = null) : JsonRpcResponse
20		{
21	7	if (null === $fromRequest) {
22	3	return new JsonRpcResponse();
23		}
24
25	4	$response = (new JsonRpcResponse($fromRequest->getJsonRpc()))
26	4	->setIsNotification($fromRequest->isNotification())
27		;
28
29	4	if ($fromRequest->getId()) {
30	3	$response->setId($fromRequest->getId());
31		}
32
33	4	return $response;
34		}
35
36		/**
37		* @param mixed $result
38		* @param JsonRpcRequest\|null $fromRequest
39		*
40		* @return JsonRpcResponse
41		*/
42	2	public function createResultResponse($result, JsonRpcRequest $fromRequest = null) : JsonRpcResponse
43		{
44	2	return $this->createEmptyResponse($fromRequest)
45	2	->setResult($result);
46		}
47
48		/**
49		* @param \Exception $exception
50		* @param JsonRpcRequest\|null $fromRequest
51		*
52		* @return JsonRpcResponse
53		*/
54	3	public function createErrorResponse(\Exception $exception, JsonRpcRequest $fromRequest = null) : JsonRpcResponse
55		{
56	3	return $this->createEmptyResponse($fromRequest)
57	3	->setError(
58	3	$exception instanceof JsonRpcExceptionInterface
59	2	? $exception
60	3	: new JsonRpcInternalErrorException($exception)
61		)
62		;
63		}
64		}
65

yoanm / php-jsonrpc-server-sdk

Pull Request — release/3.0.0-dev (#32)

ResponseCreator::createResultResponse() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like