ResponseNormalizer::normalizeError() - Code Metrics - Inspection of "Init" - yoanm/php-jsonrpc-server-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#1)

by Yo

created 2018-04-01 08:36 UTC

ResponseNormalizer::normalizeError() A

↳ Parent: ResponseNormalizer

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
cc	2
eloc	6
nc	2
nop	1
dl	0
loc	12
ccs	0
cts	10
cp	0
crap	6
rs	9.4285
c	0
b	0
f	0

<?php
namespace Yoanm\JsonRpcServer\App\Serialization;

use Yoanm\JsonRpcServer\Domain\Exception\JsonRpcExceptionInterface;
use Yoanm\JsonRpcServer\Domain\Model\JsonRpcResponse;

/**
 * Class ResponseNormalizer
 */
class ResponseNormalizer
{
    const KEY_JSON_RPC = 'json-rpc';
    const KEY_ID = 'id';
    const KEY_RESULT = 'result';
    const KEY_ERROR = 'error';

    const SUB_KEY_ERROR_CODE = 'code';
    const SUB_KEY_ERROR_MESSAGE = 'message';
    const SUB_KEY_ERROR_DATA = 'data';

    /**
     * @param JsonRpcResponse $response
     *
     * @return array|null
     */
    public function normalize(JsonRpcResponse $response)
    {
        if ($response->isNotification()) {
            return null;
        }

        $data = [
            self::KEY_JSON_RPC => $response->getJsonRpc(),
            self::KEY_ID => $response->getId()
        ];

        if ($response->getError()) {
            $data[self::KEY_ERROR] = $this->normalizeError(
                $response->getError()
            );
        } else {
            $data[self::KEY_RESULT] = $response->getResult();
        }

        return $data;
    }

    /**
     * @param JsonRpcExceptionInterface $error
     *
     * @return array
     */
    private function normalizeError(JsonRpcExceptionInterface $error)
    {
        $normalizedError = [
            self::SUB_KEY_ERROR_CODE => $error->getErrorCode(),
            self::SUB_KEY_ERROR_MESSAGE => $error->getErrorMessage()
        ];

        if ($error->getErrorData()) {
            $normalizedError[self::SUB_KEY_ERROR_DATA] = $error->getErrorData();
        }

        return $normalizedError;
    }
}


1			<?php
2			namespace Yoanm\JsonRpcServer\App\Serialization;
3
4			use Yoanm\JsonRpcServer\Domain\Exception\JsonRpcExceptionInterface;
5			use Yoanm\JsonRpcServer\Domain\Model\JsonRpcResponse;
6
7			/**
8			* Class ResponseNormalizer
9			*/
10			class ResponseNormalizer
11			{
12			const KEY_JSON_RPC = 'json-rpc';
13			const KEY_ID = 'id';
14			const KEY_RESULT = 'result';
15			const KEY_ERROR = 'error';
16
17			const SUB_KEY_ERROR_CODE = 'code';
18			const SUB_KEY_ERROR_MESSAGE = 'message';
19			const SUB_KEY_ERROR_DATA = 'data';
20
21			/**
22			* @param JsonRpcResponse $response
23			*
24			* @return array\|null
25			*/
26			public function normalize(JsonRpcResponse $response)
27			{
28			if ($response->isNotification()) {
29			return null;
30			}
31
32			$data = [
33			self::KEY_JSON_RPC => $response->getJsonRpc(),
34			self::KEY_ID => $response->getId()
35			];
36
37			if ($response->getError()) {
38			$data[self::KEY_ERROR] = $this->normalizeError(
39			$response->getError()
40			);
41			} else {
42			$data[self::KEY_RESULT] = $response->getResult();
43			}
44
45			return $data;
46			}
47
48			/**
49			* @param JsonRpcExceptionInterface $error
50			*
51			* @return array
52			*/
53			private function normalizeError(JsonRpcExceptionInterface $error)
54			{
55			$normalizedError = [
56			self::SUB_KEY_ERROR_CODE => $error->getErrorCode(),
57			self::SUB_KEY_ERROR_MESSAGE => $error->getErrorMessage()
58			];
59
60			if ($error->getErrorData()) {
61			$normalizedError[self::SUB_KEY_ERROR_DATA] = $error->getErrorData();
62			}
63
64			return $normalizedError;
65			}
66			}
67

yoanm / php-jsonrpc-server-sdk

Pull Request — master (#1)

ResponseNormalizer::normalizeError() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like