Yoanm\JsonRpcServer\App\Manager\MethodManager

Complexity

Total Complexity

6

Size/Duplication

Total Lines	58
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	apply()	0	10	2
A	validateParamsIfNeeded()	0	9	3
A	__construct()	0	4	1

<?php
namespace Yoanm\JsonRpcServer\App\Manager;

use Yoanm\JsonRpcServer\App\Creator\CustomExceptionCreator;
use Yoanm\JsonRpcServer\Domain\Model\JsonRpcMethodInterface;
use Yoanm\JsonRpcServer\Domain\Model\MethodResolverInterface;
use Yoanm\JsonRpcServer\Domain\Exception\JsonRpcExceptionInterface;
use Yoanm\JsonRpcServer\Domain\Exception\JsonRpcInvalidParamsException;
use Yoanm\JsonRpcServer\Domain\Exception\JsonRpcMethodNotFoundException;

/**
 * Class MethodManager
 */
class MethodManager
{
    /** @var MethodResolverInterface */
    private $methodResolver;
    /** @var CustomExceptionCreator */
    private $customExceptionCreator;

    /**
     * @param MethodResolverInterface $methodResolver
     * @param CustomExceptionCreator  $customExceptionCreator
     */
    public function __construct(MethodResolverInterface $methodResolver, CustomExceptionCreator $customExceptionCreator)
    {
        $this->methodResolver = $methodResolver;
        $this->customExceptionCreator = $customExceptionCreator;
    }

    /**
     * @param string $methodName
     * @param array  $paramList
     *
     * @return mixed
     *
     * @throws JsonRpcInvalidParamsException
     * @throws JsonRpcMethodNotFoundException
     * @throws JsonRpcExceptionInterface
     */
    public function apply(string $methodName, array $paramList = null)
    {
        $method = $this->methodResolver->resolve($methodName);

        $this->validateParamsIfNeeded($method, $methodName, $paramList);

It seems like $paramList can also be of type null; however, parameter $paramList of Yoanm\JsonRpcServer\App\Manager\MethodManager::validateParamsIfNeeded() does only seem to accept array, maybe add an additional type check?

        try {
            return $method->apply($paramList);
        } catch (\Exception $applyException) {
            throw $this->customExceptionCreator->createFor($applyException);
        }
    }

    /**
     * @param JsonRpcMethodInterface $method
     * @param string                 $methodName
     * @param array                  $paramList
     *
     * @throws JsonRpcInvalidParamsException
     *
     * @return void
     */
    private function validateParamsIfNeeded(JsonRpcMethodInterface $method, string $methodName, array $paramList)
    {
        if (is_array($paramList)) {

The condition is_array($paramList) is always true.

            try {
                $method->validateParams($paramList);
            } catch (\Exception $validationException) {
                throw new JsonRpcInvalidParamsException(
                    $methodName,
                    $validationException->getMessage()
                );
            }
        }
    }
}