ContainerMethodResolver::resolve() - Code Metrics - Inspection of "Improve service name resolver" - yoanm/php-jsonrpc-server-sdk-psr11-resolver - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — feature/symfony-config (#2)

by Yo

created 2018-04-04 09:18 UTC

ContainerMethodResolver::resolve() A

↳ Parent: ContainerMethodResolver

Complexity

Conditions	3
Paths	4

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	3

Importance

Changes

Metric	Value
cc	3
eloc	6
nc	4
nop	1
dl	0
loc	11
ccs	7
cts	7
cp	1
crap	3
rs	9.4285
c	0
b	0
f	0

<?php
namespace Yoanm\JsonRpcServerPsr11Resolver\Infra\Resolver;

use Psr\Container\ContainerInterface;
use Yoanm\JsonRpcServer\Domain\Exception\JsonRpcMethodNotFoundException;
use Yoanm\JsonRpcServer\Domain\Model\JsonRpcMethodInterface;
use Yoanm\JsonRpcServer\Domain\Model\MethodResolverInterface;
use Yoanm\JsonRpcServerPsr11Resolver\Domain\Model\ServiceNameResolverInterface;

/**
 * Class ContainerMethodResolver
 */
class ContainerMethodResolver implements MethodResolverInterface
{
    /** @var ContainerInterface */
    private $container;
    /** @var ServiceNameResolverInterface|null */
    private $serviceNameResolver = null;

    /**
     * @param ContainerInterface $container
     */
    public function __construct(ContainerInterface $container)
    {
        $this->container = $container;
    }

    /**
     * {@inheritdoc}
     */
    public function resolve(string $methodName) : JsonRpcMethodInterface
    {
        $serviceName = null !== $this->serviceNameResolver
            ? $this->serviceNameResolver->resolve($methodName)
            : $methodName
        ;
        if (!$this->container->has($serviceName)) {
            throw new JsonRpcMethodNotFoundException($methodName);
        }

        return $this->container->get($serviceName);
    }

    /**
     * @param ServiceNameResolverInterface $serviceNameResolver
     *
     * @return ContainerMethodResolver
     */
    public function setServiceNameResolver(ServiceNameResolverInterface $serviceNameResolver) : ContainerMethodResolver
    {
        $this->serviceNameResolver = $serviceNameResolver;

        return $this;
    }
}


1		<?php
2		namespace Yoanm\JsonRpcServerPsr11Resolver\Infra\Resolver;
3
4		use Psr\Container\ContainerInterface;
5		use Yoanm\JsonRpcServer\Domain\Exception\JsonRpcMethodNotFoundException;
6		use Yoanm\JsonRpcServer\Domain\Model\JsonRpcMethodInterface;
7		use Yoanm\JsonRpcServer\Domain\Model\MethodResolverInterface;
8		use Yoanm\JsonRpcServerPsr11Resolver\Domain\Model\ServiceNameResolverInterface;
9
10		/**
11		* Class ContainerMethodResolver
12		*/
13		class ContainerMethodResolver implements MethodResolverInterface
14		{
15		/** @var ContainerInterface */
16		private $container;
17		/** @var ServiceNameResolverInterface\|null */
18		private $serviceNameResolver = null;
19
20		/**
21		* @param ContainerInterface $container
22		*/
23	4	public function __construct(ContainerInterface $container)
24		{
25	4	$this->container = $container;
26	4	}
27
28		/**
29		* {@inheritdoc}
30		*/
31	4	public function resolve(string $methodName) : JsonRpcMethodInterface
32		{
33	4	$serviceName = null !== $this->serviceNameResolver
34	2	? $this->serviceNameResolver->resolve($methodName)
35	4	: $methodName
36		;
37	4	if (!$this->container->has($serviceName)) {
38	2	throw new JsonRpcMethodNotFoundException($methodName);
39		}
40
41	2	return $this->container->get($serviceName);
42		}
43
44		/**
45		* @param ServiceNameResolverInterface $serviceNameResolver
46		*
47		* @return ContainerMethodResolver
48		*/
49	2	public function setServiceNameResolver(ServiceNameResolverInterface $serviceNameResolver) : ContainerMethodResolver
50		{
51	2	$this->serviceNameResolver = $serviceNameResolver;
52
53	2	return $this;
54		}
55		}
56

yoanm / php-jsonrpc-server-sdk-psr11-resolver

Pull Request — feature/symfony-config (#2)

ContainerMethodResolver::resolve() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like