Yoanm\JsonRpcServerDoc\Model\Type\StringDoc

Complexity

Total Complexity

8

Size/Duplication

Total Lines	74
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	setBlankAllowed()	0	3	1
A	getMaxLength()	0	3	1
A	setMinLength()	0	3	1
A	setFormat()	0	3	1
A	getMinLength()	0	3	1
A	setMaxLength()	0	3	1
A	getFormat()	0	3	1
A	isBlankAllowed()	0	3	1

<?php
namespace Yoanm\JsonRpcServerDoc\Model\Type;

/**
 * Class StringDoc
 */
class StringDoc extends ScalarDoc
{
    /*** Validation ***/
    /** @var null|bool */
    private $blankAllowed = null;
    /** @var null|string */
    private $format = null;
    /** @var null|int|float */
    private $minLength = null;
    /** @var null|int|float */
    private $maxLength = null;

    /**
     * @param bool|null $blankAllowed
     */
    public function setBlankAllowed($blankAllowed)
    {
        $this->blankAllowed = $blankAllowed;
    }

    /**
     * @param null|string $format
     */
    public function setFormat($format)
    {
        $this->format = $format;
    }

    /**
     * @param null $minLength

Are you sure the doc-type for parameter $minLength is correct as it would always require null to be passed?

     */
    public function setMinLength($minLength)
    {
        $this->minLength = $minLength;
    }

    /**
     * @param null|bool $maxLength
     */
    public function setMaxLength($maxLength)
    {
        $this->maxLength = $maxLength;

It seems like $maxLength can also be of type boolean. However, the property $maxLength is declared as type null|integer|double. Maybe add an additional type check?

    }

    /**
     * @return bool|null
     */
    public function isBlankAllowed()
    {
        return $this->blankAllowed;
    }

    /**
     * @return null|string
     */
    public function getFormat()
    {
        return $this->format;
    }

    /**
     * @return null|bool
     */
    public function getMinLength()
    {
        return $this->minLength;

The expression return $this->minLength also could return the type integer|double which is incompatible with the documented return type null|boolean.

    }

    /**
     * @return null|bool
     */
    public function getMaxLength()
    {
        return $this->maxLength;

The expression return $this->maxLength also could return the type integer|double which is incompatible with the documented return type null|boolean.

    }
}