ConfigurationUpdater::updateScriptList() - Code Metrics - Inspection of "Feature/update command" - yoanm/composerConfigManager - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#10)

by Yo

created 2017-04-28 20:31 UTC

ConfigurationUpdater::updateScriptList() C

↳ Parent: ConfigurationUpdater

Complexity

Conditions	7
Paths	15

Size

Total Lines	37
Code Lines	24

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	37
rs	6.7272
c	0
b	0
f	0
cc	7
eloc	24
nc	15
nop	2

<?php
namespace Yoanm\ComposerConfigManager\Application\Updater;

use Yoanm\ComposerConfigManager\Domain\Model\Author;
use Yoanm\ComposerConfigManager\Domain\Model\Autoload;
use Yoanm\ComposerConfigManager\Domain\Model\Configuration;
use Yoanm\ComposerConfigManager\Domain\Model\Package;
use Yoanm\ComposerConfigManager\Domain\Model\Script;
use Yoanm\ComposerConfigManager\Domain\Model\SuggestedPackage;
use Yoanm\ComposerConfigManager\Domain\Model\Support;

class ConfigurationUpdater
{
    /**
     * @param Configuration $baseConfiguration
     * @param Configuration $newConfiguration
     *
     * @return Configuration
     */
    public function update(Configuration $baseConfiguration, Configuration $newConfiguration)
    {
        return new Configuration(
            $this->updateIfDefined($newConfiguration->getPackageName(), $baseConfiguration->getPackageName()),
            $this->updateIfDefined($newConfiguration->getType(), $baseConfiguration->getType()),
            $this->updateIfDefined($newConfiguration->getLicense(), $baseConfiguration->getLicense()),
            $this->updateIfDefined($newConfiguration->getPackageVersion(), $baseConfiguration->getPackageVersion()),
            $this->updateIfDefined($newConfiguration->getDescription(), $baseConfiguration->getDescription()),
            $this->mergeValueList($newConfiguration->getKeywordList(), $baseConfiguration->getKeywordList()),
            $this->updateList($newConfiguration->getAuthorList(), $baseConfiguration->getAuthorList()),
            $this->updateList(
                $newConfiguration->getProvidedPackageList(),
                $baseConfiguration->getProvidedPackageList()
            ),
            $this->updateList(
                $newConfiguration->getSuggestedPackageList(),
                $baseConfiguration->getSuggestedPackageList()
            ),
            $this->updateList($newConfiguration->getSupportList(), $baseConfiguration->getSupportList()),
            $this->updateList($newConfiguration->getAutoloadList(), $baseConfiguration->getAutoloadList()),
            $this->updateList($newConfiguration->getAutoloadDevList(), $baseConfiguration->getAutoloadDevList()),
            $this->updateList(
                $newConfiguration->getRequiredPackageList(),
                $baseConfiguration->getRequiredPackageList()
            ),
            $this->updateList(
                $newConfiguration->getRequiredDevPackageList(),
                $baseConfiguration->getRequiredDevPackageList()
            ),
            $this->updateScriptList($newConfiguration->getScriptList(), $baseConfiguration->getScriptList())
        );
    }

    /**
     * @param object $entity
     *
     * @return null|string
     */
    public function getEntityId($entity)
    {
        switch (true) {
            case $entity instanceof Author:
                $id = $entity->getName();
                break;
            case $entity instanceof SuggestedPackage:
                $id = $entity->getName();
                break;
            case $entity instanceof Support:
                $id = $entity->getType();
                break;
            case $entity instanceof Autoload:
                $id = $entity->getType().'#'.$entity->getNamespace();
                break;
            case $entity instanceof Package:
                $id = $entity->getName();
                break;
            case $entity instanceof Script:
                $id = $entity->getName();
                break;
            default:
                $id = null;
        };

        return $id;
    }

    /**
     * @param mixed $baseValue
     * @param mixed $newValue
     *
     * @return mixed
     */
    protected function updateIfDefined($newValue, $baseValue)
    {
        return $newValue ? $newValue : $baseValue;
    }

    /**
     * @param array $newList
     * @param array $oldList
     *
     * @return array
     */
    protected function mergeValueList(array $oldList, array $newList)
    {
        return array_values(
            array_unique(
                array_merge($newList, $oldList)
            )
        );
    }

    /**
     * @param array $newEntityList
     * @param array $oldEntityList
     *
     * @return array
     */
    protected function updateList(array $newEntityList, array $oldEntityList)
    {
        $listTmp = [];
        $self = $this;
        foreach ($newEntityList as $newEntity) {
            // Search for an old entry
            $newEntityId = $this->getEntityId($newEntity);
            $oldEntityMatches = array_filter(
                $oldEntityList,
                function ($oldEntity) use ($newEntityId, $self) {
                    return $self->getEntityId($oldEntity) == $newEntityId;
                }
            );
            if (count($oldEntityMatches)) {
                $oldEntity = array_shift($oldEntityMatches);
                $newEntity = $this->mergeEntity($oldEntity, $newEntity);
                $oldEntityList = array_map(
                    function ($oldEntity) use ($newEntityId, $newEntity, $self) {
                        return $self->getEntityId($oldEntity) == $newEntityId
                            ? $newEntity
                            : $oldEntity
                        ;
                    },
                    $oldEntityList
                );
            } else {
                $listTmp[] = $newEntity;
            }
        }

        // Merge remaining entities that have not been already merged
        $list = [];
        foreach (array_reverse($oldEntityList, true) as $entity) {
            array_unshift($list, $entity);
        }

        return array_merge($list, $listTmp);
    }

    /**
     * @param array $newEntityList
     * @param array $oldEntityList
     *
     * @return array
     */
    protected function updateScriptList(array $newEntityList, array $oldEntityList)
    {
        $mergedEntityIdList = [];
        $self = $this;
        $normalizedNewEntityList = [];
        foreach ($newEntityList as $newEntity) {
            // Search for an old entry
            $newEntityId = $this->getEntityId($newEntity);
            $oldEntityMatches = array_filter(
                $oldEntityList,
                function ($oldEntity) use ($newEntityId, $self) {
                    return $self->getEntityId($oldEntity) == $newEntityId;
                }
            );
            if (count($oldEntityMatches)) {
                $mergedEntityIdList[$newEntityId] = true;
            }
            $normalizedNewEntityList[] = $newEntity;
        }
        // Merge remaining entities that have not been already merged
        $normalizedOldEntityList = [];
        foreach ($oldEntityList as $oldEntity) {
            if (!array_key_exists($this->getEntityId($oldEntity), $mergedEntityIdList)) {
                $normalizedOldEntityList[] = $oldEntity;
            } else {
                $oldEntityId = $this->getEntityId($oldEntity);
                foreach ($normalizedNewEntityList as $newEntityKey => $newEntity) {
                    if ($self->getEntityId($newEntity) == $oldEntityId) {
                        $normalizedOldEntityList[] = $newEntity;
                        unset($normalizedNewEntityList[$newEntityKey]);
                    }
                }
            }
        }

        return array_merge($normalizedOldEntityList, $normalizedNewEntityList);
    }

    protected function mergeEntity($oldEntity, $newEntity)
    {
        switch (true) {
            case $newEntity instanceof Author && $oldEntity instanceof Author:
                return new Author(
                    $newEntity->getName(),
                    $newEntity->getEmail() ? $newEntity->getEmail() : $oldEntity->getEmail(),
                    $newEntity->getRole() ? $newEntity->getRole() : $oldEntity->getRole()
                );
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        }

        return $newEntity;
    }
}


1			<?php
2			namespace Yoanm\ComposerConfigManager\Application\Updater;
3
4			use Yoanm\ComposerConfigManager\Domain\Model\Author;
5			use Yoanm\ComposerConfigManager\Domain\Model\Autoload;
6			use Yoanm\ComposerConfigManager\Domain\Model\Configuration;
7			use Yoanm\ComposerConfigManager\Domain\Model\Package;
8			use Yoanm\ComposerConfigManager\Domain\Model\Script;
9			use Yoanm\ComposerConfigManager\Domain\Model\SuggestedPackage;
10			use Yoanm\ComposerConfigManager\Domain\Model\Support;
11
12			class ConfigurationUpdater
13			{
14			/**
15			* @param Configuration $baseConfiguration
16			* @param Configuration $newConfiguration
17			*
18			* @return Configuration
19			*/
20			public function update(Configuration $baseConfiguration, Configuration $newConfiguration)
21			{
22			return new Configuration(
23			$this->updateIfDefined($newConfiguration->getPackageName(), $baseConfiguration->getPackageName()),
24			$this->updateIfDefined($newConfiguration->getType(), $baseConfiguration->getType()),
25			$this->updateIfDefined($newConfiguration->getLicense(), $baseConfiguration->getLicense()),
26			$this->updateIfDefined($newConfiguration->getPackageVersion(), $baseConfiguration->getPackageVersion()),
27			$this->updateIfDefined($newConfiguration->getDescription(), $baseConfiguration->getDescription()),
28			$this->mergeValueList($newConfiguration->getKeywordList(), $baseConfiguration->getKeywordList()),
29			$this->updateList($newConfiguration->getAuthorList(), $baseConfiguration->getAuthorList()),
30			$this->updateList(
31			$newConfiguration->getProvidedPackageList(),
32			$baseConfiguration->getProvidedPackageList()
33			),
34			$this->updateList(
35			$newConfiguration->getSuggestedPackageList(),
36			$baseConfiguration->getSuggestedPackageList()
37			),
38			$this->updateList($newConfiguration->getSupportList(), $baseConfiguration->getSupportList()),
39			$this->updateList($newConfiguration->getAutoloadList(), $baseConfiguration->getAutoloadList()),
40			$this->updateList($newConfiguration->getAutoloadDevList(), $baseConfiguration->getAutoloadDevList()),
41			$this->updateList(
42			$newConfiguration->getRequiredPackageList(),
43			$baseConfiguration->getRequiredPackageList()
44			),
45			$this->updateList(
46			$newConfiguration->getRequiredDevPackageList(),
47			$baseConfiguration->getRequiredDevPackageList()
48			),
49			$this->updateScriptList($newConfiguration->getScriptList(), $baseConfiguration->getScriptList())
50			);
51			}
52
53			/**
54			* @param object $entity
55			*
56			* @return null\|string
57			*/
58			public function getEntityId($entity)
59			{
60			switch (true) {
61			case $entity instanceof Author:
62			$id = $entity->getName();
63			break;
64			case $entity instanceof SuggestedPackage:
65			$id = $entity->getName();
66			break;
67			case $entity instanceof Support:
68			$id = $entity->getType();
69			break;
70			case $entity instanceof Autoload:
71			$id = $entity->getType().'#'.$entity->getNamespace();
72			break;
73			case $entity instanceof Package:
74			$id = $entity->getName();
75			break;
76			case $entity instanceof Script:
77			$id = $entity->getName();
78			break;
79			default:
80			$id = null;
81			};
82
83			return $id;
84			}
85
86			/**
87			* @param mixed $baseValue
88			* @param mixed $newValue
89			*
90			* @return mixed
91			*/
92			protected function updateIfDefined($newValue, $baseValue)
93			{
94			return $newValue ? $newValue : $baseValue;
95			}
96
97			/**
98			* @param array $newList
99			* @param array $oldList
100			*
101			* @return array
102			*/
103			protected function mergeValueList(array $oldList, array $newList)
104			{
105			return array_values(
106			array_unique(
107			array_merge($newList, $oldList)
108			)
109			);
110			}
111
112			/**
113			* @param array $newEntityList
114			* @param array $oldEntityList
115			*
116			* @return array
117			*/
118			protected function updateList(array $newEntityList, array $oldEntityList)
119			{
120			$listTmp = [];
121			$self = $this;
122			foreach ($newEntityList as $newEntity) {
123			// Search for an old entry
124			$newEntityId = $this->getEntityId($newEntity);
125			$oldEntityMatches = array_filter(
126			$oldEntityList,
127			function ($oldEntity) use ($newEntityId, $self) {
128			return $self->getEntityId($oldEntity) == $newEntityId;
129			}
130			);
131			if (count($oldEntityMatches)) {
132			$oldEntity = array_shift($oldEntityMatches);
133			$newEntity = $this->mergeEntity($oldEntity, $newEntity);
134			$oldEntityList = array_map(
135			function ($oldEntity) use ($newEntityId, $newEntity, $self) {
136			return $self->getEntityId($oldEntity) == $newEntityId
137			? $newEntity
138			: $oldEntity
139			;
140			},
141			$oldEntityList
142			);
143			} else {
144			$listTmp[] = $newEntity;
145			}
146			}
147
148			// Merge remaining entities that have not been already merged
149			$list = [];
150			foreach (array_reverse($oldEntityList, true) as $entity) {
151			array_unshift($list, $entity);
152			}
153
154			return array_merge($list, $listTmp);
155			}
156
157			/**
158			* @param array $newEntityList
159			* @param array $oldEntityList
160			*
161			* @return array
162			*/
163			protected function updateScriptList(array $newEntityList, array $oldEntityList)
164			{
165			$mergedEntityIdList = [];
166			$self = $this;
167			$normalizedNewEntityList = [];
168			foreach ($newEntityList as $newEntity) {
169			// Search for an old entry
170			$newEntityId = $this->getEntityId($newEntity);
171			$oldEntityMatches = array_filter(
172			$oldEntityList,
173			function ($oldEntity) use ($newEntityId, $self) {
174			return $self->getEntityId($oldEntity) == $newEntityId;
175			}
176			);
177			if (count($oldEntityMatches)) {
178			$mergedEntityIdList[$newEntityId] = true;
179			}
180			$normalizedNewEntityList[] = $newEntity;
181			}
182			// Merge remaining entities that have not been already merged
183			$normalizedOldEntityList = [];
184			foreach ($oldEntityList as $oldEntity) {
185			if (!array_key_exists($this->getEntityId($oldEntity), $mergedEntityIdList)) {
186			$normalizedOldEntityList[] = $oldEntity;
187			} else {
188			$oldEntityId = $this->getEntityId($oldEntity);
189			foreach ($normalizedNewEntityList as $newEntityKey => $newEntity) {
190			if ($self->getEntityId($newEntity) == $oldEntityId) {
191			$normalizedOldEntityList[] = $newEntity;
192			unset($normalizedNewEntityList[$newEntityKey]);
193			}
194			}
195			}
196			}
197
198			return array_merge($normalizedOldEntityList, $normalizedNewEntityList);
199			}
200
201			protected function mergeEntity($oldEntity, $newEntity)
202			{
203			switch (true) {
204			case $newEntity instanceof Author && $oldEntity instanceof Author:
205			return new Author(
206			$newEntity->getName(),
207			$newEntity->getEmail() ? $newEntity->getEmail() : $oldEntity->getEmail(),
208			$newEntity->getRole() ? $newEntity->getRole() : $oldEntity->getRole()
209			);
210			break;
			0 ignored issues – show Unused Code introduced 2017-04-28 20:30 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
211			}
212
213			return $newEntity;
214			}
215			}
216

yoanm / composerConfigManager

Pull Request — master (#10)

ConfigurationUpdater::updateScriptList() C

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like