UpdateConfigurationFileCommand::configure() - Code Metrics - Inspection of "Key ordering" - yoanm/composerConfigManager - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#17)

by Yo

created 2017-05-01 18:58 UTC

UpdateConfigurationFileCommand::configure() B

↳ Parent: UpdateConfigurationFileCommand

Complexity

Conditions	1
Paths	1

Size

Total Lines	124
Code Lines	98

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	124
c	0
b	0
f	0
rs	8.2857
cc	1
eloc	98
nc	1
nop	0

How to fix Long Method

<?php
namespace Yoanm\ComposerConfigManager\Infrastructure\Command;

use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;
use Yoanm\ComposerConfigManager\Application\Loader\ConfigurationFileLoaderInterface;
use Yoanm\ComposerConfigManager\Application\UpdateConfigurationFile;
use Yoanm\ComposerConfigManager\Application\UpdateConfigurationFileListRequest;
use Yoanm\ComposerConfigManager\Infrastructure\Command\Transformer\InputTransformer;

class UpdateConfigurationFileCommand extends AbstractTemplatableCommand
{
    const NAME = 'update';
    const ARGUMENT_CONFIGURATION_DEST_FOLDER = 'path';

    /** @var InputTransformer */
    private $inputTransformer;
    /** @var UpdateConfigurationFile */
    private $updateConfiguration;

    public function __construct(
        InputTransformer $inputTransformer,
        UpdateConfigurationFile $updateConfiguration,
        ConfigurationFileLoaderInterface $configurationLoader
    ) {
        parent::__construct($configurationLoader);

        $this->inputTransformer = $inputTransformer;
        $this->updateConfiguration = $updateConfiguration;
    }
    /**
     * {@inheritdoc}
     */
    protected function configure()
    {
        $this
            ->setName(self::NAME)
            ->setDescription('Will update a composer configuration file.')
// @codingStandardsIgnoreStart
            ->setHelp(<<<DESC
 - <info>keywords</info> will be appended to existing ones
 - <info>other plain values</info> (package name, version, ...) will replace old ones if they are already present, else they will be added
 - <info>nested values</info> (authors, autoload, script, ...) will replace old ones if they are already present, else they will be appended
DESC
            )
// @codingStandardsIgnoreEnd
            ->addArgument(
                self::ARGUMENT_CONFIGURATION_DEST_FOLDER,
                InputArgument::OPTIONAL,
                'Existing onfiguration file path',
                '.'
            )
            ->addOption(
                InputTransformer::KEY_PACKAGE_NAME,
                null,
                InputOption::VALUE_REQUIRED,
                'Name for the composer package'
            )
            ->addOption(
                InputTransformer::KEY_TYPE,
                null,
                InputOption::VALUE_REQUIRED,
                'Package type. Ex : "library" / "project"'
            )
            ->addOption(
                InputTransformer::KEY_LICENSE,
                null,
                InputOption::VALUE_REQUIRED,
                'Package license type'
            )
            ->addOption(
                InputTransformer::KEY_PACKAGE_VERSION,
                null,
                InputOption::VALUE_REQUIRED,
                'Package version number. Ex : "X.Y.Z"'
            )
            ->addOption(
                InputTransformer::KEY_DESCRIPTION,
                null,
                InputOption::VALUE_REQUIRED,
                'Package description'
            )
            ->addOption(
                InputTransformer::KEY_KEYWORD,
                null,
                InputOption::VALUE_REQUIRED | InputOption::VALUE_IS_ARRAY,
                'Package keywords'
            )
            ->addOption(
                InputTransformer::KEY_AUTHOR,
                null,
                InputOption::VALUE_REQUIRED | InputOption::VALUE_IS_ARRAY,
                'Package authors. Format "name[#email[#role]]'
            )
            ->addOption(
                InputTransformer::KEY_PROVIDED_PACKAGE,
                null,
                InputOption::VALUE_REQUIRED | InputOption::VALUE_IS_ARRAY,
                'List of packages provided by this one. Ex : "package-name#version"'
            )
            ->addOption(
                InputTransformer::KEY_SUGGESTED_PACKAGE,
                null,
                InputOption::VALUE_REQUIRED | InputOption::VALUE_IS_ARRAY,
                'List of packages suggested by this one. Ex : "package-name#description"'
            )
            ->addOption(
                InputTransformer::KEY_SUPPORT,
                null,
                InputOption::VALUE_REQUIRED | InputOption::VALUE_IS_ARRAY,
                'List of package support urls. Ex : "type#url"'
            )
            ->addOption(
                InputTransformer::KEY_AUTOLOAD_PSR0,
                null,
                InputOption::VALUE_REQUIRED | InputOption::VALUE_IS_ARRAY,
                'List of package PSR-0 autoload. Ex : "namespace#path"'
            )
            ->addOption(
                InputTransformer::KEY_AUTOLOAD_PSR4,
                null,
                InputOption::VALUE_REQUIRED | InputOption::VALUE_IS_ARRAY,
                'List of package PSR-4 autoload. Ex : "namespace#path"'
            )
            ->addOption(
                InputTransformer::KEY_AUTOLOAD_DEV_PSR0,
                null,
                InputOption::VALUE_REQUIRED | InputOption::VALUE_IS_ARRAY,
                'List of packages PSR-0 dev autoload. Ex : "namespace#path"'
            )
            ->addOption(
                InputTransformer::KEY_AUTOLOAD_DEV_PSR4,
                null,
                InputOption::VALUE_REQUIRED | InputOption::VALUE_IS_ARRAY,
                'List of package PSR-4 dev autoload. Ex : "namespace#path"'
            )
            ->addOption(
                InputTransformer::KEY_REQUIRE,
                null,
                InputOption::VALUE_REQUIRED | InputOption::VALUE_IS_ARRAY,
                'List of required packages. Ex "vendor/package-name#~x.y"'
            )
            ->addOption(
                InputTransformer::KEY_REQUIRE_DEV,
                null,
                InputOption::VALUE_REQUIRED | InputOption::VALUE_IS_ARRAY,
                'List of required dev packages. Ex "vendor/package-name#~x.y"'
            )
            ->addOption(
                InputTransformer::KEY_SCRIPT,
                null,
                InputOption::VALUE_REQUIRED | InputOption::VALUE_IS_ARRAY,
                'List of scripts for the package. Ex : "script-name#command"'
            )
        ;
        parent::configure();
    }

    /**
     * {@inheritdoc}
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $path = $input->getArgument(self::ARGUMENT_CONFIGURATION_DEST_FOLDER);
        $configurationFileList = [];
        $templateConfigurationFile = $this->loadTemplateConfigurationFile($input);
        if ($templateConfigurationFile) {
            $configurationFileList[] = $templateConfigurationFile;
        }

        $configurationFileList[] = $this->getConfigurationFileLoader()->fromPath($path);

        if ($newConfigurationFile = $this->inputTransformer->fromCommandLine($input->getOptions())) {
            $configurationFileList[] = $newConfigurationFile;
        }
        $this->updateConfiguration->run(
            new UpdateConfigurationFileListRequest(
                $configurationFileList,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                $path
            )
        );
    }
}


1			<?php
2			namespace Yoanm\ComposerConfigManager\Infrastructure\Command;
3
4			use Symfony\Component\Console\Input\InputArgument;
5			use Symfony\Component\Console\Input\InputInterface;
6			use Symfony\Component\Console\Input\InputOption;
7			use Symfony\Component\Console\Output\OutputInterface;
8			use Yoanm\ComposerConfigManager\Application\Loader\ConfigurationFileLoaderInterface;
9			use Yoanm\ComposerConfigManager\Application\UpdateConfigurationFile;
10			use Yoanm\ComposerConfigManager\Application\UpdateConfigurationFileListRequest;
11			use Yoanm\ComposerConfigManager\Infrastructure\Command\Transformer\InputTransformer;
12
13			class UpdateConfigurationFileCommand extends AbstractTemplatableCommand
14			{
15			const NAME = 'update';
16			const ARGUMENT_CONFIGURATION_DEST_FOLDER = 'path';
17
18			/** @var InputTransformer */
19			private $inputTransformer;
20			/** @var UpdateConfigurationFile */
21			private $updateConfiguration;
22
23			public function __construct(
24			InputTransformer $inputTransformer,
25			UpdateConfigurationFile $updateConfiguration,
26			ConfigurationFileLoaderInterface $configurationLoader
27			) {
28			parent::__construct($configurationLoader);
29
30			$this->inputTransformer = $inputTransformer;
31			$this->updateConfiguration = $updateConfiguration;
32			}
33			/**
34			* {@inheritdoc}
35			*/
36			protected function configure()
37			{
38			$this
39			->setName(self::NAME)
40			->setDescription('Will update a composer configuration file.')
41			// @codingStandardsIgnoreStart
42			->setHelp(<<<DESC
43			- <info>keywords</info> will be appended to existing ones
44			- <info>other plain values</info> (package name, version, ...) will replace old ones if they are already present, else they will be added
45			- <info>nested values</info> (authors, autoload, script, ...) will replace old ones if they are already present, else they will be appended
46			DESC
47			)
48			// @codingStandardsIgnoreEnd
49			->addArgument(
50			self::ARGUMENT_CONFIGURATION_DEST_FOLDER,
51			InputArgument::OPTIONAL,
52			'Existing onfiguration file path',
53			'.'
54			)
55			->addOption(
56			InputTransformer::KEY_PACKAGE_NAME,
57			null,
58			InputOption::VALUE_REQUIRED,
59			'Name for the composer package'
60			)
61			->addOption(
62			InputTransformer::KEY_TYPE,
63			null,
64			InputOption::VALUE_REQUIRED,
65			'Package type. Ex : "library" / "project"'
66			)
67			->addOption(
68			InputTransformer::KEY_LICENSE,
69			null,
70			InputOption::VALUE_REQUIRED,
71			'Package license type'
72			)
73			->addOption(
74			InputTransformer::KEY_PACKAGE_VERSION,
75			null,
76			InputOption::VALUE_REQUIRED,
77			'Package version number. Ex : "X.Y.Z"'
78			)
79			->addOption(
80			InputTransformer::KEY_DESCRIPTION,
81			null,
82			InputOption::VALUE_REQUIRED,
83			'Package description'
84			)
85			->addOption(
86			InputTransformer::KEY_KEYWORD,
87			null,
88			InputOption::VALUE_REQUIRED \| InputOption::VALUE_IS_ARRAY,
89			'Package keywords'
90			)
91			->addOption(
92			InputTransformer::KEY_AUTHOR,
93			null,
94			InputOption::VALUE_REQUIRED \| InputOption::VALUE_IS_ARRAY,
95			'Package authors. Format "name[#email[#role]]'
96			)
97			->addOption(
98			InputTransformer::KEY_PROVIDED_PACKAGE,
99			null,
100			InputOption::VALUE_REQUIRED \| InputOption::VALUE_IS_ARRAY,
101			'List of packages provided by this one. Ex : "package-name#version"'
102			)
103			->addOption(
104			InputTransformer::KEY_SUGGESTED_PACKAGE,
105			null,
106			InputOption::VALUE_REQUIRED \| InputOption::VALUE_IS_ARRAY,
107			'List of packages suggested by this one. Ex : "package-name#description"'
108			)
109			->addOption(
110			InputTransformer::KEY_SUPPORT,
111			null,
112			InputOption::VALUE_REQUIRED \| InputOption::VALUE_IS_ARRAY,
113			'List of package support urls. Ex : "type#url"'
114			)
115			->addOption(
116			InputTransformer::KEY_AUTOLOAD_PSR0,
117			null,
118			InputOption::VALUE_REQUIRED \| InputOption::VALUE_IS_ARRAY,
119			'List of package PSR-0 autoload. Ex : "namespace#path"'
120			)
121			->addOption(
122			InputTransformer::KEY_AUTOLOAD_PSR4,
123			null,
124			InputOption::VALUE_REQUIRED \| InputOption::VALUE_IS_ARRAY,
125			'List of package PSR-4 autoload. Ex : "namespace#path"'
126			)
127			->addOption(
128			InputTransformer::KEY_AUTOLOAD_DEV_PSR0,
129			null,
130			InputOption::VALUE_REQUIRED \| InputOption::VALUE_IS_ARRAY,
131			'List of packages PSR-0 dev autoload. Ex : "namespace#path"'
132			)
133			->addOption(
134			InputTransformer::KEY_AUTOLOAD_DEV_PSR4,
135			null,
136			InputOption::VALUE_REQUIRED \| InputOption::VALUE_IS_ARRAY,
137			'List of package PSR-4 dev autoload. Ex : "namespace#path"'
138			)
139			->addOption(
140			InputTransformer::KEY_REQUIRE,
141			null,
142			InputOption::VALUE_REQUIRED \| InputOption::VALUE_IS_ARRAY,
143			'List of required packages. Ex "vendor/package-name#~x.y"'
144			)
145			->addOption(
146			InputTransformer::KEY_REQUIRE_DEV,
147			null,
148			InputOption::VALUE_REQUIRED \| InputOption::VALUE_IS_ARRAY,
149			'List of required dev packages. Ex "vendor/package-name#~x.y"'
150			)
151			->addOption(
152			InputTransformer::KEY_SCRIPT,
153			null,
154			InputOption::VALUE_REQUIRED \| InputOption::VALUE_IS_ARRAY,
155			'List of scripts for the package. Ex : "script-name#command"'
156			)
157			;
158			parent::configure();
159			}
160
161			/**
162			* {@inheritdoc}
163			*/
164			protected function execute(InputInterface $input, OutputInterface $output)
165			{
166			$path = $input->getArgument(self::ARGUMENT_CONFIGURATION_DEST_FOLDER);
167			$configurationFileList = [];
168			$templateConfigurationFile = $this->loadTemplateConfigurationFile($input);
169			if ($templateConfigurationFile) {
170			$configurationFileList[] = $templateConfigurationFile;
171			}
172
173			$configurationFileList[] = $this->getConfigurationFileLoader()->fromPath($path);
174
175			if ($newConfigurationFile = $this->inputTransformer->fromCommandLine($input->getOptions())) {
176			$configurationFileList[] = $newConfigurationFile;
177			}
178			$this->updateConfiguration->run(
179			new UpdateConfigurationFileListRequest(
180			$configurationFileList,
			1 ignored issue – show Documentation introduced 2017-05-01 19:01 UTC by Report Bug Copy Issue Report `$configurationFileList` is of type `array<integer,object<Yoa...del\ConfigurationFile>>`, but the function expects a `array<integer,object<Yoa...del\ConfigurationFile>>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
181			$path
182			)
183			);
184			}
185			}
186

yoanm / composerConfigManager

Pull Request — master (#17)

UpdateConfigurationFileCommand::configure() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like