ConfigurationDenormalizer::denormalize() - Code Metrics - Inspection of "Feature/update command" - yoanm/composerConfigManager - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#10)

by Yo

created 2017-04-28 16:16 UTC

ConfigurationDenormalizer::denormalize() D

↳ Parent: ConfigurationDenormalizer

Complexity

Conditions	10
Paths	1

Size

Total Lines	40
Code Lines	26

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	40
rs	4.8196
cc	10
eloc	26
nc	1
nop	1

How to fix Complexity

<?php
namespace Yoanm\ComposerConfigManager\Application\Serializer\Normalizer;

use Yoanm\ComposerConfigManager\Domain\Model\Configuration;

/**
 * Class ConfigurationDenormalizer
 */
class ConfigurationDenormalizer
{
    /** @var AuthorListNormalizer */
    private $authorListNormalizer;
    /** @var PackageListNormalizer */
    private $packageListNormalizer;
    /** @var SuggestedPackageListNormalizer */
    private $suggestedPackageListNormalizer;
    /** @var SupportListNormalizer */
    private $supportListNormalizer;
    /** @var AutoloadListNormalizer */
    private $autoloadListNormalizer;
    /** @var ScriptListNormalizer */
    private $scriptListNormalizer;

    public function __construct(
        AuthorListNormalizer $authorListNormalizer,
        PackageListNormalizer $packageListNormalizer,
        SuggestedPackageListNormalizer $suggestedPackageListNormalizer,
        SupportListNormalizer $supportListNormalizer,
        AutoloadListNormalizer $autoloadListNormalizer,
        ScriptListNormalizer $scriptListNormalizer
    ) {
        $this->authorListNormalizer = $authorListNormalizer;
        $this->packageListNormalizer = $packageListNormalizer;
        $this->suggestedPackageListNormalizer = $suggestedPackageListNormalizer;
        $this->supportListNormalizer = $supportListNormalizer;
        $this->autoloadListNormalizer = $autoloadListNormalizer;
        $this->scriptListNormalizer = $scriptListNormalizer;
    }

    /**
     * @param array $configuration
     *
     * @return Configuration
     */
    public function denormalize(array $configuration)
    {

        return new Configuration(
            $this->valueOrNull($configuration, ConfigurationNormalizer::KEY_NAME),
            $this->valueOrNull($configuration, ConfigurationNormalizer::KEY_TYPE),
            $this->valueOrNull($configuration, ConfigurationNormalizer::KEY_LICENSE),
            $this->valueOrNull($configuration, ConfigurationNormalizer::KEY_VERSION),
            $this->valueOrNull($configuration, ConfigurationNormalizer::KEY_DESCRIPTION),
            $configuration[ConfigurationNormalizer::KEY_KEYWORDS],
            isset($configuration[ConfigurationNormalizer::KEY_AUTHORS])
                ? $this->authorListNormalizer->denormalize($configuration[ConfigurationNormalizer::KEY_AUTHORS])
                : []
            ,
            isset($configuration[ConfigurationNormalizer::KEY_PROVIDE])
                ? $this->packageListNormalizer->denormalize($configuration[ConfigurationNormalizer::KEY_PROVIDE])
                : [],
            isset($configuration[ConfigurationNormalizer::KEY_SUGGEST])
                ? $this->suggestedPackageListNormalizer->denormalize($configuration[ConfigurationNormalizer::KEY_SUGGEST])
                : [],
            isset($configuration[ConfigurationNormalizer::KEY_SUPPORT])
                ? $this->supportListNormalizer->denormalize($configuration[ConfigurationNormalizer::KEY_SUPPORT])
                : [],
            isset($configuration[ConfigurationNormalizer::KEY_AUTOLOAD])
                ? $this->autoloadListNormalizer->denormalize($configuration[ConfigurationNormalizer::KEY_AUTOLOAD])
                : [],
            isset($configuration[ConfigurationNormalizer::KEY_AUTOLOAD_DEV])
                ? $this->autoloadListNormalizer->denormalize($configuration[ConfigurationNormalizer::KEY_AUTOLOAD_DEV])
                : [],
            isset($configuration[ConfigurationNormalizer::KEY_REQUIRE])
                ? $this->packageListNormalizer->denormalize($configuration[ConfigurationNormalizer::KEY_REQUIRE])
                : [],
            isset($configuration[ConfigurationNormalizer::KEY_REQUIRE_DEV])
                ? $this->packageListNormalizer->denormalize($configuration[ConfigurationNormalizer::KEY_REQUIRE_DEV])
                : [],
            isset($configuration[ConfigurationNormalizer::KEY_SCRIPT])
                ? $this->scriptListNormalizer->denormalize($configuration[ConfigurationNormalizer::KEY_SCRIPT])
                : []
        );
    }

    /**
     * @param array  $configuration
     * @param string $key
     *
     * @return mixed|null
     */
    protected function valueOrNull(array $configuration, $key)
    {
        return isset($configuration[$key]) ? $configuration[$key] : null;
    }

    /**
     * @param array  $normalizedConfiguration
     * @param string $value
     * @param string $key
     *
     * @return array
     */
    protected function appendIfDefined(array $normalizedConfiguration, $value, $key)
    {
        if ($value) {
            $normalizedConfiguration[$key] = $value;
        }

        return $normalizedConfiguration;
    }
}


1			<?php
2			namespace Yoanm\ComposerConfigManager\Application\Serializer\Normalizer;
3
4			use Yoanm\ComposerConfigManager\Domain\Model\Configuration;
5
6			/**
7			* Class ConfigurationDenormalizer
8			*/
9			class ConfigurationDenormalizer
10			{
11			/** @var AuthorListNormalizer */
12			private $authorListNormalizer;
13			/** @var PackageListNormalizer */
14			private $packageListNormalizer;
15			/** @var SuggestedPackageListNormalizer */
16			private $suggestedPackageListNormalizer;
17			/** @var SupportListNormalizer */
18			private $supportListNormalizer;
19			/** @var AutoloadListNormalizer */
20			private $autoloadListNormalizer;
21			/** @var ScriptListNormalizer */
22			private $scriptListNormalizer;
23
24			public function __construct(
25			AuthorListNormalizer $authorListNormalizer,
26			PackageListNormalizer $packageListNormalizer,
27			SuggestedPackageListNormalizer $suggestedPackageListNormalizer,
28			SupportListNormalizer $supportListNormalizer,
29			AutoloadListNormalizer $autoloadListNormalizer,
30			ScriptListNormalizer $scriptListNormalizer
31			) {
32			$this->authorListNormalizer = $authorListNormalizer;
33			$this->packageListNormalizer = $packageListNormalizer;
34			$this->suggestedPackageListNormalizer = $suggestedPackageListNormalizer;
35			$this->supportListNormalizer = $supportListNormalizer;
36			$this->autoloadListNormalizer = $autoloadListNormalizer;
37			$this->scriptListNormalizer = $scriptListNormalizer;
38			}
39
40			/**
41			* @param array $configuration
42			*
43			* @return Configuration
44			*/
45			public function denormalize(array $configuration)
46			{
47
48			return new Configuration(
49			$this->valueOrNull($configuration, ConfigurationNormalizer::KEY_NAME),
50			$this->valueOrNull($configuration, ConfigurationNormalizer::KEY_TYPE),
51			$this->valueOrNull($configuration, ConfigurationNormalizer::KEY_LICENSE),
52			$this->valueOrNull($configuration, ConfigurationNormalizer::KEY_VERSION),
53			$this->valueOrNull($configuration, ConfigurationNormalizer::KEY_DESCRIPTION),
54			$configuration[ConfigurationNormalizer::KEY_KEYWORDS],
55			isset($configuration[ConfigurationNormalizer::KEY_AUTHORS])
56			? $this->authorListNormalizer->denormalize($configuration[ConfigurationNormalizer::KEY_AUTHORS])
57			: []
58			,
59			isset($configuration[ConfigurationNormalizer::KEY_PROVIDE])
60			? $this->packageListNormalizer->denormalize($configuration[ConfigurationNormalizer::KEY_PROVIDE])
61			: [],
62			isset($configuration[ConfigurationNormalizer::KEY_SUGGEST])
63			? $this->suggestedPackageListNormalizer->denormalize($configuration[ConfigurationNormalizer::KEY_SUGGEST])
64			: [],
65			isset($configuration[ConfigurationNormalizer::KEY_SUPPORT])
66			? $this->supportListNormalizer->denormalize($configuration[ConfigurationNormalizer::KEY_SUPPORT])
67			: [],
68			isset($configuration[ConfigurationNormalizer::KEY_AUTOLOAD])
69			? $this->autoloadListNormalizer->denormalize($configuration[ConfigurationNormalizer::KEY_AUTOLOAD])
70			: [],
71			isset($configuration[ConfigurationNormalizer::KEY_AUTOLOAD_DEV])
72			? $this->autoloadListNormalizer->denormalize($configuration[ConfigurationNormalizer::KEY_AUTOLOAD_DEV])
73			: [],
74			isset($configuration[ConfigurationNormalizer::KEY_REQUIRE])
75			? $this->packageListNormalizer->denormalize($configuration[ConfigurationNormalizer::KEY_REQUIRE])
76			: [],
77			isset($configuration[ConfigurationNormalizer::KEY_REQUIRE_DEV])
78			? $this->packageListNormalizer->denormalize($configuration[ConfigurationNormalizer::KEY_REQUIRE_DEV])
79			: [],
80			isset($configuration[ConfigurationNormalizer::KEY_SCRIPT])
81			? $this->scriptListNormalizer->denormalize($configuration[ConfigurationNormalizer::KEY_SCRIPT])
82			: []
83			);
84			}
85
86			/**
87			* @param array $configuration
88			* @param string $key
89			*
90			* @return mixed\|null
91			*/
92			protected function valueOrNull(array $configuration, $key)
93			{
94			return isset($configuration[$key]) ? $configuration[$key] : null;
95			}
96
97			/**
98			* @param array $normalizedConfiguration
99			* @param string $value
100			* @param string $key
101			*
102			* @return array
103			*/
104			protected function appendIfDefined(array $normalizedConfiguration, $value, $key)
105			{
106			if ($value) {
107			$normalizedConfiguration[$key] = $value;
108			}
109
110			return $normalizedConfiguration;
111			}
112			}
113

yoanm / composerConfigManager

Pull Request — master (#10)

ConfigurationDenormalizer::denormalize() D

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like