yoanm / alfred-personal-assistant

server/cron.js

var CRON = require('cron').CronJob;


// ------------------------------------------

//  CONSTRUCTOR

// ------------------------------------------


var init = function(){

  info('Starting CRONManager ...');

  return CRONManager;

}


/**

 * Starting all jobs from properties

 */

var start = function(){

  var plugins = SARAH.PluginManager.getList();

  for (var i = 0 ; i < plugins.length ; i++){

    var plugin = plugins[i]; 

    if (!plugin.cron) continue;

    job(plugin);

  }

}


var job = function(plugin) {

  if (!plugin.cron.time){ return warn('Missing cron time table');}

  info("Starting new job %s with cron %s", plugin.name, plugin.cron.time); 

  

  // Build callback

  var next = function(data){

    if (!data){ return; }

    if (data.error){ SARAH.speak(tts); }

    

    var tts = SARAH.ScriptManager.speak(data.tts);

    if (tts){ SARAH.speak(tts); }

    

    SARAH.RuleEngine.dispatch(plugin.name, data);

  }

  

  // Create job

  var job = new CRON({

The variable job seems to be never used. Consider removing it.

    cronTime: plugin.cron.time,

    onTick: function() {

      info('Cron: %s', plugin.name);

      plugin.getInstance().cron(next, plugin.cron, SARAH);

    },

    start: true

  });

  

  // Run once

  plugin.getInstance().cron(next, plugin.cron, SARAH);

There is no return statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding return undefined; explicitly.

}


// ------------------------------------------

//  PUBLIC

// ------------------------------------------


var CRONManager = {

  'init' : init,

  'start': start

}


// Exports Manager

exports.init = CRONManager.init;