Issues in cron.js - Failed Issues - Inspection of "improve" - yoanm/alfred-personal-assistant - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — master ( c3e11c...1d8d9e )

by Yo

created 2017-01-29 22:49 UTC

server/cron.js (1 issue)

Labels

Severity

Informational 1

var CRON = require('cron').CronJob;

// ------------------------------------------
//  CONSTRUCTOR
// ------------------------------------------

var init = function(){
  info('Starting CRONManager ...');
  return CRONManager;
}

/**
 * Starting all jobs from properties
 */
var start = function(){
  var plugins = SARAH.PluginManager.getList();
  for (var i = 0 ; i < plugins.length ; i++){
    var plugin = plugins[i]; 
    if (!plugin.cron) continue;
if (a > 0)
    b = 42;
    job(plugin);
  }
}

var job = function(plugin) {
  if (!plugin.cron.time){ return warn('Missing cron time table');}
  info("Starting new job %s with cron %s", plugin.name, plugin.cron.time); 
  
  // Build callback
  var next = function(data){
    if (!data){ return; }
    if (data.error){ SARAH.speak(tts); }
    
    var tts = SARAH.ScriptManager.speak(data.tts);
    if (tts){ SARAH.speak(tts); }
    
    SARAH.RuleEngine.dispatch(plugin.name, data);
  }
  
  // Create job
  var job = new CRON({
    cronTime: plugin.cron.time,
    onTick: function() {
      info('Cron: %s', plugin.name);
      plugin.getInstance().cron(next, plugin.cron, SARAH);
    },
    start: true
  });
  
  // Run once
  plugin.getInstance().cron(next, plugin.cron, SARAH);
}

// ------------------------------------------
//  PUBLIC
// ------------------------------------------

var CRONManager = {
  'init' : init,
  'start': start
}

// Exports Manager
exports.init = CRONManager.init;

1			var CRON = require('cron').CronJob;
2
3			// ------------------------------------------
4			// CONSTRUCTOR
5			// ------------------------------------------
6
7			var init = function(){
8			info('Starting CRONManager ...');
9			return CRONManager;
10			}
11
12			/**
13			* Starting all jobs from properties
14			*/
15			var start = function(){
16			var plugins = SARAH.PluginManager.getList();
17			for (var i = 0 ; i < plugins.length ; i++){
18			var plugin = plugins[i];
19			if (!plugin.cron) continue;
			0 ignored issues – show Coding Style Best Practice introduced 2017-01-28 12:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
20			job(plugin);
21			}
22			}
23
24			var job = function(plugin) {
25			if (!plugin.cron.time){ return warn('Missing cron time table');}
26			info("Starting new job %s with cron %s", plugin.name, plugin.cron.time);
27
28			// Build callback
29			var next = function(data){
30			if (!data){ return; }
31			if (data.error){ SARAH.speak(tts); }
32
33			var tts = SARAH.ScriptManager.speak(data.tts);
34			if (tts){ SARAH.speak(tts); }
35
36			SARAH.RuleEngine.dispatch(plugin.name, data);
37			}
38
39			// Create job
40			var job = new CRON({
41			cronTime: plugin.cron.time,
42			onTick: function() {
43			info('Cron: %s', plugin.name);
44			plugin.getInstance().cron(next, plugin.cron, SARAH);
45			},
46			start: true
47			});
48
49			// Run once
50			plugin.getInstance().cron(next, plugin.cron, SARAH);
51			}
52
53			// ------------------------------------------
54			// PUBLIC
55			// ------------------------------------------
56
57			var CRONManager = {
58			'init' : init,
59			'start': start
60			}
61
62			// Exports Manager
63			exports.init = CRONManager.init;

yoanm / alfred-personal-assistant

Push — master ( c3e11c...1d8d9e )

server/cron.js (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like