Client::doRequest() - Code Metrics - Inspection of "Remove useless kernel handler" - yoanm/Behat3SymfonyExtension - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/improve ( c9aa3f...6a164f )

by Yo

created 2016-12-04 21:08 UTC

Client::doRequest() A

↳ Parent: Client

Complexity

Conditions	2
Paths	2

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	13
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	7
nc	2
nop	1

<?php
namespace Yoanm\Behat3SymfonyExtension\Client;

use Symfony\Bundle\FrameworkBundle\Client as BaseClient;
use Symfony\Component\BrowserKit\CookieJar;
use Symfony\Component\BrowserKit\History;
use Symfony\Component\HttpKernel\KernelInterface;

class Client extends BaseClient
{
    /** @var bool */
    private $requestPerformed = false;

    /**
     * @inheritDoc
     */
    public function __construct(
        KernelInterface $kernel,
        array $server,
        History $history,
        CookieJar $cookieJar
    ) {
        parent::__construct($kernel, $server, $history, $cookieJar);
        $this->disableReboot();
    }

    /**
     * @return boolean
     */
    public function hasPerformedRequest()
    {
        return $this->requestPerformed;
    }

    /**
     * {@inheritdoc}
     */
    protected function doRequest($request)
    {
        if ($this->requestPerformed) {
            // Reboot sfKernel to avoid parent::doRequest to shutdown it and from Kernel::handle to boot it
            // This behavior will allow mocking symfony app container service for instance
            $this->getKernel()->shutdown();
            $this->getKernel()->boot();
        } else {
            $this->requestPerformed = true;
        }

        return parent::doRequest($request);
    }
}


1			<?php
2			namespace Yoanm\Behat3SymfonyExtension\Client;
3
4			use Symfony\Bundle\FrameworkBundle\Client as BaseClient;
5			use Symfony\Component\BrowserKit\CookieJar;
6			use Symfony\Component\BrowserKit\History;
7			use Symfony\Component\HttpKernel\KernelInterface;
8
9			class Client extends BaseClient
10			{
11			/** @var bool */
12			private $requestPerformed = false;
13
14			/**
15			* @inheritDoc
16			*/
17			public function __construct(
18			KernelInterface $kernel,
19			array $server,
20			History $history,
21			CookieJar $cookieJar
22			) {
23			parent::__construct($kernel, $server, $history, $cookieJar);
24			$this->disableReboot();
25			}
26
27			/**
28			* @return boolean
29			*/
30			public function hasPerformedRequest()
31			{
32			return $this->requestPerformed;
33			}
34
35			/**
36			* {@inheritdoc}
37			*/
38			protected function doRequest($request)
39			{
40			if ($this->requestPerformed) {
41			// Reboot sfKernel to avoid parent::doRequest to shutdown it and from Kernel::handle to boot it
42			// This behavior will allow mocking symfony app container service for instance
43			$this->getKernel()->shutdown();
44			$this->getKernel()->boot();
45			} else {
46			$this->requestPerformed = true;
47			}
48
49			return parent::doRequest($request);
50			}
51			}
52

yoanm / Behat3SymfonyExtension

Push — feature/improve ( c9aa3f...6a164f )

Client::doRequest() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like