ynloultratech / graphql-bundle

src/Test/Helper/DoctrineHelperTrait.php

<?php
/*******************************************************************************
 *  This file is part of the GraphQL Bundle package.
 *
 *  (c) YnloUltratech <support@ynloultratech.com>
 *
 *  For the full copyright and license information, please view the LICENSE
 *  file that was distributed with this source code.
 ******************************************************************************/

namespace Ynlo\GraphQLBundle\Test\Helper;

use Doctrine\Bundle\DoctrineBundle\Registry;
use Doctrine\Common\Persistence\ObjectRepository;
use Doctrine\ORM\EntityRepository;
use Symfony\Bundle\FrameworkBundle\Client;
use Ynlo\GraphQLBundle\Model\NodeInterface;
use Ynlo\GraphQLBundle\Util\IDEncoder;

/**
 * @method Client getClient()
 *
 * @deprecated in favor of Behat tests
 */
trait DoctrineHelperTrait
{
    public static function getDoctrine(): Registry
    {
        return static::getClient()->getKernel()->getContainer()->get('doctrine');

The method Ynlo\GraphQLBundle\Test\Helper\DoctrineHelperTrait::getClient() is not static, but was called statically.

The expression return static::getClient()->getKernel()->getContainer()->get('doctrine') could return the type null which is incompatible with the type-hinted return Doctrine\Bundle\DoctrineBundle\Registry. Consider adding an additional type-check to rule them out.

    }

    /**
     * @param string $class
     *
     * @return ObjectRepository|EntityRepository
     */
    public static function getRepository(string $class): ObjectRepository
    {
        return static::getDoctrine()->getRepository($class);

The expression return static::getDoctrine()->getRepository($class) returns the type Doctrine\Persistence\ObjectRepository which includes types incompatible with the type-hinted return Doctrine\Common\Persistence\ObjectRepository.

    }

    /**
     * Find a database record from global id
     *
     * findOneByGlobalId('VXNlcjox') => object
     *
     * @param mixed $id
     *
     * @return NodeInterface
     */
    public static function findOneByGlobalId($id)
    {
        return IDEncoder::decode($id);
    }
}