ynloultratech / graphql-bundle

src/Behat/Context/JWTContext.php

<?php
/*******************************************************************************
 *  This file is part of the GraphQL Bundle package.
 *
 *  (c) YnloUltratech <support@ynloultratech.com>
 *
 *  For the full copyright and license information, please view the LICENSE
 *  file that was distributed with this source code.
 ******************************************************************************/

namespace Ynlo\GraphQLBundle\Behat\Context;

use Behat\Behat\Context\Context;
use Behat\Behat\Hook\Scope\BeforeStepScope;
use Behat\Symfony2Extension\Context\KernelAwareContext;
use Symfony\Component\HttpKernel\Kernel;
use Symfony\Component\HttpKernel\KernelInterface;
use Ynlo\GraphQLBundle\Behat\Authentication\JWT\TokenGeneratorInterface;
use Ynlo\GraphQLBundle\Behat\Authentication\UserResolverInterface;
use Ynlo\GraphQLBundle\Behat\Client\ClientAwareInterface;
use Ynlo\GraphQLBundle\Behat\Client\ClientAwareTrait;
use Ynlo\GraphQLBundle\Behat\GraphQLApiExtension;

/**
 * JWT Context
 */
final class JWTContext implements Context, KernelAwareContext, ClientAwareInterface
{
    use ClientAwareTrait;

    /**
     * @var Kernel
     */
    protected $kernel;

    private static $tokens = [];

    protected $token;

    /**
     * Sets Kernel instance.
     *
     * @param KernelInterface $kernel
     */
    public function setKernel(KernelInterface $kernel)
    {
        $this->kernel = $kernel;

$kernel is of type Symfony\Component\HttpKernel\KernelInterface, but the property $kernel was declared to be of type Symfony\Component\HttpKernel\Kernel. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

    }

    /**
     * @BeforeScenario
     */
    public function beforeScenario()
    {
        $this->token = null;
    }

    /**
     * @BeforeStep
     */
    public function beforeStep(BeforeStepScope $scope)
    {
        $config = GraphQLApiExtension::getConfig();

        if ($this->token) {
            $this->setToken($this->token);

            return;
        }

        $tags = $scope->getFeature()->getTags();
        $featureUser = null;
        foreach ($tags as $tag) {
            if (preg_match('/^jwt:/', $tag)) {
                $featureUser = preg_replace('/^jwt:/', null, $tag);
                break;
            }
        }

        if ($featureUser) {
            if (isset(self::$tokens[$featureUser])) {
                $this->token = self::$tokens[$featureUser];
                $this->setToken($this->token);

                return;
            }

            $resolverClass = $config['authentication']['jwt']['user_resolver'];
            $tokenGeneratorClass = $config['authentication']['jwt']['generator'];

            /** @var UserResolverInterface $resolver */
            $resolver = new $resolverClass($this->kernel);
            $user = $resolver->findByUsername($featureUser);

            /** @var TokenGeneratorInterface $tokenGenerator */
            $tokenGenerator = new $tokenGeneratorClass($this->kernel);
            $this->token = $tokenGenerator->generate($user);

            if (!$this->token) {
                throw new \RuntimeException('Cant resolve a token using given credentials');
            }

            self::$tokens[$featureUser] = $this->token;
            $this->setToken($this->token);
        }
    }

    protected function setToken($token)
    {
        $tokenIn = $config['authentication']['jwt']['token_in'] ?? 'header';

The variable $config seems to never exist and therefore isset should always be false.

        $tokenName = $config['authentication']['jwt']['token_name'] ?? 'Authorization';
        $tokenTemplate = $config['authentication']['jwt']['token_template'] ?? 'Bearer {token}';

        if ($token) {
            $tokenValue = str_replace('{token}', $token, $tokenTemplate);
            switch ($tokenIn) {
                case 'header':
                    $this->client->setServerParameter(sprintf('HTTP_%s', $tokenName), $tokenValue);
                    break;
                case 'query':
                    $query = http_build_query([$tokenName => $tokenValue], null, '&');
                    $this->client->setEndpoint($this->client->getEndpoint().'?'.$query);
            }
        }
    }
}