Ynlo\GraphQLBundle\Form\DataTransformer\IDToNodeTransformer

Complexity

Total Complexity

17

Size/Duplication

Total Lines	99
Duplicated Lines	0 %

Test Coverage

Coverage

54.55%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
B	transform()	0	17	5
C	reverseTransform()	0	40	11

<?php
/*******************************************************************************
 *  This file is part of the GraphQL Bundle package.
 *
 *  (c) YnloUltratech <support@ynloultratech.com>
 *
 *  For the full copyright and license information, please view the LICENSE
 *  file that was distributed with this source code.
 ******************************************************************************/

namespace Ynlo\GraphQLBundle\Form\DataTransformer;

use Doctrine\Common\Persistence\ObjectRepository;
use Symfony\Component\Form\DataTransformerInterface;
use Symfony\Component\Form\Exception\TransformationFailedException;
use Ynlo\GraphQLBundle\Model\NodeInterface;
use Ynlo\GraphQLBundle\Util\IDEncoder;

/**
 * Class IDToNodeTransformer
 */
class IDToNodeTransformer implements DataTransformerInterface
{
    /**
     * @var ObjectRepository|null
     */
    protected $repository;

    /**
     * @var array
     */
    protected $findBy = [];

    /**
     * IDToNodeTransformer constructor.
     *
     * @param ObjectRepository $repository
     * @param string|array     $findBy
     */
    public function __construct(ObjectRepository $repository = null, $findBy = null)
    {
        $this->repository = $repository;
        $this->findBy = (array) $findBy;
    }

    /**
     * Transforms an object (issue) to a string (number).
     *
     * @param NodeInterface|NodeInterface[] $node
     *
     * @return string|string[]
     */
    public function transform($node)
    {
        if (!$node) {
            return $node;

The expression return $node returns the type Ynlo\GraphQLBundle\Model\NodeInterface[]&Ynlo\GraphQLBundle\Model\NodeInterface which is incompatible with the documented return type string|string[].

        }

        if (\is_array($node) || $node instanceof \Traversable) {
            $ids = [];
            /** @var array $node */
            foreach ($node as $n) {
                $ids[] = $this->transform($n);
            }

            return $ids;

The expression return $ids returns an array which contains values of type string[] which are incompatible with the documented value type string.

        }

        return IDEncoder::encode($node);
    }

    /**
     * Transforms a string (id) to an object (node).
     *
     * @param string|string[]|mixed $globalId
     *
     * @return mixed
     *
     * @throws TransformationFailedException if object (issue) is not found.
     */
    public function reverseTransform($globalId)
    {
        if (!$globalId || \is_object($globalId)) {
            return $globalId;
        }

        if (\is_array($globalId)) {
            $nodes = [];
            /** @var array $globalId */
            foreach ($globalId as $id) {
                $nodes[] = $this->reverseTransform($id);
            }

            return $nodes;
        }

        $node = IDEncoder::decode($globalId);

        if (null === $node && $this->repository && $this->findBy) {

The expression $this->findBy of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            foreach ($this->findBy as $findBy) {
                $node = $this->repository->findOneBy([$findBy => $globalId]);
                if ($node) {
                    break;
                }
            }
        }

        if (null === $node) {
            // causes a validation error
            // this message is not shown to the user
            // see the invalid_message option
            throw new TransformationFailedException(
                sprintf(
                    'An node with id "%s" does not exist!',
                    $globalId
                )
            );
        }

        return $node;
    }
}