ynloultratech /
graphql-bundle
| Conditions | 30 |
| Paths | 2628 |
| Total Lines | 101 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 62 |
| CRAP Score | 30.9383 |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 67 | 1 | public function resolve(ExecutableDefinitionInterface $executableDefinition,ObjectDefinitionInterface $node, Endpoint $endpoint): array |
|
| 68 | { |
||
| 69 | 1 | $class = $node->getClass(); |
|
| 70 | 1 | $filters = []; |
|
| 71 | try { |
||
| 72 | 1 | if (!$class || !($metaData = $this->manager->getClassMetadata($class))) { |
|
| 73 | return $filters; |
||
| 74 | } |
||
| 75 | |||
| 76 | 1 | foreach ($node->getFields() as $field) { |
|
| 77 | 1 | if (!$metaData->hasField($field->getName()) |
|
| 78 | 1 | && !$metaData->hasAssociation($field->getName()) |
|
| 79 | 1 | && !$metaData->hasField($field->getOriginName()) |
|
| 80 | 1 | && !$metaData->hasAssociation($field->getOriginName())) { |
|
| 81 | 1 | continue; |
|
| 82 | } |
||
| 83 | |||
| 84 | //ignore ID |
||
| 85 | 1 | if ($field->getName() === 'id') { |
|
| 86 | 1 | continue; |
|
| 87 | } |
||
| 88 | |||
| 89 | 1 | $filter = new Filter(); |
|
| 90 | 1 | $filter->name = $filter->field = $field->getName(); |
|
| 91 | |||
| 92 | //simple fields |
||
| 93 | 1 | switch (TypeUtil::normalize($field->getType())) { |
|
| 94 | 1 | case Types::STRING: |
|
| 95 | 1 | $filter->resolver = StringFilter::class; |
|
| 96 | 1 | $filter->type = StringComparisonExpression::class; |
|
| 97 | 1 | if ($field->isList()) { |
|
| 98 | 1 | $filter->resolver = ArrayFilter::class; |
|
| 99 | 1 | $filter->type = ArrayComparisonExpression::class; |
|
| 100 | } |
||
| 101 | 1 | break; |
|
| 102 | 1 | case Types::BOOLEAN: |
|
| 103 | 1 | $filter->resolver = BooleanFilter::class; |
|
| 104 | 1 | $filter->type = Types::BOOLEAN; |
|
| 105 | 1 | break; |
|
| 106 | 1 | case Types::DATE: |
|
| 107 | $filter->resolver = DateFilter::class; |
||
| 108 | $filter->type = DateComparisonExpression::class; |
||
| 109 | break; |
||
| 110 | 1 | case Types::DATETIME: |
|
| 111 | 1 | $filter->resolver = DateFilter::class; |
|
| 112 | 1 | $filter->type = DateTimeComparisonExpression::class; |
|
| 113 | 1 | break; |
|
| 114 | 1 | case Types::INT: |
|
| 115 | 1 | $filter->resolver = NumberFilter::class; |
|
| 116 | 1 | $filter->type = IntegerComparisonExpression::class; |
|
| 117 | 1 | break; |
|
| 118 | 1 | case Types::FLOAT: |
|
| 119 | 1 | $filter->resolver = NumberFilter::class; |
|
| 120 | 1 | $filter->type = FloatComparisonExpression::class; |
|
| 121 | 1 | break; |
|
| 122 | } |
||
| 123 | |||
| 124 | //relations and enums |
||
| 125 | 1 | if (!$filter->resolver && $endpoint->hasType($field->getType())) { |
|
| 126 | 1 | $relatedNode = $endpoint->getType($field->getType()); |
|
| 127 | |||
| 128 | //enum registered using enum definition |
||
| 129 | 1 | if ($relatedNode instanceof EnumDefinition) { |
|
| 130 | 1 | $enumName = $relatedNode->getName(); |
|
| 131 | 1 | foreach ($relatedNode->getValues() as $value) { |
|
| 132 | 1 | $enumValues[] = $value->getName(); |
|
| 133 | } |
||
| 134 | 1 | $filter = $this->createEnumFilter($endpoint, $field, $enumName, $enumValues); |
|
|
Comprehensibility
Best Practice
introduced
by
|
|||
| 135 | 1 | $filter->field = $field->getName(); |
|
| 136 | 1 | } elseif ($relatedNode instanceof ClassAwareDefinitionInterface) { |
|
| 137 | 1 | $relatedEntity = $relatedNode->getClass(); |
|
| 138 | try { |
||
| 139 | 1 | if ($this->manager->getClassMetadata($relatedEntity)) { |
|
| 140 | 1 | $filter->resolver = NodeFilter::class; |
|
| 141 | 1 | $filter->type = NodeComparisonExpression::class; |
|
| 142 | } |
||
| 143 | } catch (MappingException $exception) { |
||
| 144 | //ignore |
||
| 145 | } |
||
| 146 | } |
||
| 147 | } |
||
| 148 | |||
| 149 | //enum registered as internal GraphQL type |
||
| 150 | 1 | if (!$filter->resolver && TypeRegistry::has($field->getType()) |
|
| 151 | 1 | && ($enumType = TypeRegistry::get($field->getType())) |
|
| 152 | 1 | && $enumType instanceof EnumType) { |
|
| 153 | 1 | $enumName = $enumType->name; |
|
| 154 | 1 | foreach ($enumType->getValues() as $value) { |
|
| 155 | 1 | $enumValues[] = $value->name; |
|
| 156 | } |
||
| 157 | 1 | $filter = $this->createEnumFilter($endpoint, $field, $enumName, $enumValues); |
|
| 158 | } |
||
| 159 | |||
| 160 | 1 | if ($filter->resolver) { |
|
| 161 | 1 | $filters[] = $filter; |
|
| 162 | } |
||
| 163 | } |
||
| 164 | |||
| 165 | 1 | return $filters; |
|
| 166 | } catch (MappingException $exception) { |
||
| 167 | return []; |
||
| 168 | } |
||
| 207 |
Loading history...