TransformAnyValueToString::supportsDefinitionAndArgument() - Code Metrics - Inspection of "behat" - ynloultratech/graphql-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#9)

by Rafael

created 2018-02-01 01:00 UTC

supportsDefinitionAndArgument() A

↳ Parent: TransformAnyValueToString

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	3
ccs	0
cts	3
cp	0
rs	10
c	0
b	0
f	0
cc	1
eloc	1
nc	1
nop	3
crap	2

<?php
/*******************************************************************************
 *  This file is part of the GraphQL Bundle package.
 *
 *  (c) YnloUltratech <[email protected]>
 *
 *  For the full copyright and license information, please view the LICENSE
 *  file that was distributed with this source code.
 ******************************************************************************/

namespace Ynlo\GraphQLBundle\Behat\Transformer;

use Behat\Behat\Definition\Call\DefinitionCall;
use Behat\Behat\Transformation\Transformer\ArgumentTransformer;

/**
 * Transform any value to literal string,
 * can be used to escape scalar types like int or bool
 *
 * @example '2' => "2"
 * @example "'2'" => "2"
 * @example "'true'" => "true"
 * @example "'{faker.randomNumber}'" => "5531"
 */
class TransformAnyValueToString implements ArgumentTransformer
{
    private const PATTERN = '/^\'.*\'$/';

    /**
     * @var TransformStringToExpression
     */
    protected $expressionTransformer;

    /**
     * TransformAnyValueToString constructor.
     *
     * @param TransformStringToExpression $expressionTransformer
     */
    public function __construct(TransformStringToExpression $expressionTransformer)
    {
        $this->expressionTransformer = $expressionTransformer;
    }

    public function supportsDefinitionAndArgument(DefinitionCall $definitionCall, $argumentIndex, $argumentValue)
    {
        return preg_match(self::PATTERN, $argumentValue);
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }

    public function transformArgument(DefinitionCall $definitionCall, $argumentIndex, $argumentValue)
    {
        if (preg_match('/^\'({.*})\'$/', $argumentValue, $matches)) {
            return (string) $this->expressionTransformer->transformArgument($definitionCall, $argumentIndex, $matches[1]);
        }

        return (string) $argumentValue;
    }
}


1			<?php
2			/*******************************************************************************
3			* This file is part of the GraphQL Bundle package.
4			*
5			* (c) YnloUltratech <[email protected]>
6			*
7			* For the full copyright and license information, please view the LICENSE
8			* file that was distributed with this source code.
9			******************************************************************************/
10
11			namespace Ynlo\GraphQLBundle\Behat\Transformer;
12
13			use Behat\Behat\Definition\Call\DefinitionCall;
14			use Behat\Behat\Transformation\Transformer\ArgumentTransformer;
15
16			/**
17			* Transform any value to literal string,
18			* can be used to escape scalar types like int or bool
19			*
20			* @example '2' => "2"
21			* @example "'2'" => "2"
22			* @example "'true'" => "true"
23			* @example "'{faker.randomNumber}'" => "5531"
24			*/
25			class TransformAnyValueToString implements ArgumentTransformer
26			{
27			private const PATTERN = '/^\'.*\'$/';
28
29			/**
30			* @var TransformStringToExpression
31			*/
32			protected $expressionTransformer;
33
34			/**
35			* TransformAnyValueToString constructor.
36			*
37			* @param TransformStringToExpression $expressionTransformer
38			*/
39			public function __construct(TransformStringToExpression $expressionTransformer)
40			{
41			$this->expressionTransformer = $expressionTransformer;
42			}
43
44			public function supportsDefinitionAndArgument(DefinitionCall $definitionCall, $argumentIndex, $argumentValue)
45			{
46			return preg_match(self::PATTERN, $argumentValue);
			0 ignored issues – show Bug Best Practice introduced 2018-02-01 01:04 UTC by Report Bug Copy Issue Report The expression `return preg_match(self::PATTERN, $argumentValue)` returns the type `integer` which is incompatible with the return type mandated by `Behat\Behat\Transformati...DefinitionAndArgument()` of `boolean`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
47			}
48
49			public function transformArgument(DefinitionCall $definitionCall, $argumentIndex, $argumentValue)
50			{
51			if (preg_match('/^\'({.*})\'$/', $argumentValue, $matches)) {
52			return (string) $this->expressionTransformer->transformArgument($definitionCall, $argumentIndex, $matches[1]);
53			}
54
55			return (string) $argumentValue;
56			}
57			}
58

ynloultratech / graphql-bundle

Pull Request — master (#9)

supportsDefinitionAndArgument() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like