ExplorerController::explorerAction() - Code Metrics - Inspection of "Fix html/twig template ext & format convention" - ynloultratech/graphql-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( f061a0...b4f1c6 )

by Yonel Ceruto

created 2018-01-10 16:12 UTC

ExplorerController::explorerAction() C

↳ Parent: ExplorerController

Complexity

Conditions	13
Paths	21

Size

Total Lines	51
Code Lines	36

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	182

Importance

Changes

Metric	Value
dl	0
loc	51
ccs	0
cts	44
cp	0
rs	5.6547
c	0
b	0
f	0
cc	13
eloc	36
nc	21
nop	1
crap	182

How to fix Long Method Complexity

<?php
/*******************************************************************************
 *  This file is part of the GraphQL Bundle package.
 *
 *  (c) YnloUltratech <[email protected]>
 *
 *  For the full copyright and license information, please view the LICENSE
 *  file that was distributed with this source code.
 ******************************************************************************/

namespace Ynlo\GraphQLBundle\Controller;

use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Component\Form\FormError;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Ynlo\GraphQLBundle\GraphiQL\AuthenticationFailedException;
use Ynlo\GraphQLBundle\GraphiQL\GraphiQLAuthenticationProviderInterface;
use Ynlo\GraphQLBundle\GraphiQL\GraphiQLRequest;

class ExplorerController extends AbstractController
{
    private $config;
    private $provider;

    public function __construct(array $config, GraphiQLAuthenticationProviderInterface $provider = null)
    {
        $this->config = $config;
        $this->provider = $provider;
    }

    public function explorer(Request $request): Response
    {
        $form = null;
        $authenticationError = null;
        $isAuthenticated = false;

        if ($this->provider) {
            if ($this->provider->requireUserData()) {
                $builder = $this->createFormBuilder();
                $this->provider->buildUserForm($builder);
                $form = $builder->getForm();
            }

            if ($request->get('logout')) {
                $this->provider->logout();

                return $this->redirectToRoute('api_explore');
            }

            $form->handleRequest($request);
            $response = null;


            try {
                if ($form && $form->isSubmitted() && $form->isValid()) {
                    $this->provider->login($form);
                } elseif (!$form) {
                    $this->provider->login();
                }
            } catch (AuthenticationFailedException $exception) {
                if ($form) {
                    $form->addError(new FormError($exception->getMessage()));
                } else {
                    $authenticationError = $exception->getMessage();
                }
            }

            $isAuthenticated = $this->provider->isAuthenticated();
        }

        return $this->render($this->config['template'], [
            'form' => $form ? $form->createView() : null,
            'isAuthenticated' => $isAuthenticated,
            'title' => $this->config['title'],
            'authenticationEnabled' => (bool) $this->provider,
            'authenticationRequired' => $this->config['authentication']['required'],
            'authenticationError' => $authenticationError,
            'hasAuthenticationError' => $authenticationError || ($form && $form->getErrors(true)->count()),
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            'loginMessage' => $this->config['authentication']['login_message'],
            'dataWarningMessage' => $this->config['data_warning_message'],
            'dataWarningDismissible' => $this->config['data_warning_dismissible'],
            'dataWarningStyle' => $this->config['data_warning_style'],
        ]);
    }

    public function graphiQL()
    {
        $request = new GraphiQLRequest(
            $this->generateUrl('api_root'),
            [],
            [
                'Accept' => 'application/json',
                'Content-Type' => 'application/json',
            ]
        );
        if ($this->provider) {
            $this->provider->prepareRequest($request);
        }

        return $this->render('@YnloGraphQL/graphiql.html.twig', [
            'url' => $request->getUrl(),
            'method' => 'post',
            'headers' => $request->getHeaders(),
        ]);
    }
}


1			<?php
2			/*******************************************************************************
3			* This file is part of the GraphQL Bundle package.
4			*
5			* (c) YnloUltratech <[email protected]>
6			*
7			* For the full copyright and license information, please view the LICENSE
8			* file that was distributed with this source code.
9			******************************************************************************/
10
11			namespace Ynlo\GraphQLBundle\Controller;
12
13			use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
14			use Symfony\Component\Form\FormError;
15			use Symfony\Component\HttpFoundation\Request;
16			use Symfony\Component\HttpFoundation\Response;
17			use Ynlo\GraphQLBundle\GraphiQL\AuthenticationFailedException;
18			use Ynlo\GraphQLBundle\GraphiQL\GraphiQLAuthenticationProviderInterface;
19			use Ynlo\GraphQLBundle\GraphiQL\GraphiQLRequest;
20
21			class ExplorerController extends AbstractController
22			{
23			private $config;
24			private $provider;
25
26			public function __construct(array $config, GraphiQLAuthenticationProviderInterface $provider = null)
27			{
28			$this->config = $config;
29			$this->provider = $provider;
30			}
31
32			public function explorer(Request $request): Response
33			{
34			$form = null;
35			$authenticationError = null;
36			$isAuthenticated = false;
37
38			if ($this->provider) {
39			if ($this->provider->requireUserData()) {
40			$builder = $this->createFormBuilder();
41			$this->provider->buildUserForm($builder);
42			$form = $builder->getForm();
43			}
44
45			if ($request->get('logout')) {
46			$this->provider->logout();
47
48			return $this->redirectToRoute('api_explore');
49			}
50
51			$form->handleRequest($request);
52			$response = null;
			0 ignored issues – show Unused Code introduced 2017-12-21 14:57 UTC by Report Bug Copy Issue Report The assignment to `$response` is dead and can be removed. Loading history...
53
54			try {
55			if ($form && $form->isSubmitted() && $form->isValid()) {
56			$this->provider->login($form);
57			} elseif (!$form) {
58			$this->provider->login();
59			}
60			} catch (AuthenticationFailedException $exception) {
61			if ($form) {
62			$form->addError(new FormError($exception->getMessage()));
63			} else {
64			$authenticationError = $exception->getMessage();
65			}
66			}
67
68			$isAuthenticated = $this->provider->isAuthenticated();
69			}
70
71			return $this->render($this->config['template'], [
72			'form' => $form ? $form->createView() : null,
73			'isAuthenticated' => $isAuthenticated,
74			'title' => $this->config['title'],
75			'authenticationEnabled' => (bool) $this->provider,
76			'authenticationRequired' => $this->config['authentication']['required'],
77			'authenticationError' => $authenticationError,
78			'hasAuthenticationError' => $authenticationError \|\| ($form && $form->getErrors(true)->count()),
			0 ignored issues – show Bug Best Practice introduced 2017-12-21 14:57 UTC by Report Bug Copy Issue Report The expression `$authenticationError` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
79			'loginMessage' => $this->config['authentication']['login_message'],
80			'dataWarningMessage' => $this->config['data_warning_message'],
81			'dataWarningDismissible' => $this->config['data_warning_dismissible'],
82			'dataWarningStyle' => $this->config['data_warning_style'],
83			]);
84			}
85
86			public function graphiQL()
87			{
88			$request = new GraphiQLRequest(
89			$this->generateUrl('api_root'),
90			[],
91			[
92			'Accept' => 'application/json',
93			'Content-Type' => 'application/json',
94			]
95			);
96			if ($this->provider) {
97			$this->provider->prepareRequest($request);
98			}
99
100			return $this->render('@YnloGraphQL/graphiql.html.twig', [
101			'url' => $request->getUrl(),
102			'method' => 'post',
103			'headers' => $request->getHeaders(),
104			]);
105			}
106			}
107

ynloultratech / graphql-bundle

Push — master ( f061a0...b4f1c6 )

ExplorerController::explorerAction() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like