Ynlo\GraphQLBundle\Mutation\UpdateNode

Complexity

Total Complexity

10

Size/Duplication

Total Lines	57
Duplicated Lines	38.6 %

Test Coverage

Coverage

80%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	returnPayload()	7	7	2
A	preUpdate()	0	2	1
A	postUpdate()	0	2	1
A	process()	12	12	3
A	onSubmit()	0	7	3

<?php
/*******************************************************************************
 *  This file is part of the GraphQL Bundle package.
 *
 *  (c) YnloUltratech <support@ynloultratech.com>
 *
 *  For the full copyright and license information, please view the LICENSE
 *  file that was distributed with this source code.
 ******************************************************************************/

namespace Ynlo\GraphQLBundle\Mutation;

use Ynlo\GraphQLBundle\Error\NodeNotFoundException;
use Ynlo\GraphQLBundle\Extension\ExtensionManager;
use Ynlo\GraphQLBundle\Model\NodeInterface;
use Ynlo\GraphQLBundle\Model\UpdateNodePayload;
use Ynlo\GraphQLBundle\Validator\ConstraintViolationList;

/**
 * Class UpdateNodeMutation
 */
class UpdateNode extends AbstractMutationResolver
{
    /**
     * {@inheritdoc}
     */
    protected function process(&$data)

This method seems to be duplicated in your project.

    {
        $this->preUpdate($data);
        foreach ($this->container->get(ExtensionManager::class)->getExtensions() as $extension) {
            $extension->preUpdate($data, $this, $this->context);
        }

        $this->getManager()->flush();

        $this->postUpdate($data);
        foreach ($this->container->get(ExtensionManager::class)->getExtensions() as $extension) {
            $extension->postUpdate($data, $this, $this->context);
        }
    }

    /**
     * {@inheritdoc}
     */
    protected function onSubmit($inputSource, &$normData)
    {
        if ($normData instanceof NodeInterface && $normData->getId()) {

The expression $normData->getId() of type null|integer is loosely compared to true; this is ambiguous if the integer can be 0. You might want to explicitly use !== null instead.

            return;
        }

        throw new NodeNotFoundException();
    }

    /**
     * {@inheritdoc}
     */
    protected function returnPayload($data, ConstraintViolationList $violations, $inputSource)

This method seems to be duplicated in your project.

    {
        if ($violations->count()) {
            $data = null;
        }

        return new UpdateNodePayload($data, $violations->all(), $inputSource['clientMutationId'] ?? null);
    }

    /**
     * @param NodeInterface $node
     */
    protected function preUpdate(NodeInterface $node)

The parameter $node is not used and could be removed.

    {
        //override
    }

    /**
     * @param NodeInterface $node
     */
    protected function postUpdate(NodeInterface $node)

The parameter $node is not used and could be removed.

    {
        //override
    }
}