DataWithIdToNodeTransformer::__construct() - Code Metrics - Inspection of "Add some helpful methods to use in tests" - ynloultratech/graphql-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 533532...ee214c )

by Rafael

created 2018-01-25 16:54 UTC

DataWithIdToNodeTransformer::__construct() A

↳ Parent: DataWithIdToNodeTransformer

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	0
cts	4
cp	0
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	2
crap	2

<?php
/*******************************************************************************
 *  This file is part of the GraphQL Bundle package.
 *
 *  (c) YnloUltratech <[email protected]>
 *
 *  For the full copyright and license information, please view the LICENSE
 *  file that was distributed with this source code.
 ******************************************************************************/

namespace Ynlo\GraphQLBundle\Form\DataTransformer;

use Doctrine\ORM\EntityManagerInterface;
use Symfony\Component\Form\DataTransformerInterface;
use Ynlo\GraphQLBundle\Definition\Registry\Endpoint;
use Ynlo\GraphQLBundle\Model\ID;

/**
 * Class IDToNodeTransformer
 */
class DataWithIdToNodeTransformer implements DataTransformerInterface
{
    /**
     * @var EntityManagerInterface
     */
    private $em;

    /**
     * @var Endpoint
     */
    protected $endpoint;

    /**
     * IDToNodeTransformer constructor.
     *
     * @param EntityManagerInterface $em
     * @param Endpoint               $endpoint
     */
    public function __construct(EntityManagerInterface $em, Endpoint $endpoint)
    {
        $this->em = $em;
        $this->endpoint = $endpoint;
    }

    /**
     * {@inheritdoc}
     */
    public function transform($data)
    {
        if (is_array($data) && isset($data['id'])) {
            $id = ID::createFromString($data['id']);
            if ($this->endpoint->hasType($id->getNodeType())) {
                $class = $this->endpoint->getClassForType($id->getNodeType());
                if ($class) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
                    return $this->em->getRepository($class)->find($id->getDatabaseId());
                }
            }
        }

        return null;
    }

    /**
     * {@inheritdoc}
     */
    public function reverseTransform($data)
    {
        return $data;
    }
}


1			<?php
2			/*******************************************************************************
3			* This file is part of the GraphQL Bundle package.
4			*
5			* (c) YnloUltratech <[email protected]>
6			*
7			* For the full copyright and license information, please view the LICENSE
8			* file that was distributed with this source code.
9			******************************************************************************/
10
11			namespace Ynlo\GraphQLBundle\Form\DataTransformer;
12
13			use Doctrine\ORM\EntityManagerInterface;
14			use Symfony\Component\Form\DataTransformerInterface;
15			use Ynlo\GraphQLBundle\Definition\Registry\Endpoint;
16			use Ynlo\GraphQLBundle\Model\ID;
17
18			/**
19			* Class IDToNodeTransformer
20			*/
21			class DataWithIdToNodeTransformer implements DataTransformerInterface
22			{
23			/**
24			* @var EntityManagerInterface
25			*/
26			private $em;
27
28			/**
29			* @var Endpoint
30			*/
31			protected $endpoint;
32
33			/**
34			* IDToNodeTransformer constructor.
35			*
36			* @param EntityManagerInterface $em
37			* @param Endpoint $endpoint
38			*/
39			public function __construct(EntityManagerInterface $em, Endpoint $endpoint)
40			{
41			$this->em = $em;
42			$this->endpoint = $endpoint;
43			}
44
45			/**
46			* {@inheritdoc}
47			*/
48			public function transform($data)
49			{
50			if (is_array($data) && isset($data['id'])) {
51			$id = ID::createFromString($data['id']);
52			if ($this->endpoint->hasType($id->getNodeType())) {
53			$class = $this->endpoint->getClassForType($id->getNodeType());
54			if ($class) {
			0 ignored issues – show Bug Best Practice introduced 2017-12-09 06:32 UTC by Report Bug Copy Issue Report The expression `$class` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
55			return $this->em->getRepository($class)->find($id->getDatabaseId());
56			}
57			}
58			}
59
60			return null;
61			}
62
63			/**
64			* {@inheritdoc}
65			*/
66			public function reverseTransform($data)
67			{
68			return $data;
69			}
70			}
71

ynloultratech / graphql-bundle

Push — master ( 533532...ee214c )

DataWithIdToNodeTransformer::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like