Ynlo\GraphQLBundle\Exception\ControlledError::create()

Size

Total Lines	28
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	ControlledError.php$0 ➔ __construct()	0	6	2
A	ControlledError.php$0 ➔ getCategory()	0	3	1

<?php
/*******************************************************************************
 *  This file is part of the GraphQL Bundle package.
 *
 *  (c) YnloUltratech <support@ynloultratech.com>
 *
 *  For the full copyright and license information, please view the LICENSE
 *  file that was distributed with this source code.
 ******************************************************************************/

namespace Ynlo\GraphQLBundle\Exception;

use GraphQL\Error\UserError;

abstract class ControlledError extends UserError implements ControlledErrorInterface
{
    /**
     * @var string
     */
    protected $description;

    /**
     * @return string
     */
    public function getDescription(): ?string
    {
        return $this->description;
    }

    /**
     * Throw a controlled error dynamically
     *
     * @param int|string  $code
     * @param string      $message
     * @param string|null $category
     *
     * @return ControlledError
     */
    public static function create($code, $message = null, $category = null)
    {
        return new class($message, $code, $category) extends ControlledError

It seems like $category can also be of type string; however, parameter $category of anonymous//src/Exception/ControlledError.php$0::__construct() does only seem to accept null, maybe add an additional type check?

        {
            /**
             * @var string
             */
            protected $category;

            /**
             * @param string $message
             * @param string $code
             * @param null   $category

Are you sure the doc-type for parameter $category is correct as it would always require null to be passed?

             */
            public function __construct($message, $code, $category = null)
            {
                if ($category) {

$category is of type null, thus it always evaluated to false.

                    $this->category = $category;
                }
                parent:: __construct($message, $code);

$code of type string is incompatible with the type integer expected by parameter $code of Exception::__construct().

            }

            /**
             * @return string
             */
            public function getCategory(): string
            {
                return $this->category ?? parent::getCategory();
            }
        };
    }
}