Ylvan\Models\WeatherHandler::getHistoricalResponse()

Complexity

Conditions	6
Paths	44

Size

Total Lines	53
Code Lines	33

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    private function getHistoricalResponse($lat, $long) : array
    {
        //openweathermap documentation
        // https://openweathermap.org/api/one-call-api#history
        $key = $this->accessKey;
        $url = 'http://api.openweathermap.org/data/2.5/onecall/timemachine';
        $options = [
            CURLOPT_RETURNTRANSFER => true,
        ];
        $currentTime = time();
        $day1 = ($currentTime - ((24*60*60)*1));
        $day2 = ($currentTime - ((24*60*60)*2));
        $day3 = ($currentTime - ((24*60*60)*3));
        $day4 = ($currentTime - ((24*60*60)*4));
        $day5 = ($currentTime - ((24*60*60)*5));
        $timeList = [$currentTime, $day1, $day2, $day3, $day4, $day5];


        // Add all curl handlers and remember them
        // Initiate the multi curl handler
        $mh = curl_multi_init();
        $chAll = [];
        try {
            foreach ($timeList as $time) {
                $ch = curl_init($url . '?lat=' . $lat . '&lon=' . $long . '&dt=' . $time . '&appid=' . $key . '&units=metric');
                curl_setopt_array($ch, $options);
                curl_multi_add_handle($mh, $ch);

It seems like $mh can also be of type true; however, parameter $multi_handle of curl_multi_add_handle() does only seem to accept CurlMultiHandle|resource, maybe add an additional type check?

                $chAll[] = $ch;
            }

            // Execute all queries simultaneously,
            // and continue when all are complete
            $running = null;
            do {
                curl_multi_exec($mh, $running);

It seems like $mh can also be of type true; however, parameter $multi_handle of curl_multi_exec() does only seem to accept CurlMultiHandle|resource, maybe add an additional type check?

            } while ($running);

            // Close the handles
            foreach ($chAll as $ch) {
                curl_multi_remove_handle($mh, $ch);

It seems like $mh can also be of type true; however, parameter $multi_handle of curl_multi_remove_handle() does only seem to accept CurlMultiHandle|resource, maybe add an additional type check?

            }
            curl_multi_close($mh);

It seems like $mh can also be of type true; however, parameter $multi_handle of curl_multi_close() does only seem to accept CurlMultiHandle|resource, maybe add an additional type check?

            // All of our requests are done, access the results
            $response = [];
            foreach ($chAll as $ch) {
                $data = curl_multi_getcontent($ch);
                $response[] = json_decode($data, true);
            }

            return $response;
        } catch (\Throwable $th) {
            return ["could not connect to openweathermap"];
        }