SubmitButton::submit_button_text() - Code Metrics - Inspection of "7.0.0" - yikesinc/yikes-inc-easy-mailchimp-extender - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — staging (#840)

unknown

created 2019-12-11 21:04 UTC

SubmitButton::submit_button_text() A

↳ Parent: SubmitButton

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
nc	3
nop	1
dl	0
loc	17
rs	9.7
c	0
b	0
f	0

<?php

namespace YIKES\EasyForms\Form;

trait SubmitButton {

    public function submit_button_classes() {
        $submit_button_classes = 'yikes-easy-mc-submit-button yikes-easy-mc-submit-button-';
        $submit_button_classes .= $this->form_id;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $submit_button_classes .= ' btn btn-primary';
        // Adding additional space in front of these classes.
        $submit_button_classes .= ' ' . $this->form_data['form_settings']['yikes-easy-mc-submit-button-classes'];
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $submit_button_classes .= $this->admin_class;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        return apply_filters( 'yikes-mailchimp-form-submit-button-classes', $submit_button_classes, $this->form_id );
    }

    public function submit_button_text( $shortcode_prop ) {
        $submit_button_text = '';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        switch( true ) {
            case ! empty( $shortcode_prop ):
                $submit_button_text = $shortcode_prop;
            break;

            case $this->form_data['form_settings']['yikes-easy-mc-submit-button-text']:
                $submit_button_text = $this->form_data['form_settings']['yikes-easy-mc-submit-button-text'];
            break;

            default:
                $submit_button_text = __( 'Submit', 'yikes-inc-easy-mailchimp-extender' );
            break;
        }
        return apply_filters( 'yikes-mailchimp-form-submit-button-text', $submit_button_text, $this->form_id );
    }
}

1			<?php
2
3			namespace YIKES\EasyForms\Form;
4
5			trait SubmitButton {
6
7			public function submit_button_classes() {
8			$submit_button_classes = 'yikes-easy-mc-submit-button yikes-easy-mc-submit-button-';
9			$submit_button_classes .= $this->form_id;
			0 ignored issues – show Bug introduced 2019-12-10 15:01 UTC by Report Bug Copy Issue Report The property `form_id` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
10			$submit_button_classes .= ' btn btn-primary';
11			// Adding additional space in front of these classes.
12			$submit_button_classes .= ' ' . $this->form_data['form_settings']['yikes-easy-mc-submit-button-classes'];
			0 ignored issues – show Bug introduced 2019-12-10 15:01 UTC by Report Bug Copy Issue Report The property `form_data` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
13			$submit_button_classes .= $this->admin_class;
			0 ignored issues – show Bug introduced 2019-12-10 15:01 UTC by Report Bug Copy Issue Report The property `admin_class` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
14			return apply_filters( 'yikes-mailchimp-form-submit-button-classes', $submit_button_classes, $this->form_id );
15			}
16
17			public function submit_button_text( $shortcode_prop ) {
18			$submit_button_text = '';
			0 ignored issues – show Unused Code introduced 2019-12-10 15:01 UTC by Report Bug Copy Issue Report `$submit_button_text` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
19			switch( true ) {
20			case ! empty( $shortcode_prop ):
21			$submit_button_text = $shortcode_prop;
22			break;
23
24			case $this->form_data['form_settings']['yikes-easy-mc-submit-button-text']:
25			$submit_button_text = $this->form_data['form_settings']['yikes-easy-mc-submit-button-text'];
26			break;
27
28			default:
29			$submit_button_text = __( 'Submit', 'yikes-inc-easy-mailchimp-extender' );
30			break;
31			}
32			return apply_filters( 'yikes-mailchimp-form-submit-button-text', $submit_button_text, $this->form_id );
33			}
34			}

yikesinc / yikes-inc-easy-mailchimp-extender

Pull Request — staging (#840)

SubmitButton::submit_button_text() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like