Completed
Pull Request — master (#811)
by
unknown
09:59 queued 07:34
created
partials/menu/options-sections/templates/integration-interest-groups.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -27,13 +27,13 @@  discard block
 block discarded – undo
27 27
 		*/
28 28
 		foreach ( $interest_groupings as $id => $interest_group ) {
29 29
 
30
-			$interest_group_type      = isset( $interest_group['type'] ) ? $interest_group['type'] : '';
31
-			$interest_groups_fields   = isset( $interest_group['items'] ) ? $interest_group['items'] : array();
32
-			$selected_interest_groups = isset( $integration_options[ $integration_type ]['interest-groups'] ) ? $integration_options[ $integration_type ]['interest-groups'] : array();
33
-			$selected_interest_groups = isset( $selected_interest_groups[$list_id] ) ? $selected_interest_groups[$list_id] : $selected_interest_groups;
30
+			$interest_group_type      = isset( $interest_group[ 'type' ] ) ? $interest_group[ 'type' ] : '';
31
+			$interest_groups_fields   = isset( $interest_group[ 'items' ] ) ? $interest_group[ 'items' ] : array();
32
+			$selected_interest_groups = isset( $integration_options[ $integration_type ][ 'interest-groups' ] ) ? $integration_options[ $integration_type ][ 'interest-groups' ] : array();
33
+			$selected_interest_groups = isset( $selected_interest_groups[ $list_id ] ) ? $selected_interest_groups[ $list_id ] : $selected_interest_groups;
34 34
 			?>
35 35
 			<section class="interest-group-section">
36
-				<strong class="interest-group-section-title"><?php echo ucwords( $interest_group['title'] ); ?></strong>
36
+				<strong class="interest-group-section-title"><?php echo ucwords( $interest_group[ 'title' ] ); ?></strong>
37 37
 			<?php
38 38
 
39 39
 			/*
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
 							<input type="checkbox"
56 56
 								name="optin-checkbox-init[<?php echo $integration_type; ?>][interest-groups][<?php echo $list_id; ?>][<?php echo $id; ?>][]"
57 57
 								value="<?php echo $field_id; ?>" <?php echo $checked; ?>>
58
-							<?php echo $field['name']; ?>
58
+							<?php echo $field[ 'name' ]; ?>
59 59
 						</label>
60 60
 						<?php
61 61
 					}
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
 							<input type="radio"
72 72
 								name="optin-checkbox-init[<?php echo $integration_type; ?>][interest-groups][<?php echo $list_id; ?>][<?php echo $id; ?>][]"
73 73
 								value="<?php echo $field_id; ?>" <?php echo $checked; ?>>
74
-							<?php echo $field['name']; ?>
74
+							<?php echo $field[ 'name' ]; ?>
75 75
 						</label>
76 76
 						<?php
77 77
 					}
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
 							}
90 90
 						?>
91 91
 							<option value="<?php echo $field_id; ?>" <?php echo $selected; ?>>
92
-								<?php echo $field['name']; ?>
92
+								<?php echo $field[ 'name' ]; ?>
93 93
 							</option>
94 94
 						<?php
95 95
 						}
Please login to merge, or discard this patch.
public/partials/shortcodes/unsubscribe/process-unsubscribe.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -22,13 +22,13 @@
 block discarded – undo
22 22
 		}
23 23
 
24 24
 		// Verify Honeypot
25
-		if ( ! empty( $_POST['hp'] ) ) {
25
+		if ( ! empty( $_POST[ 'hp' ] ) ) {
26 26
 			wp_send_json_error( '2' );
27 27
 		}
28 28
 
29 29
 		// Get email, list ID
30
-		$email   = isset( $_POST['email'] ) ? $_POST['email'] : '';
31
-		$list_id = isset( $_POST['list_id'] ) ? $_POST['list_id'] : '';
30
+		$email   = isset( $_POST[ 'email' ] ) ? $_POST[ 'email' ] : '';
31
+		$list_id = isset( $_POST[ 'list_id' ] ) ? $_POST[ 'list_id' ] : '';
32 32
 
33 33
 		if ( empty( $email ) || empty( $list_id ) ) {
34 34
 			wp_send_json_error( '3' );
Please login to merge, or discard this patch.
public/partials/shortcodes/unsubscribe/shortcode-unsubscribe.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -14,20 +14,20 @@  discard block
 block discarded – undo
14 14
 
15 15
 	$values = is_array( $args ) ? array_merge( $defaults, $args ) : $defaults;
16 16
 
17
-	if ( empty( $values['list'] ) && empty( $values['form'] ) ) {
17
+	if ( empty( $values[ 'list' ] ) && empty( $values[ 'form' ] ) ) {
18 18
 		return '<!-- YIKES Easy Forms Error: no list ID / form ID -->';
19 19
 	}
20 20
 
21
-	if ( ! empty( $values['form'] ) ) {
21
+	if ( ! empty( $values[ 'form' ] ) ) {
22 22
 
23 23
 		// Get the list ID from the form ID
24 24
 		$interface = yikes_easy_mailchimp_extender_get_form_interface();
25
-		$form_data = $interface->get_form( $values['form'] );
26
-		$list_id   = isset( $form_data['list_id'] ) ? $form_data['list_id'] : null;
25
+		$form_data = $interface->get_form( $values[ 'form' ] );
26
+		$list_id   = isset( $form_data[ 'list_id' ] ) ? $form_data[ 'list_id' ] : null;
27 27
 
28
-	} else if ( ! empty( $values['list'] ) ) {
28
+	} else if ( ! empty( $values[ 'list' ] ) ) {
29 29
 
30
-		$list_id = $values['list'];
30
+		$list_id = $values[ 'list' ];
31 31
 	}
32 32
 
33 33
 	if ( empty( $list_id ) ) {
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
 			'loader'   => apply_filters( 'yikes-mailchimp-unsubscribe-loader', YIKES_MC_URL . 'includes/images/ripple.svg' ),
46 46
 		) 
47 47
 	);
48
-	wp_enqueue_script ( 'yikes-mailchimp-unsubscribe-script' );
48
+	wp_enqueue_script( 'yikes-mailchimp-unsubscribe-script' );
49 49
 
50 50
 	// Include our styles
51 51
 	wp_enqueue_style( 'yikes-mailchimp-unsubscribe-styles', plugin_dir_url( __FILE__ ) . '/unsubscribe.css', array(), YIKES_MC_VERSION, 'all' );
@@ -55,11 +55,11 @@  discard block
 block discarded – undo
55 55
 		<section id="yikes-mailchimp-unsubscribe-container-<?php echo $list_id; ?>" class="yikes-mailchimp-unsubscribe-container">
56 56
 
57 57
 			<div id="yikes-mailchimp-unsubscribe-title-<?php echo $list_id; ?>" class="yikes-mailchimp-unsubscribe-title">
58
-				<h2><?php echo apply_filters( 'yikes-mailchimp-unsubscribe-title', $values['title'] ); ?></h2>
58
+				<h2><?php echo apply_filters( 'yikes-mailchimp-unsubscribe-title', $values[ 'title' ] ); ?></h2>
59 59
 			</div>
60 60
 
61 61
 			<div id="yikes-mailchimp-unsubscribe-description-<?php echo $list_id; ?>" class="yikes-mailchimp-unsubscribe-description">
62
-				<?php echo apply_filters( 'yikes-mailchimp-unsubscribe-description', $values['description'] ); ?>
62
+				<?php echo apply_filters( 'yikes-mailchimp-unsubscribe-description', $values[ 'description' ] ); ?>
63 63
 			</div>
64 64
 
65 65
 			<?php do_action( 'yikes-mailchimp-unsubscribe-before-form' ); ?>
@@ -71,8 +71,8 @@  discard block
 block discarded – undo
71 71
 				<!-- Email -->
72 72
 				<?php do_action( 'yikes-mailchimp-unsubscribe-before-email' ); ?>
73 73
 				<label for="yikes-mailchimp-unsubscribe-email" class="EMAIL-label">
74
-					<span class="EMAIL-label"><?php echo $values['email_label']; ?></span>
75
-					<input name="EMAIL" placeholder="<?php echo $values['email_placeholder']; ?>" class="yikes-mailchimp-unsubscribe-email" id="yikes-mailchimp-unsubscribe-email" required="required" type="email" value="<?php echo esc_attr( apply_filters( 'yikes-mailchimp-unsubscribe-email-default', '' ) ); ?>">
74
+					<span class="EMAIL-label"><?php echo $values[ 'email_label' ]; ?></span>
75
+					<input name="EMAIL" placeholder="<?php echo $values[ 'email_placeholder' ]; ?>" class="yikes-mailchimp-unsubscribe-email" id="yikes-mailchimp-unsubscribe-email" required="required" type="email" value="<?php echo esc_attr( apply_filters( 'yikes-mailchimp-unsubscribe-email-default', '' ) ); ?>">
76 76
 				</label>
77 77
 				<?php do_action( 'yikes-mailchimp-unsubscribe-after-email' ); ?>
78 78
 
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
 
85 85
 				<!-- Submit Button -->
86 86
 				<button type="submit" class="yikes-mailchimp-unsubscribe-submit-button">
87
-					<span class="yikes-mailchimp-submit-button-span-text"><?php echo $values['submit_label']; ?></span>
87
+					<span class="yikes-mailchimp-submit-button-span-text"><?php echo $values[ 'submit_label' ]; ?></span>
88 88
 				</button>
89 89
 
90 90
 				<input type="hidden" class="yikes-mailchimp-unsubscribe-nonce" name="yikes-mailchimp-unsubscribe-nonce" value="<?php echo wp_create_nonce( 'yikes-mailchimp-unsubscribe' ); ?>">
Please login to merge, or discard this patch.
public/partials/shortcodes/process/process_form_submission.php 1 patch
Spacing   +40 added lines, -40 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@  discard block
 block discarded – undo
14 14
 $data = $_POST;
15 15
 
16 16
 // Confirm we have a form id to work with
17
-$form_id = ( isset( $data['yikes-mailchimp-submitted-form'] ) ) ? absint( $data['yikes-mailchimp-submitted-form'] ) : false;
17
+$form_id = ( isset( $data[ 'yikes-mailchimp-submitted-form' ] ) ) ? absint( $data[ 'yikes-mailchimp-submitted-form' ] ) : false;
18 18
 
19 19
 // Set the form id in our class
20 20
 $submission_handler->set_form_id( $form_id );
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
 }
29 29
 
30 30
 // Check our nonce
31
-if ( $submission_handler->handle_nonce( $_POST['yikes_easy_mc_new_subscriber'], 'yikes_easy_mc_form_submit' ) === false ) {
31
+if ( $submission_handler->handle_nonce( $_POST[ 'yikes_easy_mc_new_subscriber' ], 'yikes_easy_mc_form_submit' ) === false ) {
32 32
 	$process_submission_response = $submission_handler->wrap_form_submission_response( $submission_handler->handle_nonce_message, $is_success = false );
33 33
 	return;
34 34
 }
@@ -44,10 +44,10 @@  discard block
 block discarded – undo
44 44
 }
45 45
 
46 46
 // Set up some variables from the form data -- these are required
47
-$list_id             = isset( $form_data['list_id'] ) ? $form_data['list_id'] : null;
48
-$submission_settings = isset( $form_data['submission_settings'] ) ? $form_data['submission_settings'] : null;
49
-$optin_settings      = isset( $form_data['optin_settings'] ) ? $form_data['optin_settings'] : null;
50
-$form_fields         = isset( $form_data['fields'] ) ? $form_data['fields'] : null;
47
+$list_id             = isset( $form_data[ 'list_id' ] ) ? $form_data[ 'list_id' ] : null;
48
+$submission_settings = isset( $form_data[ 'submission_settings' ] ) ? $form_data[ 'submission_settings' ] : null;
49
+$optin_settings      = isset( $form_data[ 'optin_settings' ] ) ? $form_data[ 'optin_settings' ] : null;
50
+$form_fields         = isset( $form_data[ 'fields' ] ) ? $form_data[ 'fields' ] : null;
51 51
 
52 52
 // Send an error if for some reason we can't find the required form data
53 53
 if ( $submission_handler->handle_empty_fields_generic( array( $list_id, $submission_settings, $optin_settings, $form_fields ) ) === false ) {
@@ -70,8 +70,8 @@  discard block
 block discarded – undo
70 70
 $submission_handler->set_list_id( $list_id );
71 71
 
72 72
 // Set up some variables from the form data -- these are not required
73
-$error_messages      = isset( $form_data['error_messages'] ) ? $form_data['error_messages'] : array();
74
-$notifications       = isset( $form_data['custom_notifications'] ) ? $form_data['custom_notifications'] : array(); // Do we need this?
73
+$error_messages      = isset( $form_data[ 'error_messages' ] ) ? $form_data[ 'error_messages' ] : array();
74
+$notifications       = isset( $form_data[ 'custom_notifications' ] ) ? $form_data[ 'custom_notifications' ] : array(); // Do we need this?
75 75
 
76 76
 // Set the error messages in our class
77 77
 $submission_handler->set_error_messages( $error_messages );
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
 }
88 88
 
89 89
 // Get, sanitize, and lowercasify the email
90
-$submitted_email = isset( $data['EMAIL'] ) ? $data['EMAIL'] : '';
90
+$submitted_email = isset( $data[ 'EMAIL' ] ) ? $data[ 'EMAIL' ] : '';
91 91
 $sanitized_email = $submission_handler->get_sanitized_email( $submitted_email ); 
92 92
 $submission_handler->set_email( $sanitized_email );
93 93
 
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
 }
99 99
 
100 100
 // Check for Honeypot filled
101
-$honey_pot_filled = ( isset( $data['yikes-mailchimp-honeypot'] ) && '' !== $data['yikes-mailchimp-honeypot'] ) ? true : false;
101
+$honey_pot_filled = ( isset( $data[ 'yikes-mailchimp-honeypot' ] ) && '' !== $data[ 'yikes-mailchimp-honeypot' ] ) ? true : false;
102 102
 
103 103
 // Send an error if honey pot is not empty
104 104
 if ( $submission_handler->handle_non_empty_honeypot( $honey_pot_filled ) === false ) {
@@ -107,11 +107,11 @@  discard block
 block discarded – undo
107 107
 }
108 108
 
109 109
 // Check if reCAPTCHA Response was submitted with the form data, and handle it if needed
110
-if ( isset( $data['g-recaptcha-response'] ) ) {
111
-	$recaptcha_response = $data['g-recaptcha-response'];
110
+if ( isset( $data[ 'g-recaptcha-response' ] ) ) {
111
+	$recaptcha_response = $data[ 'g-recaptcha-response' ];
112 112
 	$recaptcha_handle = $submission_handler->handle_recaptcha( $recaptcha_response );
113
-	if ( isset( $recaptcha_handle['success'] ) && $recaptcha_handle['success'] === false ) {
114
-		$process_submission_response = $submission_handler->wrap_form_submission_response( $recaptcha_handle['message'], $is_success = false );
113
+	if ( isset( $recaptcha_handle[ 'success' ] ) && $recaptcha_handle[ 'success' ] === false ) {
114
+		$process_submission_response = $submission_handler->wrap_form_submission_response( $recaptcha_handle[ 'message' ], $is_success = false );
115 115
 		return;
116 116
 	}
117 117
 }
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
 $merge_variables = $submission_handler->get_submitted_merge_values( $data, $form_fields );
121 121
 
122 122
 // Submission Setting: Replace interest groups or update interest groups
123
-$replace_interests = isset( $submission_settings['replace_interests'] ) ? (bool) $submission_settings['replace_interests'] : true;
123
+$replace_interests = isset( $submission_settings[ 'replace_interests' ] ) ? (bool) $submission_settings[ 'replace_interests' ] : true;
124 124
 
125 125
 // Get the default groups
126 126
 $groups = $submission_handler->get_default_interest_groups( $replace_interests, $list_handler );
@@ -135,17 +135,17 @@  discard block
 block discarded – undo
135 135
  *
136 136
  * @param $merge_variables array Array of merge variable to use
137 137
  */
138
-do_action( 'yikes-mailchimp-before-submission',            $merge_variables );
138
+do_action( 'yikes-mailchimp-before-submission', $merge_variables );
139 139
 do_action( "yikes-mailchimp-before-submission-{$form_id}", $merge_variables );
140 140
 
141 141
 // Allow users to check for form values (using the `yikes-mailchimp-filter-before-submission` filter hook in function `get_submitted_merge_values`) 
142 142
 // and pass back an error and message to the user
143 143
 // If error is set and no message, default to our class variable's default error message
144
-if ( isset( $merge_variables['error'] ) ) {
145
-	$merge_error_message = isset( $merge_variables['message'] ) ? $merge_variables['message'] : $submission_handler->default_error_response_message;
146
-	$merge_vars_error_array = $submission_handler->handle_merge_variables_error( $merge_variables['error'], $merge_error_message );
147
-	if ( $merge_vars_error_array['success'] === false ) {
148
-		$process_submission_response = $submission_handler->wrap_form_submission_response( $merge_vars_error_array['message'], $is_success = false );
144
+if ( isset( $merge_variables[ 'error' ] ) ) {
145
+	$merge_error_message = isset( $merge_variables[ 'message' ] ) ? $merge_variables[ 'message' ] : $submission_handler->default_error_response_message;
146
+	$merge_vars_error_array = $submission_handler->handle_merge_variables_error( $merge_variables[ 'error' ], $merge_error_message );
147
+	if ( $merge_vars_error_array[ 'success' ] === false ) {
148
+		$process_submission_response = $submission_handler->wrap_form_submission_response( $merge_vars_error_array[ 'message' ], $is_success = false );
149 149
 		return;
150 150
 	}
151 151
 }
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
 
160 160
 // Only add groups if they exist
161 161
 if ( ! empty( $groups ) ) {
162
-	$member_data['interests'] = $groups;
162
+	$member_data[ 'interests' ] = $groups;
163 163
 }
164 164
 
165 165
 // Check if this member already exists
@@ -169,30 +169,30 @@  discard block
 block discarded – undo
169 169
 // Likewise, if this member exists but their status is 'pending' it means we're dealing with a double opt-in list and they never confirmed
170 170
 // Or, if this member but their status is 'unsubscribed' it means we're dealing with someone who unsubscribed and they need to re-subscribe
171 171
 // Continue as if they're a new member to force another double opt-in email
172
-$double_optin_resubscribe = is_array( $member_exists ) && isset( $member_exists['status'] ) && ( $member_exists['status'] === 'pending' || $member_exists['status'] === 'unsubscribed' );
172
+$double_optin_resubscribe = is_array( $member_exists ) && isset( $member_exists[ 'status' ] ) && ( $member_exists[ 'status' ] === 'pending' || $member_exists[ 'status' ] === 'unsubscribed' );
173 173
 
174 174
 if ( is_wp_error( $member_exists ) || $double_optin_resubscribe === true ) {
175 175
 	$new_subscriber = true;
176 176
 
177 177
 	// Check the opt-in value - is it double or single?
178 178
 	// Double opt-in means 'status_if_new' => 'pending'
179
-	$double_optin = isset( $optin_settings['optin'] ) ? (int) $optin_settings['optin'] : 0;
179
+	$double_optin = isset( $optin_settings[ 'optin' ] ) ? (int) $optin_settings[ 'optin' ] : 0;
180 180
 
181 181
 	// If the user was unsubscribed and is re-subscribing, we set the status to 'pending', which
182 182
 	// causes Mailchimp to send them a confirmation email.  This is the only way Mailchimp will
183 183
 	// allow us to re-subscribe the user.
184
-	$was_unsubscribed = is_array( $member_exists ) && isset( $member_exists['status'] ) && $member_exists['status'] === 'unsubscribed';
184
+	$was_unsubscribed = is_array( $member_exists ) && isset( $member_exists[ 'status' ] ) && $member_exists[ 'status' ] === 'unsubscribed';
185 185
 
186 186
 	if ( $double_optin === 1 || $was_unsubscribed === true ) {
187 187
 
188 188
 		// Double opt-in
189
-		$member_data['status_if_new'] = 'pending';
190
-		$member_data['status']        = 'pending';
189
+		$member_data[ 'status_if_new' ] = 'pending';
190
+		$member_data[ 'status' ]        = 'pending';
191 191
 	} else {
192 192
 
193 193
 		// Single opt-in
194
-		$member_data['status_if_new'] = 'subscribed';
195
-		$member_data['status']        = 'subscribed';
194
+		$member_data[ 'status_if_new' ] = 'subscribed';
195
+		$member_data[ 'status' ]        = 'subscribed';
196 196
 	}
197 197
 
198 198
 } else {
@@ -201,28 +201,28 @@  discard block
 block discarded – undo
201 201
 
202 202
 	// But first let's set our flag, and set the MailChimp status flag
203 203
 	$new_subscriber = false;
204
-	$member_data['status'] = 'subscribed';
204
+	$member_data[ 'status' ] = 'subscribed';
205 205
 
206 206
 	// Check our update_existing_user optin setting
207
-	$update_existing_user = ( $optin_settings['update_existing_user'] === '1' ) ? true : false;
207
+	$update_existing_user = ( $optin_settings[ 'update_existing_user' ] === '1' ) ? true : false;
208 208
 
209 209
 	// If update_existing_user is false (not allowed) then simply fail and return a response message
210 210
 	if ( $update_existing_user === false ) {
211 211
 		$disallow_update_array = $submission_handler->handle_disallowed_existing_user_update();
212
-		if ( $disallow_update_array['success'] === false ) {
213
-			$process_submission_response = $submission_handler->wrap_form_submission_response( $disallow_update_array['message'], $is_success = false );
212
+		if ( $disallow_update_array[ 'success' ] === false ) {
213
+			$process_submission_response = $submission_handler->wrap_form_submission_response( $disallow_update_array[ 'message' ], $is_success = false );
214 214
 			return;
215 215
 		}
216 216
 	}
217 217
 
218 218
 	// If update_existing_user is true, we need to check our 'send_update_email' option
219
-	$send_update_email = ( $optin_settings['send_update_email'] === '1' ) ? true : false;
219
+	$send_update_email = ( $optin_settings[ 'send_update_email' ] === '1' ) ? true : false;
220 220
 
221 221
 	// If $send_update_email is true (we send the email) then we need to fire off the 'send update email' logic
222 222
 	if ( $send_update_email === true ) {
223 223
 		$update_existing_user_array = $submission_handler->handle_updating_existing_user();
224
-		if ( $update_existing_user_array['success'] === false ) {
225
-			$process_submission_response = $submission_handler->wrap_form_submission_response( $update_existing_user_array['message'], $is_success = false );
224
+		if ( $update_existing_user_array[ 'success' ] === false ) {
225
+			$process_submission_response = $submission_handler->wrap_form_submission_response( $update_existing_user_array[ 'message' ], $is_success = false );
226 226
 			return;
227 227
 		}
228 228
 	}
@@ -254,9 +254,9 @@  discard block
 block discarded – undo
254 254
 }
255 255
 
256 256
 // Handle errors in the response
257
-if ( isset( $success_array ) && isset( $success_array['success'] ) && $success_array['success'] === false ) {
258
-	$process_submission_response = isset( $success_array['message'] ) ? $success_array['message'] : '';
259
-	$process_submission_response = $submission_handler->wrap_form_submission_response( $success_array['message'], $is_success = false );
257
+if ( isset( $success_array ) && isset( $success_array[ 'success' ] ) && $success_array[ 'success' ] === false ) {
258
+	$process_submission_response = isset( $success_array[ 'message' ] ) ? $success_array[ 'message' ] : '';
259
+	$process_submission_response = $submission_handler->wrap_form_submission_response( $success_array[ 'message' ], $is_success = false );
260 260
 	return;
261 261
 }
262 262
 
@@ -266,7 +266,7 @@  discard block
 block discarded – undo
266 266
 // For non-AJAX submissions, if we have a new subscriber we need to increment our submissions count by 1
267 267
 // For AJAX, this is an AJAX call that gets fired off after form submission
268 268
 if ( $new_subscriber === true ) {
269
-	$submissions = (int) $form_settings['submissions'] + 1;	
269
+	$submissions = (int) $form_settings[ 'submissions' ] + 1;	
270 270
 	$interface->update_form_field( $form_id, 'submissions', $submissions );
271 271
 }
272 272
 
Please login to merge, or discard this patch.
public/partials/shortcodes/process/process_form_submission_ajax.php 1 patch
Spacing   +31 added lines, -31 removed lines patch added patch discarded remove patch
@@ -8,10 +8,10 @@  discard block
 block discarded – undo
8 8
 $submission_handler = new Yikes_Inc_Easy_MailChimp_Extender_Process_Submission_Handler( $is_ajax = true );
9 9
 
10 10
 // parse our form data
11
-parse_str( $_POST['form_data'], $data );
11
+parse_str( $_POST[ 'form_data' ], $data );
12 12
 
13 13
 // Get the form_id
14
-$form_id   = absint( $_POST['form_id'] );
14
+$form_id = absint( $_POST[ 'form_id' ] );
15 15
 
16 16
 // Send an error if for some reason we can't find the $form_id
17 17
 $submission_handler->handle_empty_form_id( $form_id );
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
 $submission_handler->set_form_id( $form_id ); 
21 21
 
22 22
 // Check our nonce
23
-$submission_handler->handle_nonce( $_POST['ajax_security_nonce'], 'yikes_mc_form_submission_security_nonce' );
23
+$submission_handler->handle_nonce( $_POST[ 'ajax_security_nonce' ], 'yikes_mc_form_submission_security_nonce' );
24 24
 
25 25
 // Get the form data
26 26
 $interface = yikes_easy_mailchimp_extender_get_form_interface();
@@ -30,10 +30,10 @@  discard block
 block discarded – undo
30 30
 $submission_handler->handle_empty_form( $form_data ); 
31 31
 
32 32
 // Set up some variables from the form data -- these are required
33
-$list_id             = isset( $form_data['list_id'] ) ? $form_data['list_id'] : null;
34
-$submission_settings = isset( $form_data['submission_settings'] ) ? $form_data['submission_settings'] : null;
35
-$optin_settings      = isset( $form_data['optin_settings'] ) ? $form_data['optin_settings'] : null;
36
-$form_fields         = isset( $form_data['fields'] ) ? $form_data['fields'] : null;
33
+$list_id             = isset( $form_data[ 'list_id' ] ) ? $form_data[ 'list_id' ] : null;
34
+$submission_settings = isset( $form_data[ 'submission_settings' ] ) ? $form_data[ 'submission_settings' ] : null;
35
+$optin_settings      = isset( $form_data[ 'optin_settings' ] ) ? $form_data[ 'optin_settings' ] : null;
36
+$form_fields         = isset( $form_data[ 'fields' ] ) ? $form_data[ 'fields' ] : null;
37 37
 
38 38
 // Send an error if for some reason we can't find the required form data
39 39
 $submission_handler->handle_empty_fields_generic( array( $list_id, $submission_settings, $optin_settings, $form_fields ) );
@@ -47,14 +47,14 @@  discard block
 block discarded – undo
47 47
 $submission_handler->check_for_required_interest_groups( $data, $form_fields );
48 48
 
49 49
 // Set up some variables from the form data -- these are not required
50
-$error_messages      = isset( $form_data['error_messages'] ) ? $form_data['error_messages'] : array();
51
-$notifications       = isset( $form_data['custom_notifications'] ) ? $form_data['custom_notifications'] : array();
50
+$error_messages      = isset( $form_data[ 'error_messages' ] ) ? $form_data[ 'error_messages' ] : array();
51
+$notifications       = isset( $form_data[ 'custom_notifications' ] ) ? $form_data[ 'custom_notifications' ] : array();
52 52
 
53 53
 // Set the error messages in our class
54 54
 $submission_handler->set_error_messages( $error_messages );
55 55
 
56 56
 // Some other variables we'll need.
57
-$page_data       = isset( $_POST['page_data'] ) ? $_POST['page_data'] : '';
57
+$page_data       = isset( $_POST[ 'page_data' ] ) ? $_POST[ 'page_data' ] : '';
58 58
 $merge_variables = array();
59 59
 $error           = 0;
60 60
 $list_handler    = yikes_get_mc_api_manager()->get_list_handler();
@@ -62,13 +62,13 @@  discard block
 block discarded – undo
62 62
 // As of 6.4 we no longer pass the post object, only the ID.
63 63
 // For any users relying on the $post object for their `yikes-mailchimp-redirect-url` filter we'll grab the post object here.
64 64
 // Eventually we should just pass the $post_id into the filter instead of the whole object.
65
-$page_data       = ! empty( $page_data ) ? get_post( $page_data ) : '';
65
+$page_data = ! empty( $page_data ) ? get_post( $page_data ) : '';
66 66
 
67 67
 // Send an error if for some reason we can't find the list_handler
68 68
 $submission_handler->handle_empty_list_handler( $list_handler ); 
69 69
 
70 70
 // Get, sanitize and lowercasify the email
71
-$submitted_email = isset( $data['EMAIL'] ) ? $data['EMAIL'] : '';
71
+$submitted_email = isset( $data[ 'EMAIL' ] ) ? $data[ 'EMAIL' ] : '';
72 72
 $sanitized_email = $submission_handler->get_sanitized_email( $submitted_email ); 
73 73
 $submission_handler->set_email( $sanitized_email );
74 74
 
@@ -76,14 +76,14 @@  discard block
 block discarded – undo
76 76
 $submission_handler->handle_empty_email( $sanitized_email );
77 77
 
78 78
 // Check for Honeypot filled
79
-$honey_pot_filled = ( isset( $data['yikes-mailchimp-honeypot'] ) && '' !== $data['yikes-mailchimp-honeypot'] ) ? true : false;
79
+$honey_pot_filled = ( isset( $data[ 'yikes-mailchimp-honeypot' ] ) && '' !== $data[ 'yikes-mailchimp-honeypot' ] ) ? true : false;
80 80
 
81 81
 // Send an error if honey pot is not empty
82 82
 $submission_handler->handle_non_empty_honeypot( $honey_pot_filled ); 
83 83
 
84 84
 // Check if reCAPTCHA Response was submitted with the form data, and handle it if needed
85
-if ( isset( $data['g-recaptcha-response'] ) ) {
86
-	$recaptcha_response = $data['g-recaptcha-response'];
85
+if ( isset( $data[ 'g-recaptcha-response' ] ) ) {
86
+	$recaptcha_response = $data[ 'g-recaptcha-response' ];
87 87
 	$submission_handler->handle_recaptcha( $recaptcha_response );
88 88
 }
89 89
 
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
 $merge_variables = $submission_handler->get_submitted_merge_values( $data, $form_fields );
92 92
 
93 93
 // Submission Setting: Replace interest groups or update interest groups
94
-$replace_interests = isset( $submission_settings['replace_interests'] ) ? (bool) $submission_settings['replace_interests'] : true;
94
+$replace_interests = isset( $submission_settings[ 'replace_interests' ] ) ? (bool) $submission_settings[ 'replace_interests' ] : true;
95 95
 
96 96
 // Get the default groups
97 97
 $groups = $submission_handler->get_default_interest_groups( $replace_interests, $list_handler );
@@ -106,15 +106,15 @@  discard block
 block discarded – undo
106 106
  *
107 107
  * @param $merge_variables array Array of merge variable to use
108 108
  */
109
-do_action( 'yikes-mailchimp-before-submission',            $merge_variables );
109
+do_action( 'yikes-mailchimp-before-submission', $merge_variables );
110 110
 do_action( "yikes-mailchimp-before-submission-{$form_id}", $merge_variables );
111 111
 
112 112
 // Allow users to check for form values (using the `yikes-mailchimp-filter-before-submission` filter hook in function `get_submitted_merge_values`) 
113 113
 // and pass back an error and message to the user
114 114
 // If error is set and no message, default to our class variable's default error message
115
-if ( isset( $merge_variables['error'] ) ) {
116
-	$merge_error_message = isset( $merge_variables['message'] ) ? $merge_variables['message'] : $submission_handler->default_error_response_message;
117
-	$submission_handler->handle_merge_variables_error( $merge_variables['error'], $merge_error_message );
115
+if ( isset( $merge_variables[ 'error' ] ) ) {
116
+	$merge_error_message = isset( $merge_variables[ 'message' ] ) ? $merge_variables[ 'message' ] : $submission_handler->default_error_response_message;
117
+	$submission_handler->handle_merge_variables_error( $merge_variables[ 'error' ], $merge_error_message );
118 118
 }
119 119
 
120 120
 // This is the array we're going to pass through to the MailChimp API
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
 
127 127
 // Only add groups if they exist
128 128
 if ( ! empty( $groups ) ) {
129
-	$member_data['interests'] = $groups;
129
+	$member_data[ 'interests' ] = $groups;
130 130
 }
131 131
 
132 132
 // Check if this member already exists
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
 // Likewise, if this member exists but their status is 'pending' it means we're dealing with a double opt-in list and they never confirmed
137 137
 // Or, if this member but their status is 'unsubscribed' it means we're dealing with someone who unsubscribed and they need to re-subscribe
138 138
 // Continue as if they're a new member to force another double opt-in email
139
-$double_optin_resubscribe = is_array( $member_exists ) && isset( $member_exists['status'] ) && ( $member_exists['status'] === 'pending' || $member_exists['status'] === 'unsubscribed' );
139
+$double_optin_resubscribe = is_array( $member_exists ) && isset( $member_exists[ 'status' ] ) && ( $member_exists[ 'status' ] === 'pending' || $member_exists[ 'status' ] === 'unsubscribed' );
140 140
 
141 141
 if ( is_wp_error( $member_exists ) || $double_optin_resubscribe === true ) {
142 142
 
@@ -144,23 +144,23 @@  discard block
 block discarded – undo
144 144
 
145 145
 	// Check the opt-in value - is it double or single?
146 146
 	// Double opt-in means 'status_if_new' => 'pending'
147
-	$double_optin = isset( $optin_settings['optin'] ) ? (int) $optin_settings['optin'] : 0;
147
+	$double_optin = isset( $optin_settings[ 'optin' ] ) ? (int) $optin_settings[ 'optin' ] : 0;
148 148
 
149 149
 	// If the user was unsubscribed and is re-subscribing, we set the status to 'pending', which
150 150
 	// causes Mailchimp to send them a confirmation email.  This is the only way Mailchimp will
151 151
 	// allow us to re-subscribe the user.
152
-	$was_unsubscribed = is_array( $member_exists ) && isset( $member_exists['status'] ) && $member_exists['status'] === 'unsubscribed';
152
+	$was_unsubscribed = is_array( $member_exists ) && isset( $member_exists[ 'status' ] ) && $member_exists[ 'status' ] === 'unsubscribed';
153 153
 
154 154
 	if ( $double_optin === 1 || $was_unsubscribed === true ) {
155 155
 
156 156
 		// Double opt-in
157
-		$member_data['status_if_new'] = 'pending';
158
-		$member_data['status']        = 'pending';
157
+		$member_data[ 'status_if_new' ] = 'pending';
158
+		$member_data[ 'status' ]        = 'pending';
159 159
 	} else {
160 160
 
161 161
 		// Single opt-in
162
-		$member_data['status_if_new'] = 'subscribed';
163
-		$member_data['status']        = 'subscribed';
162
+		$member_data[ 'status_if_new' ] = 'subscribed';
163
+		$member_data[ 'status' ]        = 'subscribed';
164 164
 	}
165 165
 	
166 166
 } else {
@@ -169,10 +169,10 @@  discard block
 block discarded – undo
169 169
 
170 170
 	// But first let's set our flag, and set the MailChimp status flag
171 171
 	$new_subscriber = false;
172
-	$member_data['status'] = 'subscribed';
172
+	$member_data[ 'status' ] = 'subscribed';
173 173
 
174 174
 	// Check our update_existing_user optin setting
175
-	$update_existing_user = ( $optin_settings['update_existing_user'] === '1' ) ? true : false;
175
+	$update_existing_user = ( $optin_settings[ 'update_existing_user' ] === '1' ) ? true : false;
176 176
 
177 177
 	// If update_existing_user is false (not allowed) then simply fail and return a response message
178 178
 	if ( $update_existing_user === false ) {
@@ -180,7 +180,7 @@  discard block
 block discarded – undo
180 180
 	}
181 181
 
182 182
 	// If update_existing_user is true, we need to check our 'send_update_email' option
183
-	$send_update_email = ( $optin_settings['send_update_email'] === '1' ) ? true : false;
183
+	$send_update_email = ( $optin_settings[ 'send_update_email' ] === '1' ) ? true : false;
184 184
 
185 185
 	// If $send_update_email is true (we send the email) then we need to fire off the 'send update email' logic
186 186
 	if ( $send_update_email === true ) {
Please login to merge, or discard this patch.
admin/partials/menu/options-sections/recaptcha-settings.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@
 block discarded – undo
29 29
 		<?php settings_fields( 'yikes_inc_easy_mc_recaptcha_settings_page' ); ?>
30 30
 
31 31
 			<label for="yikes-mc-recaptcha-setting">
32
-				<input type="checkbox" id="yikes-mc-recaptcha-setting" name="yikes-mc-recaptcha-status" class="recaptcha-setting-checkbox" value="1" <?php checked( get_option( 'yikes-mc-recaptcha-status', '' ) , '1' ); ?>>
32
+				<input type="checkbox" id="yikes-mc-recaptcha-setting" name="yikes-mc-recaptcha-status" class="recaptcha-setting-checkbox" value="1" <?php checked( get_option( 'yikes-mc-recaptcha-status', '' ), '1' ); ?>>
33 33
 				<strong><?php _e( 'Enable reCAPTCHA Protection', 'yikes-inc-easy-mailchimp-extender' ); ?></strong>
34 34
 			</label>
35 35
 
Please login to merge, or discard this patch.
classes/checkbox-integrations/class.woocommerce_checkout_form-checkbox.php 2 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -64,13 +64,13 @@  discard block
 block discarded – undo
64 64
 		$checkbox_options = get_option( 'optin-checkbox-init', array() );
65 65
 
66 66
 		// Only display the field if a list is set.
67
-		if ( isset( $checkbox_options[ $this->type ] ) && isset( $checkbox_options[ $this->type ]['associated-list'] ) && '-' !== $checkbox_options[ $this->type ]['associated-list'] ) {
67
+		if ( isset( $checkbox_options[ $this->type ] ) && isset( $checkbox_options[ $this->type ][ 'associated-list' ] ) && '-' !== $checkbox_options[ $this->type ][ 'associated-list' ] ) {
68 68
 
69 69
 			if ( $this->is_user_already_subscribed( $this->type ) ) {
70 70
 				return $fields;
71 71
 			}
72 72
 
73
-			$precheck = isset( $checkbox_options[ $this->type ]['precheck'] ) && 'true' === $checkbox_options[ $this->type ]['precheck'] ? '1' : '0';
73
+			$precheck = isset( $checkbox_options[ $this->type ][ 'precheck' ] ) && 'true' === $checkbox_options[ $this->type ][ 'precheck' ] ? '1' : '0';
74 74
 
75 75
 			/**
76 76
 			* Filter where the checkbox goes.
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
 				'id'      => 'yikes_mailchimp_checkbox_' . $this->type,
86 86
 				'type'    => 'checkbox',
87 87
 				'class'   => apply_filters( 'yikes-mailchimp-wooco-integration-checkbox-classes', array( 'form-row-wide' ) ),
88
-				'label'   => $checkbox_options[ $this->type ]['label'],
88
+				'label'   => $checkbox_options[ $this->type ][ 'label' ],
89 89
 				'default' => $precheck,
90 90
 			);
91 91
 
Please login to merge, or discard this patch.
Indentation   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -72,12 +72,12 @@  discard block
 block discarded – undo
72 72
 			$precheck = isset( $checkbox_options[ $this->type ]['precheck'] ) && 'true' === $checkbox_options[ $this->type ]['precheck'] ? '1' : '0';
73 73
 
74 74
 			/**
75
-			* Filter where the checkbox goes.
76
-			*
77
-			* See this WooCo article for possible values: https://docs.woocommerce.com/document/tutorial-customising-checkout-fields-using-actions-and-filters/
78
-			*
79
-			* @param string | Which set of fields the checkbox should go into
80
-			*/
75
+			 * Filter where the checkbox goes.
76
+			 *
77
+			 * See this WooCo article for possible values: https://docs.woocommerce.com/document/tutorial-customising-checkout-fields-using-actions-and-filters/
78
+			 *
79
+			 * @param string | Which set of fields the checkbox should go into
80
+			 */
81 81
 			$field_placement = apply_filters( 'yikes-mailchimp-wooco-integration-checkbox-placement', 'billing' );
82 82
 
83 83
 			$yikes_checkbox = array(
@@ -89,13 +89,13 @@  discard block
 block discarded – undo
89 89
 			);
90 90
 
91 91
 			/**
92
-			* Filter the checkbox data.
93
-			*
94
-			* See this WooCo article for possible values: https://docs.woocommerce.com/document/tutorial-customising-checkout-fields-using-actions-and-filters/
95
-			*
96
-			* @param  array $yikes_checkbox The checkbox's fields.
97
-			* @return array $yikes_checkbox The checkbox's fields.
98
-			*/
92
+			 * Filter the checkbox data.
93
+			 *
94
+			 * See this WooCo article for possible values: https://docs.woocommerce.com/document/tutorial-customising-checkout-fields-using-actions-and-filters/
95
+			 *
96
+			 * @param  array $yikes_checkbox The checkbox's fields.
97
+			 * @return array $yikes_checkbox The checkbox's fields.
98
+			 */
99 99
 			$yikes_checkbox = apply_filters( 'yikes_mailchimp_wooco_integration_checkbox_field', $yikes_checkbox, $checkbox_options[ $this->type ] );
100 100
 
101 101
 			$fields[ $field_placement ][ 'yikes_mailchimp_checkbox_' . $this->type ] = $yikes_checkbox;
Please login to merge, or discard this patch.
class.easy_digital_downloads_checkout_form-checkbox.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -80,11 +80,11 @@
 block discarded – undo
80 80
 
81 81
 		$user_info  = (array) edd_get_payment_meta_user_info( $payment_id );
82 82
 		$merge_vars = array();
83
-		if ( isset( $user_info['first_name'] ) ) {
84
-			$merge_vars['FNAME'] = $user_info['first_name'];
83
+		if ( isset( $user_info[ 'first_name' ] ) ) {
84
+			$merge_vars[ 'FNAME' ] = $user_info[ 'first_name' ];
85 85
 		}
86
-		if ( isset( $user_info['last_name'] ) ) {
87
-			$merge_vars['LNAME'] = $user_info['last_name'];
86
+		if ( isset( $user_info[ 'last_name' ] ) ) {
87
+			$merge_vars[ 'LNAME' ] = $user_info[ 'last_name' ];
88 88
 		}
89 89
 
90 90
 		// Subscribe the user.
Please login to merge, or discard this patch.
public/classes/checkbox-integrations/class.comment_form-checkbox.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -75,12 +75,12 @@
 block discarded – undo
75 75
 
76 76
 		// Create merge variables based on comment data.
77 77
 		$merge_vars = array(
78
-			'FNAME'    => $comment_data['comment_author'],
79
-			'OPTIN_IP' => $comment_data['comment_author_IP'],
78
+			'FNAME'    => $comment_data[ 'comment_author' ],
79
+			'OPTIN_IP' => $comment_data[ 'comment_author_IP' ],
80 80
 		);
81 81
 
82 82
 		// Subscribe the user.
83
-		$this->subscribe_user_integration( $comment_data['comment_author_email'], $this->type, $merge_vars );
83
+		$this->subscribe_user_integration( $comment_data[ 'comment_author_email' ], $this->type, $merge_vars );
84 84
 	}
85 85
 }
86 86
 $yikes_easy_mc_comment_checkbox_class = new Yikes_Easy_MC_Comment_Checkbox_Class();
Please login to merge, or discard this patch.