FormHelper - Code Metrics - Inspection of "7.0.0" - yikesinc/yikes-inc-easy-mailchimp-extender - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — staging (#840)

unknown

created 2019-12-11 22:23 UTC

FormHelper A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	80
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	0

Importance

Changes

Metric	Value
dl	0
loc	80
rs	10
c	0
b	0
f	0
wmc	19
lcom	2
cbo	0

7 Methods

Rating	Name	Size	Complexity
A	form_title()	17	3
A	form_description()	17	3
A	reduce_field_count()	3	1
A	set_field_count()	3	2
A	form_classes()	18	5
A	inline_form_override()	3	3
A	edit_form_link()	11	2

<?php

namespace YIKES\EasyForms\Form;

trait FormHelper {
    public function form_title( $title, $custom_title, $form_name ) {
        if ( $title ) {
			if ( ! empty( $custom_title ) ) {
				/**
				 * Filter the title that is displayed through the shortcode.
				 *
				 * @param string $title   The title to display.
				 * @param int    $form_id The form ID.
				 */
				return apply_filters( 'yikes-mailchimp-form-title', apply_filters( 'the_title', $custom_title ), $this->form_id );
class MyClass { }

$x = new MyClass();
$x->foo = true;
			} else {
			    return apply_filters( 'yikes-mailchimp-form-title', apply_filters( 'the_title', $form_name ), $this->form_id );
			}
        }
        
        return false;
    }

    public function form_description( $description, $custom_description ) {
        if ( $description ) {
			if ( ! empty( $custom_description ) ) {
				/**
				 * Filter the description that is displayed through the shortcode.
				 *
				 * @param string $title   The title to display.
				 * @param int    $form_id The form ID.
				 */
				return apply_filters( 'yikes-mailchimp-form-description', $custom_description, $this->form_id );
			} else {
				return apply_filters( 'yikes-mailchimp-form-description', $this->form_data['form_description'], $this->form_id );
class MyClass { }

$x = new MyClass();
$x->foo = true;
			}
		} else {
            return false;
        }
    }

    protected function reduce_field_count() {
		$this->field_count = $this->field_count --;
class MyClass { }

$x = new MyClass();
$x->foo = true;
	}

	protected function set_field_count() {
		return isset( $this->form_data['fields'] ) ? count( $this->form_data['fields'] ) : 0;
	}

	public function form_classes( bool $is_submitted ) {
		$form_classes = $this->form_data['form_settings']['yikes-easy-mc-form-class-names'];
		$form_classes .= ' yikes-easy-mc-form yikes-easy-mc-form-' . $this->form_id;

        if ( isset( $this->form_inline ) && $this->form_inline != 0 ) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            $form_classes .= ' yikes-mailchimp-form-inline ';
        }

		$form_classes .= ' ';

		$form_classes = apply_filters( 'yikes-mailchimp-form-class', $form_classes, $this->form_id );

		if ( $is_submitted && $this->form_data['submission_settings']['hide_form_post_signup'] == 1 ) {
			$form_classes .= ' yikes-easy-mc-display-none';
		}

    	return $form_classes;
	}

	public function inline_form_override() {
		return isset( $this->has_recaptcha ) || ( function_exists( 'is_plugin_active' ) && is_plugin_active( 'eu-opt-in-compliance-for-mailchimp/yikes-inc-easy-mailchimp-eu-law-compliance-extension.php' ) );
	}
    
    public function edit_form_link() {
		if( current_user_can( apply_filters( 'yikes-mailchimp-user-role-access' , 'manage_options' ) ) ) {
			$edit_form_link = '<span class="edit-link">';
			$edit_form_link .= '<a class="post-edit-link" href="' . esc_url( admin_url( 'admin.php?page=yikes-mailchimp-edit-form&id=' . $this->form_id ) ) . '" title="' . __( 'Edit' , 'yikes-inc-easy-mailchimp-extender' ) . ' ' . ucwords( $this->form_data['form_name'] ) . '">' . __( 'Edit Form' , 'yikes-inc-easy-mailchimp-extender' ) . '</a>';
			$edit_form_link .= '</span>';
			$edit_form_link = apply_filters( 'yikes-mailchimp-front-end-form-action-links', $edit_form_link, $this->form_id, ucwords( $this->form_data['form_name'] ) );
		} else {
			$edit_form_link = '';
		}
		return $edit_form_link;
    }
}


1			<?php
2
3			namespace YIKES\EasyForms\Form;
4
5			trait FormHelper {
6			public function form_title( $title, $custom_title, $form_name ) {
7			if ( $title ) {
8			if ( ! empty( $custom_title ) ) {
9			/**
10			* Filter the title that is displayed through the shortcode.
11			*
12			* @param string $title The title to display.
13			* @param int $form_id The form ID.
14			*/
15			return apply_filters( 'yikes-mailchimp-form-title', apply_filters( 'the_title', $custom_title ), $this->form_id );
			0 ignored issues – show Bug introduced 2019-12-10 15:01 UTC by Report Bug Copy Issue Report The property `form_id` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
16			} else {
17			return apply_filters( 'yikes-mailchimp-form-title', apply_filters( 'the_title', $form_name ), $this->form_id );
18			}
19			}
20
21			return false;
22			}
23
24			public function form_description( $description, $custom_description ) {
25			if ( $description ) {
26			if ( ! empty( $custom_description ) ) {
27			/**
28			* Filter the description that is displayed through the shortcode.
29			*
30			* @param string $title The title to display.
31			* @param int $form_id The form ID.
32			*/
33			return apply_filters( 'yikes-mailchimp-form-description', $custom_description, $this->form_id );
34			} else {
35			return apply_filters( 'yikes-mailchimp-form-description', $this->form_data['form_description'], $this->form_id );
			0 ignored issues – show Bug introduced 2019-12-11 16:07 UTC by Report Bug Copy Issue Report The property `form_data` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
36			}
37			} else {
38			return false;
39			}
40			}
41
42			protected function reduce_field_count() {
43			$this->field_count = $this->field_count --;
			0 ignored issues – show Bug introduced 2019-12-10 15:01 UTC by Report Bug Copy Issue Report The property `field_count` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
44			}
45
46			protected function set_field_count() {
47			return isset( $this->form_data['fields'] ) ? count( $this->form_data['fields'] ) : 0;
48			}
49
50			public function form_classes( bool $is_submitted ) {
51			$form_classes = $this->form_data['form_settings']['yikes-easy-mc-form-class-names'];
52			$form_classes .= ' yikes-easy-mc-form yikes-easy-mc-form-' . $this->form_id;
53
54			if ( isset( $this->form_inline ) && $this->form_inline != 0 ) {
			0 ignored issues – show Bug introduced 2019-12-10 15:01 UTC by Report Bug Copy Issue Report The property `form_inline` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
55			$form_classes .= ' yikes-mailchimp-form-inline ';
56			}
57
58			$form_classes .= ' ';
59
60			$form_classes = apply_filters( 'yikes-mailchimp-form-class', $form_classes, $this->form_id );
61
62			if ( $is_submitted && $this->form_data['submission_settings']['hide_form_post_signup'] == 1 ) {
63			$form_classes .= ' yikes-easy-mc-display-none';
64			}
65
66			return $form_classes;
67			}
68
69			public function inline_form_override() {
70			return isset( $this->has_recaptcha ) \|\| ( function_exists( 'is_plugin_active' ) && is_plugin_active( 'eu-opt-in-compliance-for-mailchimp/yikes-inc-easy-mailchimp-eu-law-compliance-extension.php' ) );
71			}
72
73			public function edit_form_link() {
74			if( current_user_can( apply_filters( 'yikes-mailchimp-user-role-access' , 'manage_options' ) ) ) {
75			$edit_form_link = '<span class="edit-link">';
76			$edit_form_link .= '<a class="post-edit-link" href="' . esc_url( admin_url( 'admin.php?page=yikes-mailchimp-edit-form&id=' . $this->form_id ) ) . '" title="' . __( 'Edit' , 'yikes-inc-easy-mailchimp-extender' ) . ' ' . ucwords( $this->form_data['form_name'] ) . '">' . __( 'Edit Form' , 'yikes-inc-easy-mailchimp-extender' ) . '</a>';
77			$edit_form_link .= '</span>';
78			$edit_form_link = apply_filters( 'yikes-mailchimp-front-end-form-action-links', $edit_form_link, $this->form_id, ucwords( $this->form_data['form_name'] ) );
79			} else {
80			$edit_form_link = '';
81			}
82			return $edit_form_link;
83			}
84			}
85

yikesinc / yikes-inc-easy-mailchimp-extender

Pull Request — staging (#840)

FormHelper A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

7 Methods

Duplication Side-by-Side

Filter issues like