Issues in OnePayTest.php (master) - Issues in master - yiiviet/yii2-payment - Measure and Improve Code Quality continuously with Scrutinizer

Issues (42)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

tests/OnePayTest.php (2 issues)

Labels

Duplication 2

Severity

Informational 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * @link https://github.com/yiiviet/yii2-payment
 * @copyright Copyright (c) 2017 Yii2VN
 * @license [New BSD License](http://www.opensource.org/licenses/bsd-license.php)
 */

namespace yiiviet\tests\unit\payment;

/**
 * Class OnePayTest
 *
 * @author Vuong Minh <[email protected]>
 * @since 1.0
 */
class OnePayTest extends TestCase
{

    /**
     * @var \yiiviet\payment\onepay\PaymentGateway
     */
    public $gateway;

    public static function gatewayId(): string
    {
        return 'OP';
    }

    /**
     * @expectedException \yii\base\InvalidConfigException
     * @expectedExceptionMessage cannot be blank
     */
    public function testPurchase()

    {
        // Valid
        $responseData = $this->purchase([
            'ReturnURL' => 'http://localhost/',
            'OrderInfo' => time(),
            'Amount' => 500000,
            'TicketNo' => '127.0.0.1',
            'AgainLink' => 'http://localhost/',
            'Title' => 'Hello World',
            'MerchTxnRef' => time()
        ]);

        $this->assertTrue($responseData->getIsOk());
        $this->assertTrue(isset($responseData['redirect_url']));

        // Throws
        $this->purchase([
            'ReturnURL' => 'http://localhost/',
            'TicketNo' => '127.0.0.1',
            'AgainLink' => 'http://localhost/'
        ]);
    }

    /**
     * @expectedException \yii\base\InvalidConfigException
     * @expectedExceptionMessage cannot be blank
     */
    public function testPurchaseInternational()

    {
        // Valid
        $this->gateway->international = true;
        $responseData = $this->purchase([
            'ReturnURL' => 'http://localhost/',
            'OrderInfo' => time(),
            'Amount' => 500000,
            'TicketNo' => '127.0.0.1',
            'AgainLink' => 'http://localhost/',
            'Title' => 'Hello World',
            'MerchTxnRef' => time()
        ]);

        $this->assertTrue($responseData->getIsOk());
        $this->assertTrue(isset($responseData['redirect_url']));

        // Throws
        $this->purchase([
            'ReturnURL' => 'http://localhost/',
            'TicketNo' => '127.0.0.1',
            'AgainLink' => 'http://localhost/'
        ]);
    }

    /**
     * @expectedException \yii\base\InvalidConfigException
     * @expectedExceptionMessage cannot be blank
     */
    public function testQueryDR()
    {
        // Valid
        $responseData = $this->queryDR([
            'MerchTxnRef' => 1
        ]);

        $this->assertTrue($responseData->getIsOk());

        // Throws
        $this->queryDR([]);
    }

    /**
     * @expectedException \yii\base\InvalidConfigException
     * @expectedExceptionMessage cannot be blank
     */
    public function testQueryDRInternational()
    {
        // Valid
        $this->gateway->international = true;
        $responseData = $this->queryDR([
            'MerchTxnRef' => 1
        ]);

        $this->assertTrue($responseData->getIsOk());

        // Throws
        $this->queryDR([]);
    }

    public function testVerifyRequestPurchaseSuccess()
    {
        $result = $this->verifyRequestPurchaseSuccess();
        $this->assertFalse($result);
    }

    public function testVerifyRequestPurchaseInternationalSuccess()
    {
        $this->gateway->international = true;
        $result = $this->verifyRequestPurchaseSuccess();

        $this->assertFalse($result);
    }

    public function testVerifyRequestIPN()
    {
        $result = $this->verifyRequestIPN();

        $this->assertFalse($result);
    }

    public function testVerifyRequestIPNInternational()
    {
        $this->gateway->international = true;
        $result = $this->verifyRequestIPN();

        $this->assertFalse($result);
    }
}


1		<?php
2		/**
3		* @link https://github.com/yiiviet/yii2-payment
4		* @copyright Copyright (c) 2017 Yii2VN
5		* @license [New BSD License](http://www.opensource.org/licenses/bsd-license.php)
6		*/
7
8		namespace yiiviet\tests\unit\payment;
9
10		/**
11		* Class OnePayTest
12		*
13		* @author Vuong Minh <[email protected]>
14		* @since 1.0
15		*/
16		class OnePayTest extends TestCase
17		{
18
19		/**
20		* @var \yiiviet\payment\onepay\PaymentGateway
21		*/
22		public $gateway;
23
24		public static function gatewayId(): string
25		{
26		return 'OP';
27		}
28
29		/**
30		* @expectedException \yii\base\InvalidConfigException
31		* @expectedExceptionMessage cannot be blank
32		*/
33	View Code Duplication	public function testPurchase()
		0 ignored issues – show Duplication introduced 2018-05-10 10:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
34		{
35		// Valid
36		$responseData = $this->purchase([
37		'ReturnURL' => 'http://localhost/',
38		'OrderInfo' => time(),
39		'Amount' => 500000,
40		'TicketNo' => '127.0.0.1',
41		'AgainLink' => 'http://localhost/',
42		'Title' => 'Hello World',
43		'MerchTxnRef' => time()
44		]);
45
46		$this->assertTrue($responseData->getIsOk());
47		$this->assertTrue(isset($responseData['redirect_url']));
48
49		// Throws
50		$this->purchase([
51		'ReturnURL' => 'http://localhost/',
52		'TicketNo' => '127.0.0.1',
53		'AgainLink' => 'http://localhost/'
54		]);
55		}
56
57		/**
58		* @expectedException \yii\base\InvalidConfigException
59		* @expectedExceptionMessage cannot be blank
60		*/
61	View Code Duplication	public function testPurchaseInternational()
		0 ignored issues – show Duplication introduced 2018-05-10 10:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
62		{
63		// Valid
64		$this->gateway->international = true;
65		$responseData = $this->purchase([
66		'ReturnURL' => 'http://localhost/',
67		'OrderInfo' => time(),
68		'Amount' => 500000,
69		'TicketNo' => '127.0.0.1',
70		'AgainLink' => 'http://localhost/',
71		'Title' => 'Hello World',
72		'MerchTxnRef' => time()
73		]);
74
75		$this->assertTrue($responseData->getIsOk());
76		$this->assertTrue(isset($responseData['redirect_url']));
77
78		// Throws
79		$this->purchase([
80		'ReturnURL' => 'http://localhost/',
81		'TicketNo' => '127.0.0.1',
82		'AgainLink' => 'http://localhost/'
83		]);
84		}
85
86		/**
87		* @expectedException \yii\base\InvalidConfigException
88		* @expectedExceptionMessage cannot be blank
89		*/
90		public function testQueryDR()
91		{
92		// Valid
93		$responseData = $this->queryDR([
94		'MerchTxnRef' => 1
95		]);
96
97		$this->assertTrue($responseData->getIsOk());
98
99		// Throws
100		$this->queryDR([]);
101		}
102
103		/**
104		* @expectedException \yii\base\InvalidConfigException
105		* @expectedExceptionMessage cannot be blank
106		*/
107		public function testQueryDRInternational()
108		{
109		// Valid
110		$this->gateway->international = true;
111		$responseData = $this->queryDR([
112		'MerchTxnRef' => 1
113		]);
114
115		$this->assertTrue($responseData->getIsOk());
116
117		// Throws
118		$this->queryDR([]);
119		}
120
121		public function testVerifyRequestPurchaseSuccess()
122		{
123		$result = $this->verifyRequestPurchaseSuccess();
124		$this->assertFalse($result);
125		}
126
127		public function testVerifyRequestPurchaseInternationalSuccess()
128		{
129		$this->gateway->international = true;
130		$result = $this->verifyRequestPurchaseSuccess();
131
132		$this->assertFalse($result);
133		}
134
135		public function testVerifyRequestIPN()
136		{
137		$result = $this->verifyRequestIPN();
138
139		$this->assertFalse($result);
140		}
141
142		public function testVerifyRequestIPNInternational()
143		{
144		$this->gateway->international = true;
145		$result = $this->verifyRequestIPN();
146
147		$this->assertFalse($result);
148		}
149		}
150

yiiviet / yii2-payment

Issues (42)

Security Analysis not enabled

tests/OnePayTest.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like