yiiviet\payment\onepay\VerifiedData

Complexity

Total Complexity

6

Size/Duplication

Total Lines	45
Duplicated Lines	17.78 %

Coupling/Cohesion

Components	0
Dependencies	5

Test Coverage

Coverage

85.71%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	rules()	8	8	1
B	validateSecureHash()	0	19	5

<?php
/**
 * @link https://github.com/yiiviet/yii2-payment
 * @copyright Copyright (c) 2017 Yii Viet
 * @license [New BSD License](http://www.opensource.org/licenses/bsd-license.php)
 */

namespace yiiviet\payment\onepay;

use yii\helpers\ArrayHelper;
use yiiviet\payment\VerifiedData as BaseVerifiedData;

/**
 * Class VerifiedData
 *
 * @method PaymentClient getClient()
 *
 * @property PaymentClient $client
 *
 * @author Vuong Minh <vuongxuongminh@gmail.com>
 * @since 1.0
 */
class VerifiedData extends BaseVerifiedData
{

    use MagicPropertiesTrait;

    /**
     * @inheritdoc
     */
    public function rules()

This method seems to be duplicated in your project.

    {
        return [
            [['vpc_SecureHash'], 'validateSecureHash', 'message' => '{attribute} is not valid!', 'on' => [
                PaymentGateway::VRC_IPN, PaymentGateway::VRC_PURCHASE_SUCCESS
            ], 'skipOnEmpty' => false]
        ];
    }

    /**
     * Phương thức kiểm tra chữ ký dữ liệu nhận từ OnePay.
     *
     * @param string $attribute Attribute chứa giá trị chữ ký cần kiểm tra.
     * @param array $params Mảng các tham trị được thiết lập từ rule.
     * @param \yii\validators\InlineValidator $validator Đối tượng thực thi kiểm tra.
     * @throws \yii\base\InvalidConfigException|\yii\base\NotSupportedException
     */
    public function validateSecureHash($attribute, $params, \yii\validators\InlineValidator $validator)

The parameter $params is not used and could be removed.

    {
        $data = $this->get(false);
        $expectSignature = ArrayHelper::remove($data, $attribute, false);
        $dataSign = [];

        foreach ($data as $param => $value) {
            if (strpos($param, 'vpc_') === 0) {
                $dataSign[$param] = $value;
            }
        }

        ksort($dataSign);
        $data = urldecode(http_build_query($dataSign));

        if (!$expectSignature || !$this->getClient()->validateSignature($data, $expectSignature)) {
            $validator->addError($this, $attribute, $validator->message);
        }
    }
}