SignatureValidatorTrait::signatureValidator() - Code Metrics - Inspection of "Added MoMo test case" - yiiviet/yii2-payment - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4f7c7c...fdaf8f )

by Vuong

created 2018-12-23 06:41 UTC

SignatureValidatorTrait::signatureValidator() A

↳ Parent: SignatureValidatorTrait

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	2.0054

Importance

Changes

Metric	Value
dl	0
loc	13
ccs	8
cts	9
cp	0.8889
rs	9.8333
c	0
b	0
f	0
cc	2
nc	2
nop	3
crap	2.0054

<?php
/**
 * @link https://github.com/yiiviet/yii2-payment
 * @copyright Copyright (c) 2017 Yii Viet
 * @license [New BSD License](http://www.opensource.org/licenses/bsd-license.php)
 */

namespace yiiviet\payment\momo;

use yii\base\InvalidCallException;

/**
 * Trait SignatureValidatorTrait cung cấp phương thức xác minh chữ ký dữ liệu từ MOMO.
 *
 * @author Vuong Minh <[email protected]>
 * @since 1.0.3
 */
trait SignatureValidatorTrait
{
    /**
     * Phương thức kiểm tra chữ ký dữ liệu có hợp lệ hay không từ MOMO gửi sang.
     *
     * @param string $attribute có giá trị là chữ ký cần kiểm tra.
     * @param array $params thiết lập từ rule
     * @param \yii\validators\InlineValidator $validator
     * @throws \yii\base\InvalidConfigException|\yii\base\NotSupportedException|InvalidCallException
     */
    public function signatureValidator($attribute, $params, \yii\validators\InlineValidator $validator)

    {
        $dataSignAttributes = $this->getDataSignAttributes();
        $data = array_merge(array_fill_keys($dataSignAttributes, ''), $this->get(false));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $dataSign = array_intersect_key($data, array_flip($dataSignAttributes));
        $dataSign = urldecode(http_build_query($dataSign));

        $client = $this->getClient();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        if (!$client->validateSignature($dataSign, $this->$attribute ?? '')) {
            $validator->addError($this, $attribute, $validator->message);
        }
    }

    /**
     * Phương thức hồ trợ cung cấp các attributes dùng để xác minh tính hợp lệ của chữ ký dữ liệu phản hồi từ MOMO.
     *
     * @return array attributes dùng để xác minh tính hợp lệ.
     */
    protected function getDataSignAttributes(): array
    {
        throw new InvalidCallException(__METHOD__ . ' must be override by class used it!');
    }
}


1		<?php
2		/**
3		* @link https://github.com/yiiviet/yii2-payment
4		* @copyright Copyright (c) 2017 Yii Viet
5		* @license [New BSD License](http://www.opensource.org/licenses/bsd-license.php)
6		*/
7
8		namespace yiiviet\payment\momo;
9
10		use yii\base\InvalidCallException;
11
12		/**
13		* Trait SignatureValidatorTrait cung cấp phương thức xác minh chữ ký dữ liệu từ MOMO.
14		*
15		* @author Vuong Minh <[email protected]>
16		* @since 1.0.3
17		*/
18		trait SignatureValidatorTrait
19		{
20		/**
21		* Phương thức kiểm tra chữ ký dữ liệu có hợp lệ hay không từ MOMO gửi sang.
22		*
23		* @param string $attribute có giá trị là chữ ký cần kiểm tra.
24		* @param array $params thiết lập từ rule
25		* @param \yii\validators\InlineValidator $validator
26		* @throws \yii\base\InvalidConfigException\|\yii\base\NotSupportedException\|InvalidCallException
27		*/
28	4	public function signatureValidator($attribute, $params, \yii\validators\InlineValidator $validator)
		0 ignored issues – show Unused Code introduced 2018-12-23 06:43 UTC by Report Bug Copy Issue Report The parameter `$params` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
29		{
30	4	$dataSignAttributes = $this->getDataSignAttributes();
31	4	$data = array_merge(array_fill_keys($dataSignAttributes, ''), $this->get(false));
		0 ignored issues – show Bug introduced 2018-12-23 06:43 UTC by Report Bug Copy Issue Report It seems like `get()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
32	4	$dataSign = array_intersect_key($data, array_flip($dataSignAttributes));
33	4	$dataSign = urldecode(http_build_query($dataSign));
34
35	4	$client = $this->getClient();
		0 ignored issues – show Bug introduced 2018-12-23 06:43 UTC by Report Bug Copy Issue Report It seems like `getClient()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
36
37	4	if (!$client->validateSignature($dataSign, $this->$attribute ?? '')) {
38		$validator->addError($this, $attribute, $validator->message);
39		}
40	4	}
41
42		/**
43		* Phương thức hồ trợ cung cấp các attributes dùng để xác minh tính hợp lệ của chữ ký dữ liệu phản hồi từ MOMO.
44		*
45		* @return array attributes dùng để xác minh tính hợp lệ.
46		*/
47		protected function getDataSignAttributes(): array
48		{
49		throw new InvalidCallException(__METHOD__ . ' must be override by class used it!');
50		}
51		}
52

yiiviet / yii2-payment

Push — master ( 4f7c7c...fdaf8f )

SignatureValidatorTrait::signatureValidator() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like