yii\log\FileTarget::export()

Complexity

Conditions	10
Paths	34

Size

Total Lines	35
Code Lines	23

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	19
CRAP Score	10.9037

Importance

Changes

0

<?php
    public function export()
    {
        if (strpos($this->logFile, '://') === false || strncmp($this->logFile, 'file://', 7) === 0) {

It seems like $this->logFile can also be of type null; however, parameter $string1 of strncmp() does only seem to accept string, maybe add an additional type check?

It seems like $this->logFile can also be of type null; however, parameter $haystack of strpos() does only seem to accept string, maybe add an additional type check?

            $logPath = dirname($this->logFile);

It seems like $this->logFile can also be of type null; however, parameter $path of dirname() does only seem to accept string, maybe add an additional type check?

            FileHelper::createDirectory($logPath, $this->dirMode, true);
        }

        $text = implode("\n", array_map([$this, 'formatMessage'], $this->messages)) . "\n";
        if (($fp = @fopen($this->logFile, 'a')) === false) {

It seems like $this->logFile can also be of type null; however, parameter $filename of fopen() does only seem to accept string, maybe add an additional type check?

            throw new InvalidConfigException("Unable to append to log file: {$this->logFile}");
        }
        @flock($fp, LOCK_EX);

It seems like you do not handle an error condition for flock(). This can introduce security issues, and is generally not recommended.

        if ($this->enableRotation) {
            // clear stat cache to ensure getting the real current file size and not a cached one
            // this may result in rotating twice when cached file size is used on subsequent calls
            clearstatcache();
        }
        if ($this->enableRotation && @filesize($this->logFile) > $this->maxFileSize * 1024) {

It seems like $this->logFile can also be of type null; however, parameter $filename of filesize() does only seem to accept string, maybe add an additional type check?

            $this->rotateFiles();
        }
        $writeResult = @fwrite($fp, $text);
        if ($writeResult === false) {
            $error = error_get_last();
            throw new LogRuntimeException("Unable to export log through file ({$this->logFile})!: {$error['message']}");
        }
        $textSize = strlen($text);
        if ($writeResult < $textSize) {
            throw new LogRuntimeException("Unable to export whole log through file ({$this->logFile})! Wrote $writeResult out of $textSize bytes.");
        }
        @fflush($fp);

It seems like you do not handle an error condition for fflush(). This can introduce security issues, and is generally not recommended.

        @flock($fp, LOCK_UN);
        @fclose($fp);

It seems like you do not handle an error condition for fclose(). This can introduce security issues, and is generally not recommended.

        if ($this->fileMode !== null) {
            @chmod($this->logFile, $this->fileMode);

It seems like you do not handle an error condition for chmod(). This can introduce security issues, and is generally not recommended.

It seems like $this->logFile can also be of type null; however, parameter $filename of chmod() does only seem to accept string, maybe add an additional type check?

        }