Completed
Pull Request — master (#15047)
by f
09:57
created
framework/db/Migration.php 1 patch
Doc Comments   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
     /**
106 106
      * This method contains the logic to be executed when applying this migration.
107 107
      * Child classes may override this method to provide actual migration logic.
108
-     * @return bool return a false value to indicate the migration fails
108
+     * @return false|null return a false value to indicate the migration fails
109 109
      * and should not proceed further. All other return values mean the migration succeeds.
110 110
      */
111 111
     public function up()
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
      * This method contains the logic to be executed when removing this migration.
135 135
      * The default implementation throws an exception indicating the migration cannot be removed.
136 136
      * Child classes may override this method if the corresponding migrations can be removed.
137
-     * @return bool return a false value to indicate the migration fails
137
+     * @return false|null return a false value to indicate the migration fails
138 138
      * and should not proceed further. All other return values mean the migration succeeds.
139 139
      */
140 140
     public function down()
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
      * Note: Not all DBMS support transactions. And some DB queries cannot be put into a transaction. For some examples,
179 179
      * please refer to [implicit commit](http://dev.mysql.com/doc/refman/5.7/en/implicit-commit.html).
180 180
      *
181
-     * @return bool return a false value to indicate the migration fails
181
+     * @return boolean|null return a false value to indicate the migration fails
182 182
      * and should not proceed further. All other return values mean the migration succeeds.
183 183
      */
184 184
     public function safeUp()
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
      * Note: Not all DBMS support transactions. And some DB queries cannot be put into a transaction. For some examples,
196 196
      * please refer to [implicit commit](http://dev.mysql.com/doc/refman/5.7/en/implicit-commit.html).
197 197
      *
198
-     * @return bool return a false value to indicate the migration fails
198
+     * @return boolean|null return a false value to indicate the migration fails
199 199
      * and should not proceed further. All other return values mean the migration succeeds.
200 200
      */
201 201
     public function safeDown()
@@ -406,7 +406,7 @@  discard block
 block discarded – undo
406 406
      * The method will properly quote the table and column names.
407 407
      * @param string $name the name of the primary key constraint.
408 408
      * @param string $table the table that the primary key constraint will be added to.
409
-     * @param string|array $columns comma separated string or array of columns that the primary key will consist of.
409
+     * @param string[] $columns comma separated string or array of columns that the primary key will consist of.
410 410
      */
411 411
     public function addPrimaryKey($name, $table, $columns)
412 412
     {
@@ -432,9 +432,9 @@  discard block
 block discarded – undo
432 432
      * The method will properly quote the table and column names.
433 433
      * @param string $name the name of the foreign key constraint.
434 434
      * @param string $table the table that the foreign key constraint will be added to.
435
-     * @param string|array $columns the name of the column to that the constraint will be added on. If there are multiple columns, separate them with commas or use an array.
435
+     * @param string $columns the name of the column to that the constraint will be added on. If there are multiple columns, separate them with commas or use an array.
436 436
      * @param string $refTable the table that the foreign key references to.
437
-     * @param string|array $refColumns the name of the column that the foreign key references to. If there are multiple columns, separate them with commas or use an array.
437
+     * @param string $refColumns the name of the column that the foreign key references to. If there are multiple columns, separate them with commas or use an array.
438 438
      * @param string $delete the ON DELETE option. Most DBMS support these options: RESTRICT, CASCADE, NO ACTION, SET DEFAULT, SET NULL
439 439
      * @param string $update the ON UPDATE option. Most DBMS support these options: RESTRICT, CASCADE, NO ACTION, SET DEFAULT, SET NULL
440 440
      */
@@ -461,7 +461,7 @@  discard block
 block discarded – undo
461 461
      * Builds and executes a SQL statement for creating a new index.
462 462
      * @param string $name the name of the index. The name will be properly quoted by the method.
463 463
      * @param string $table the table that the new index will be created for. The table name will be properly quoted by the method.
464
-     * @param string|array $columns the column(s) that should be included in the index. If there are multiple columns, please separate them
464
+     * @param string $columns the column(s) that should be included in the index. If there are multiple columns, please separate them
465 465
      * by commas or use an array. Each column name will be properly quoted by the method. Quoting will be skipped for column names that
466 466
      * include a left parenthesis "(".
467 467
      * @param bool $unique whether to add UNIQUE constraint on the created index.
Please login to merge, or discard this patch.
framework/helpers/BaseArrayHelper.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
      * @param array $a array to be merged to
113 113
      * @param array $b array to be merged from. You can specify additional
114 114
      * arrays via third argument, fourth argument etc.
115
-     * @return array the merged array (the original arrays are not changed.)
115
+     * @return callable the merged array (the original arrays are not changed.)
116 116
      */
117 117
     public static function merge($a, $b)
118 118
     {
@@ -447,7 +447,7 @@  discard block
 block discarded – undo
447 447
      * ```
448 448
      *
449 449
      * @param array $array the array that needs to be indexed or grouped
450
-     * @param string|\Closure|null $key the column name or anonymous function which result will be used to index the array
450
+     * @param null|string $key the column name or anonymous function which result will be used to index the array
451 451
      * @param string|string[]|\Closure[]|null $groups the array of keys, that will be used to group the input array
452 452
      * by one or more keys. If the $key attribute or its value for the particular element is null and $groups is not
453 453
      * defined, the array element will be discarded. Otherwise, if $groups is specified, array element will be added
@@ -567,8 +567,8 @@  discard block
 block discarded – undo
567 567
      * ```
568 568
      *
569 569
      * @param array $array
570
-     * @param string|\Closure $from
571
-     * @param string|\Closure $to
570
+     * @param string $from
571
+     * @param string $to
572 572
      * @param string|\Closure $group
573 573
      * @return array
574 574
      */
@@ -623,7 +623,7 @@  discard block
 block discarded – undo
623 623
      * To sort by multiple keys, provide an array of keys here.
624 624
      * @param int|array $direction the sorting direction. It can be either `SORT_ASC` or `SORT_DESC`.
625 625
      * When sorting by multiple keys with different sorting directions, use an array of sorting directions.
626
-     * @param int|array $sortFlag the PHP sort flag. Valid values include
626
+     * @param integer $sortFlag the PHP sort flag. Valid values include
627 627
      * `SORT_REGULAR`, `SORT_NUMERIC`, `SORT_STRING`, `SORT_LOCALE_STRING`, `SORT_NATURAL` and `SORT_FLAG_CASE`.
628 628
      * Please refer to [PHP manual](http://php.net/manual/en/function.sort.php)
629 629
      * for more details. When sorting by multiple keys with different sort flags, use an array of sort flags.
Please login to merge, or discard this patch.
framework/helpers/BaseStringHelper.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -355,7 +355,7 @@
 block discarded – undo
355 355
      * Safely casts a float to string independent of the current locale.
356 356
      *
357 357
      * The decimal separator will always be `.`.
358
-     * @param float|int $number a floating point number or integer.
358
+     * @param double $number a floating point number or integer.
359 359
      * @return string the string representation of the number.
360 360
      * @since 2.0.13
361 361
      */
Please login to merge, or discard this patch.
framework/db/BaseActiveRecord.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -100,7 +100,7 @@
 block discarded – undo
100 100
 
101 101
     /**
102 102
      * {@inheritdoc}
103
-     * @return static|null ActiveRecord instance matching the condition, or `null` if nothing matches.
103
+     * @return BaseActiveRecord ActiveRecord instance matching the condition, or `null` if nothing matches.
104 104
      */
105 105
     public static function findOne($condition)
106 106
     {
Please login to merge, or discard this patch.
framework/db/oci/Schema.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -240,6 +240,7 @@
 block discarded – undo
240 240
 
241 241
     /**
242 242
      * {@inheritdoc}
243
+     * @param string $name
243 244
      */
244 245
     public function quoteSimpleTableName($name)
245 246
     {
Please login to merge, or discard this patch.
framework/db/sqlite/QueryBuilder.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -466,6 +466,7 @@
 block discarded – undo
466 466
 
467 467
     /**
468 468
      * {@inheritdoc}
469
+     * @param Query $query
469 470
      */
470 471
     public function build($query, $params = [])
471 472
     {
Please login to merge, or discard this patch.
framework/log/SyslogTarget.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -73,6 +73,7 @@
 block discarded – undo
73 73
 
74 74
     /**
75 75
      * {@inheritdoc}
76
+     * @return string
76 77
      */
77 78
     public function formatMessage($message)
78 79
     {
Please login to merge, or discard this patch.
build/controllers/PhpDocController.php 1 patch
Doc Comments   +15 added lines, -2 removed lines patch added patch discarded remove patch
@@ -502,6 +502,10 @@  discard block
 block discarded – undo
502 502
         // TODO
503 503
     }
504 504
 
505
+    /**
506
+     * @param null|string $className
507
+     * @param string $propertyDoc
508
+     */
505 509
     protected function updateClassPropertyDocs($file, $className, $propertyDoc)
506 510
     {
507 511
         try {
@@ -582,7 +586,7 @@  discard block
 block discarded – undo
582 586
     /**
583 587
      * remove multi empty lines and trim trailing whitespace.
584 588
      *
585
-     * @param $doc
589
+     * @param string $doc
586 590
      * @return string
587 591
      */
588 592
     protected function cleanDocComment($doc)
@@ -601,7 +605,7 @@  discard block
 block discarded – undo
601 605
 
602 606
     /**
603 607
      * Replace property annotations in doc comment.
604
-     * @param $doc
608
+     * @param string $doc
605 609
      * @param $properties
606 610
      * @return string
607 611
      */
@@ -768,6 +772,9 @@  discard block
 block discarded – undo
768 772
         return [$className, $phpdoc];
769 773
     }
770 774
 
775
+    /**
776
+     * @param string $pattern
777
+     */
771 778
     protected function match($pattern, $subject, $split = false)
772 779
     {
773 780
         $sets = [];
@@ -792,6 +799,9 @@  discard block
 block discarded – undo
792 799
         return $sets;
793 800
     }
794 801
 
802
+    /**
803
+     * @param string $str
804
+     */
795 805
     protected function fixSentence($str)
796 806
     {
797 807
         // TODO fix word wrap
@@ -802,6 +812,9 @@  discard block
 block discarded – undo
802 812
         return strtoupper(substr($str, 0, 1)) . substr($str, 1) . ($str[strlen($str) - 1] != '.' ? '.' : '');
803 813
     }
804 814
 
815
+    /**
816
+     * @param string $param
817
+     */
805 818
     protected function getPropParam($prop, $param)
806 819
     {
807 820
         return isset($prop['property']) ? $prop['property'][$param] : (isset($prop['get']) ? $prop['get'][$param] : $prop['set'][$param]);
Please login to merge, or discard this patch.