Completed
Pull Request — master (#16839)
by Robert
106:22 queued 57:20
created
framework/db/ActiveRelationTrait.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -217,7 +217,7 @@  discard block
 block discarded – undo
217 217
      * Finds the related records and populates them into the primary models.
218 218
      * @param string $name the relation name
219 219
      * @param array $primaryModels primary models
220
-     * @return array the related models
220
+     * @return ActiveRecordInterface[] the related models
221 221
      * @throws InvalidConfigException if [[link]] is invalid
222 222
      */
223 223
     public function populateRelation($name, &$primaryModels)
@@ -385,7 +385,7 @@  discard block
 block discarded – undo
385 385
     }
386 386
 
387 387
     /**
388
-     * @param array $models
388
+     * @param ActiveRecordInterface[] $models
389 389
      * @param array $link
390 390
      * @param array $viaModels
391 391
      * @param null|self $viaQuery
Please login to merge, or discard this patch.
framework/db/Schema.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -403,7 +403,7 @@  discard block
 block discarded – undo
403 403
      * Executes the INSERT command, returning primary key values.
404 404
      * @param string $table the table that new rows will be inserted into.
405 405
      * @param array $columns the column data (name => value) to be inserted into the table.
406
-     * @return array|false primary key values or false if the command fails
406
+     * @return string primary key values or false if the command fails
407 407
      * @since 2.0.4
408 408
      */
409 409
     public function insert($table, $columns)
@@ -609,7 +609,7 @@  discard block
 block discarded – undo
609 609
     /**
610 610
      * Returns the cache key for the specified table name.
611 611
      * @param string $name the table name.
612
-     * @return mixed the cache key.
612
+     * @return string[] the cache key.
613 613
      */
614 614
     protected function getCacheKey($name)
615 615
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -15,7 +15,6 @@
 block discarded – undo
15 15
 use yii\caching\Cache;
16 16
 use yii\caching\CacheInterface;
17 17
 use yii\caching\TagDependency;
18
-use yii\helpers\StringHelper;
19 18
 
20 19
 /**
21 20
  * Schema is the base class for concrete DBMS-specific schema classes.
Please login to merge, or discard this patch.
framework/db/BaseActiveRecord.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -100,7 +100,7 @@
 block discarded – undo
100 100
 
101 101
     /**
102 102
      * {@inheritdoc}
103
-     * @return static|null ActiveRecord instance matching the condition, or `null` if nothing matches.
103
+     * @return BaseActiveRecord ActiveRecord instance matching the condition, or `null` if nothing matches.
104 104
      */
105 105
     public static function findOne($condition)
106 106
     {
Please login to merge, or discard this patch.
framework/db/oci/Schema.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -240,6 +240,7 @@
 block discarded – undo
240 240
 
241 241
     /**
242 242
      * {@inheritdoc}
243
+     * @param string $name
243 244
      */
244 245
     public function quoteSimpleTableName($name)
245 246
     {
Please login to merge, or discard this patch.
framework/db/sqlite/QueryBuilder.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -466,6 +466,7 @@
 block discarded – undo
466 466
 
467 467
     /**
468 468
      * {@inheritdoc}
469
+     * @param Query $query
469 470
      */
470 471
     public function build($query, $params = [])
471 472
     {
Please login to merge, or discard this patch.
framework/log/SyslogTarget.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -73,6 +73,7 @@
 block discarded – undo
73 73
 
74 74
     /**
75 75
      * {@inheritdoc}
76
+     * @return string
76 77
      */
77 78
     public function formatMessage($message)
78 79
     {
Please login to merge, or discard this patch.
build/controllers/PhpDocController.php 1 patch
Doc Comments   +15 added lines, -2 removed lines patch added patch discarded remove patch
@@ -502,6 +502,10 @@  discard block
 block discarded – undo
502 502
         // TODO
503 503
     }
504 504
 
505
+    /**
506
+     * @param null|string $className
507
+     * @param string $propertyDoc
508
+     */
505 509
     protected function updateClassPropertyDocs($file, $className, $propertyDoc)
506 510
     {
507 511
         try {
@@ -582,7 +586,7 @@  discard block
 block discarded – undo
582 586
     /**
583 587
      * remove multi empty lines and trim trailing whitespace.
584 588
      *
585
-     * @param $doc
589
+     * @param string $doc
586 590
      * @return string
587 591
      */
588 592
     protected function cleanDocComment($doc)
@@ -601,7 +605,7 @@  discard block
 block discarded – undo
601 605
 
602 606
     /**
603 607
      * Replace property annotations in doc comment.
604
-     * @param $doc
608
+     * @param string $doc
605 609
      * @param $properties
606 610
      * @return string
607 611
      */
@@ -768,6 +772,9 @@  discard block
 block discarded – undo
768 772
         return [$className, $phpdoc];
769 773
     }
770 774
 
775
+    /**
776
+     * @param string $pattern
777
+     */
771 778
     protected function match($pattern, $subject, $split = false)
772 779
     {
773 780
         $sets = [];
@@ -792,6 +799,9 @@  discard block
 block discarded – undo
792 799
         return $sets;
793 800
     }
794 801
 
802
+    /**
803
+     * @param string $str
804
+     */
795 805
     protected function fixSentence($str)
796 806
     {
797 807
         // TODO fix word wrap
@@ -802,6 +812,9 @@  discard block
 block discarded – undo
802 812
         return strtoupper(substr($str, 0, 1)) . substr($str, 1) . ($str[\strlen($str) - 1] != '.' ? '.' : '');
803 813
     }
804 814
 
815
+    /**
816
+     * @param string $param
817
+     */
805 818
     protected function getPropParam($prop, $param)
806 819
     {
807 820
         return isset($prop['property']) ? $prop['property'][$param] : (isset($prop['get']) ? $prop['get'][$param] : $prop['set'][$param]);
Please login to merge, or discard this patch.
framework/db/cubrid/QueryBuilder.php 1 patch
Doc Comments   +2 added lines patch added patch discarded remove patch
@@ -278,6 +278,7 @@  discard block
 block discarded – undo
278 278
     /**
279 279
      * {@inheritdoc}
280 280
      * @since 2.0.8
281
+     * @param string $comment
281 282
      */
282 283
     public function addCommentOnColumn($table, $column, $comment)
283 284
     {
@@ -294,6 +295,7 @@  discard block
 block discarded – undo
294 295
     /**
295 296
      * {@inheritdoc}
296 297
      * @since 2.0.8
298
+     * @param string $comment
297 299
      */
298 300
     public function addCommentOnTable($table, $comment)
299 301
     {
Please login to merge, or discard this patch.
framework/db/pgsql/QueryBuilder.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -245,6 +245,7 @@
 block discarded – undo
245 245
 
246 246
     /**
247 247
      * {@inheritdoc}
248
+     * @param string $table
248 249
      */
249 250
     public function insert($table, $columns, &$params)
250 251
     {
Please login to merge, or discard this patch.