Passed
Push — master ( 385fe1...5adb55 )
by Alexander
10:01
created

UniqueValidator::addComboNotUniqueError()   A

Complexity

Conditions 3
Paths 3

Size

Total Lines 16
Code Lines 12

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 11
CRAP Score 3.0052

Importance

Changes 0
Metric Value
cc 3
eloc 12
nc 3
nop 2
dl 0
loc 16
ccs 11
cts 12
cp 0.9167
crap 3.0052
rs 9.8666
c 0
b 0
f 0
1
<?php
2
/**
3
 * @link http://www.yiiframework.com/
4
 * @copyright Copyright (c) 2008 Yii Software LLC
5
 * @license http://www.yiiframework.com/license/
6
 */
7
8
namespace yii\validators;
9
10
use Yii;
11
use yii\base\Model;
12
use yii\db\ActiveQuery;
13
use yii\db\ActiveQueryInterface;
14
use yii\db\ActiveRecord;
15
use yii\db\ActiveRecordInterface;
16
use yii\helpers\Inflector;
17
18
/**
19
 * UniqueValidator validates that the attribute value is unique in the specified database table.
20
 *
21
 * UniqueValidator checks if the value being validated is unique in the table column specified by
22
 * the ActiveRecord class [[targetClass]] and the attribute [[targetAttribute]].
23
 *
24
 * The following are examples of validation rules using this validator:
25
 *
26
 * ```php
27
 * // a1 needs to be unique
28
 * ['a1', 'unique']
29
 * // a1 needs to be unique, but column a2 will be used to check the uniqueness of the a1 value
30
 * ['a1', 'unique', 'targetAttribute' => 'a2']
31
 * // a1 and a2 need to be unique together, and they both will receive error message
32
 * [['a1', 'a2'], 'unique', 'targetAttribute' => ['a1', 'a2']]
33
 * // a1 and a2 need to be unique together, only a1 will receive error message
34
 * ['a1', 'unique', 'targetAttribute' => ['a1', 'a2']]
35
 * // a1 needs to be unique by checking the uniqueness of both a2 and a3 (using a1 value)
36
 * ['a1', 'unique', 'targetAttribute' => ['a2', 'a1' => 'a3']]
37
 * ```
38
 *
39
 * @author Qiang Xue <[email protected]>
40
 * @since 2.0
41
 */
42
class UniqueValidator extends Validator
43
{
44
    /**
45
     * @var string the name of the ActiveRecord class that should be used to validate the uniqueness
46
     * of the current attribute value. If not set, it will use the ActiveRecord class of the attribute being validated.
47
     * @see targetAttribute
48
     */
49
    public $targetClass;
50
    /**
51
     * @var string|array the name of the [[\yii\db\ActiveRecord|ActiveRecord]] attribute that should be used to
52
     * validate the uniqueness of the current attribute value. If not set, it will use the name
53
     * of the attribute currently being validated. You may use an array to validate the uniqueness
54
     * of multiple columns at the same time. The array values are the attributes that will be
55
     * used to validate the uniqueness, while the array keys are the attributes whose values are to be validated.
56
     */
57
    public $targetAttribute;
58
    /**
59
     * @var string|array|\Closure additional filter to be applied to the DB query used to check the uniqueness of the attribute value.
60
     * This can be a string or an array representing the additional query condition (refer to [[\yii\db\Query::where()]]
61
     * on the format of query condition), or an anonymous function with the signature `function ($query)`, where `$query`
62
     * is the [[\yii\db\Query|Query]] object that you can modify in the function.
63
     */
64
    public $filter;
65
    /**
66
     * @var string the user-defined error message.
67
     *
68
     * When validating single attribute, it may contain
69
     * the following placeholders which will be replaced accordingly by the validator:
70
     *
71
     * - `{attribute}`: the label of the attribute being validated
72
     * - `{value}`: the value of the attribute being validated
73
     *
74
     * When validating mutliple attributes, it may contain the following placeholders:
75
     *
76
     * - `{attributes}`: the labels of the attributes being validated.
77
     * - `{values}`: the values of the attributes being validated.
78
     */
79
    public $message;
80
    /**
81
     * @var string
82
     * @since 2.0.9
83
     * @deprecated since version 2.0.10, to be removed in 2.1. Use [[message]] property
84
     * to setup custom message for multiple target attributes.
85
     */
86
    public $comboNotUnique;
87
    /**
88
     * @var string and|or define how target attributes are related
89
     * @since 2.0.11
90
     */
91
    public $targetAttributeJunction = 'and';
92
    /**
93
     * @var bool whether this validator is forced to always use master DB
94
     * @since 2.0.14
95
     */
96
    public $forceMasterDb =  true;
97
98
99
    /**
100
     * {@inheritdoc}
101
     */
102 70
    public function init()
103
    {
104 70
        parent::init();
105 70
        if ($this->message !== null) {
106 3
            return;
107
        }
108 70
        if (is_array($this->targetAttribute) && count($this->targetAttribute) > 1) {
109
            // fallback for deprecated `comboNotUnique` property - use it as message if is set
110 15
            if ($this->comboNotUnique === null) {
0 ignored issues
show
Deprecated Code introduced by
The property yii\validators\UniqueValidator::$comboNotUnique has been deprecated: since version 2.0.10, to be removed in 2.1. Use [[message]] property to setup custom message for multiple target attributes. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-deprecated  annotation

110
            if (/** @scrutinizer ignore-deprecated */ $this->comboNotUnique === null) {

This property has been deprecated. The supplier of the class has supplied an explanatory message.

The explanatory message should give you some clue as to whether and when the property will be removed from the class and what other property to use instead.

Loading history...
111 12
                $this->message = Yii::t('yii', 'The combination {values} of {attributes} has already been taken.');
112
            } else {
113 15
                $this->message = $this->comboNotUnique;
0 ignored issues
show
Deprecated Code introduced by
The property yii\validators\UniqueValidator::$comboNotUnique has been deprecated: since version 2.0.10, to be removed in 2.1. Use [[message]] property to setup custom message for multiple target attributes. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-deprecated  annotation

113
                $this->message = /** @scrutinizer ignore-deprecated */ $this->comboNotUnique;

This property has been deprecated. The supplier of the class has supplied an explanatory message.

The explanatory message should give you some clue as to whether and when the property will be removed from the class and what other property to use instead.

Loading history...
114
            }
115
        } else {
116 58
            $this->message = Yii::t('yii', '{attribute} "{value}" has already been taken.');
117
        }
118 70
    }
119
120
    /**
121
     * {@inheritdoc}
122
     */
123 55
    public function validateAttribute($model, $attribute)
124
    {
125
        /* @var $targetClass ActiveRecordInterface */
126 55
        $targetClass = $this->getTargetClass($model);
127 55
        $targetAttribute = $this->targetAttribute === null ? $attribute : $this->targetAttribute;
128 55
        $rawConditions = $this->prepareConditions($targetAttribute, $model, $attribute);
129 55
        $conditions = [$this->targetAttributeJunction === 'or' ? 'or' : 'and'];
130
131 55
        foreach ($rawConditions as $key => $value) {
132 55
            if (is_array($value)) {
133 6
                $this->addError($model, $attribute, Yii::t('yii', '{attribute} is invalid.'));
134 6
                return;
135
            }
136 52
            $conditions[] = [$key => $value];
137
        }
138
139 52
        $db = $targetClass::getDb();
140
141 52
        $modelExists = false;
142
143 52
        if ($this->forceMasterDb && method_exists($db, 'useMaster')) {
144 52
            $db->useMaster(function () use ($targetClass, $conditions, $model, &$modelExists) {
145 52
                $modelExists = $this->modelExists($targetClass, $conditions, $model);
0 ignored issues
show
Bug introduced by
$targetClass of type yii\db\ActiveRecordInterface is incompatible with the type string expected by parameter $targetClass of yii\validators\UniqueValidator::modelExists(). ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

145
                $modelExists = $this->modelExists(/** @scrutinizer ignore-type */ $targetClass, $conditions, $model);
Loading history...
146 52
            });
147
        } else {
148 3
            $modelExists = $this->modelExists($targetClass, $conditions, $model);
0 ignored issues
show
Bug introduced by
$targetClass of type yii\db\ActiveRecordInterface is incompatible with the type string expected by parameter $targetClass of yii\validators\UniqueValidator::modelExists(). ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

148
            $modelExists = $this->modelExists(/** @scrutinizer ignore-type */ $targetClass, $conditions, $model);
Loading history...
149
        }
150
151 49
        if ($modelExists) {
152 29
            if (is_array($targetAttribute) && count($targetAttribute) > 1) {
153 6
                $this->addComboNotUniqueError($model, $attribute);
154
            } else {
155 29
                $this->addError($model, $attribute, $this->message);
156
            }
157
        }
158 49
    }
159
160
    /**
161
     * @param Model $model the data model to be validated
162
     * @return string Target class name
163
     */
164 64
    private function getTargetClass($model)
165
    {
166 64
        return $this->targetClass === null ? get_class($model) : $this->targetClass;
167
    }
168
169
    /**
170
     * Checks whether the $model exists in the database.
171
     *
172
     * @param string $targetClass the name of the ActiveRecord class that should be used to validate the uniqueness
173
     * of the current attribute value.
174
     * @param array $conditions conditions, compatible with [[\yii\db\Query::where()|Query::where()]] key-value format.
175
     * @param Model $model the data model to be validated
176
     *
177
     * @return bool whether the model already exists
178
     */
179 52
    private function modelExists($targetClass, $conditions, $model)
180
    {
181
        /** @var ActiveRecordInterface|\yii\base\BaseObject $targetClass $query */
182 52
        $query = $this->prepareQuery($targetClass, $conditions);
0 ignored issues
show
Bug introduced by
It seems like $targetClass can also be of type yii\base\BaseObject; however, parameter $targetClass of yii\validators\UniqueValidator::prepareQuery() does only seem to accept yii\db\ActiveRecordInterface, maybe add an additional type check? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

182
        $query = $this->prepareQuery(/** @scrutinizer ignore-type */ $targetClass, $conditions);
Loading history...
183
184 52
        if (!$model instanceof ActiveRecordInterface || $model->getIsNewRecord() || $model->className() !== $targetClass::className()) {
0 ignored issues
show
Deprecated Code introduced by
The function yii\base\BaseObject::className() has been deprecated: since 2.0.14. On PHP >=5.5, use `::class` instead. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-deprecated  annotation

184
        if (!$model instanceof ActiveRecordInterface || $model->getIsNewRecord() || $model->className() !== /** @scrutinizer ignore-deprecated */ $targetClass::className()) {

This function has been deprecated. The supplier of the function has supplied an explanatory message.

The explanatory message should give you some clue as to whether and when the function will be removed and what other function to use instead.

Loading history...
Bug introduced by
The method getIsNewRecord() does not exist on yii\base\Model. Since you implemented __call, consider adding a @method annotation. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

184
        if (!$model instanceof ActiveRecordInterface || $model->/** @scrutinizer ignore-call */ getIsNewRecord() || $model->className() !== $targetClass::className()) {
Loading history...
Bug introduced by
The method className() does not exist on yii\db\ActiveRecordInterface. Since it exists in all sub-types, consider adding an abstract or default implementation to yii\db\ActiveRecordInterface. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

184
        if (!$model instanceof ActiveRecordInterface || $model->getIsNewRecord() || $model->className() !== $targetClass::/** @scrutinizer ignore-call */ className()) {
Loading history...
185
            // if current $model isn't in the database yet then it's OK just to call exists()
186
            // also there's no need to run check based on primary keys, when $targetClass is not the same as $model's class
187 34
            $exists = $query->exists();
188
        } else {
189
            // if current $model is in the database already we can't use exists()
190 29
            if ($query instanceof \yii\db\ActiveQuery) {
191
                // only select primary key to optimize query
192 29
                $columnsCondition = array_flip($targetClass::primaryKey());
0 ignored issues
show
introduced by
The method primaryKey() does not exist on yii\base\BaseObject. Maybe you want to declare this class abstract? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

192
                $columnsCondition = array_flip($targetClass::/** @scrutinizer ignore-call */ primaryKey());
Loading history...
193 29
                $query->select(array_flip($this->applyTableAlias($query, $columnsCondition)));
194
                
195
                // any with relation can't be loaded because related fields are not selected
196 29
                $query->with = null;
197
    
198 29
                if (is_array($query->joinWith)) {
0 ignored issues
show
introduced by
The condition is_array($query->joinWith) is always true.
Loading history...
199
                    // any joinWiths need to have eagerLoading turned off to prevent related fields being loaded
200 6
                    foreach ($query->joinWith as &$joinWith) {
201
                        // \yii\db\ActiveQuery::joinWith adds eagerLoading at key 1
202 6
                        $joinWith[1] = false;
203
                    }
204 6
                    unset($joinWith);
205
                }
206
            }
207 29
            $models = $query->limit(2)->asArray()->all();
208 29
            $n = count($models);
209 29
            if ($n === 1) {
210
                // if there is one record, check if it is the currently validated model
211 26
                $dbModel = reset($models);
212 26
                $pks = $targetClass::primaryKey();
213 26
                $pk = [];
214 26
                foreach ($pks as $pkAttribute) {
215 26
                    $pk[$pkAttribute] = $dbModel[$pkAttribute];
216
                }
217 26
                $exists = ($pk != $model->getOldPrimaryKey(true));
0 ignored issues
show
Bug introduced by
The method getOldPrimaryKey() does not exist on yii\base\Model. Since you implemented __call, consider adding a @method annotation. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

217
                $exists = ($pk != $model->/** @scrutinizer ignore-call */ getOldPrimaryKey(true));
Loading history...
218
            } else {
219
                // if there is more than one record, the value is not unique
220 6
                $exists = $n > 1;
221
            }
222
        }
223
224 49
        return $exists;
225
    }
226
227
    /**
228
     * Prepares a query by applying filtering conditions defined in $conditions method property
229
     * and [[filter]] class property.
230
     *
231
     * @param ActiveRecordInterface $targetClass the name of the ActiveRecord class that should be used to validate
232
     * the uniqueness of the current attribute value.
233
     * @param array $conditions conditions, compatible with [[\yii\db\Query::where()|Query::where()]] key-value format
234
     *
235
     * @return ActiveQueryInterface|ActiveQuery
236
     */
237 55
    private function prepareQuery($targetClass, $conditions)
238
    {
239 55
        $query = $targetClass::find();
240 55
        $query->andWhere($conditions);
241 55
        if ($this->filter instanceof \Closure) {
242 6
            call_user_func($this->filter, $query);
243 52
        } elseif ($this->filter !== null) {
244 3
            $query->andWhere($this->filter);
0 ignored issues
show
Bug introduced by
It seems like $this->filter can also be of type string; however, parameter $condition of yii\db\QueryInterface::andWhere() does only seem to accept array, maybe add an additional type check? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

244
            $query->andWhere(/** @scrutinizer ignore-type */ $this->filter);
Loading history...
245
        }
246
247 55
        return $query;
248
    }
249
250
    /**
251
     * Processes attributes' relations described in $targetAttribute parameter into conditions, compatible with
252
     * [[\yii\db\Query::where()|Query::where()]] key-value format.
253
     *
254
     * @param string|array $targetAttribute the name of the [[\yii\db\ActiveRecord|ActiveRecord]] attribute that
255
     * should be used to validate the uniqueness of the current attribute value. You may use an array to validate
256
     * the uniqueness of multiple columns at the same time. The array values are the attributes that will be
257
     * used to validate the uniqueness, while the array keys are the attributes whose values are to be validated.
258
     * If the key and the value are the same, you can just specify the value.
259
     * @param Model $model the data model to be validated
260
     * @param string $attribute the name of the attribute to be validated in the $model
261
     *
262
     * @return array conditions, compatible with [[\yii\db\Query::where()|Query::where()]] key-value format.
263
     */
264 58
    private function prepareConditions($targetAttribute, $model, $attribute)
265
    {
266 58
        if (is_array($targetAttribute)) {
267 27
            $conditions = [];
268 27
            foreach ($targetAttribute as $k => $v) {
269 27
                $conditions[$v] = is_int($k) ? $model->$v : $model->$k;
270
            }
271
        } else {
272 40
            $conditions = [$targetAttribute => $model->$attribute];
273
        }
274
275 58
        $targetModelClass = $this->getTargetClass($model);
276 58
        if (!is_subclass_of($targetModelClass, 'yii\db\ActiveRecord')) {
277 6
            return $conditions;
278
        }
279
280
        /** @var ActiveRecord $targetModelClass */
281 58
        return $this->applyTableAlias($targetModelClass::find(), $conditions);
282
    }
283
284
    /**
285
     * Builds and adds [[comboNotUnique]] error message to the specified model attribute.
286
     * @param \yii\base\Model $model the data model.
287
     * @param string $attribute the name of the attribute.
288
     */
289 6
    private function addComboNotUniqueError($model, $attribute)
290
    {
291 6
        $attributeCombo = [];
292 6
        $valueCombo = [];
293 6
        foreach ($this->targetAttribute as $key => $value) {
294 6
            if (is_int($key)) {
295 6
                $attributeCombo[] = $model->getAttributeLabel($value);
296 6
                $valueCombo[] = '"' . $model->$value . '"';
297
            } else {
298
                $attributeCombo[] = $model->getAttributeLabel($key);
299 6
                $valueCombo[] = '"' . $model->$key . '"';
300
            }
301
        }
302 6
        $this->addError($model, $attribute, $this->message, [
303 6
            'attributes' => Inflector::sentence($attributeCombo),
304 6
            'values' => implode('-', $valueCombo),
305
        ]);
306 6
    }
307
308
    /**
309
     * Returns conditions with alias.
310
     * @param ActiveQuery $query
311
     * @param array $conditions array of condition, keys to be modified
312
     * @param null|string $alias set empty string for no apply alias. Set null for apply primary table alias
313
     * @return array
314
     */
315 58
    private function applyTableAlias($query, $conditions, $alias = null)
316
    {
317 58
        if ($alias === null) {
318 58
            $alias = array_keys($query->getTablesUsedInFrom())[0];
319
        }
320 58
        $prefixedConditions = [];
321 58
        foreach ($conditions as $columnName => $columnValue) {
322 58
            if (strpos($columnName, '(') === false) {
323 58
                $columnName = preg_replace('/^' . preg_quote($alias) . '\.(.*)$/', '$1', $columnName);
324 58
                if (strpos($columnName, '[[') === 0) {
325 1
                    $prefixedColumn = "{$alias}.{$columnName}";
326
                } else {
327 58
                    $prefixedColumn = "{$alias}.[[{$columnName}]]";
328
                }
329
            } else {
330
                // there is an expression, can't prefix it reliably
331 3
                $prefixedColumn = $columnName;
332
            }
333
334 58
            $prefixedConditions[$prefixedColumn] = $columnValue;
335
        }
336
337 58
        return $prefixedConditions;
338
    }
339
}
340