m160313_153426_session_init::up()

Complexity

Conditions	6
Paths	8

Size

Total Lines	28
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	15
CRAP Score	6.5625

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function up()
    {
        $dataType = $this->binary();
        $tableOptions = null;

        switch ($this->db->driverName) {
            case 'mysql':
                // https://stackoverflow.com/questions/766809/whats-the-difference-between-utf8-general-ci-and-utf8-unicode-ci
                $tableOptions = 'CHARACTER SET utf8 COLLATE utf8_unicode_ci ENGINE=InnoDB';
                break;
            case 'sqlsrv':
            case 'mssql':
            case 'dblib':
                $version = $this->db->createCommand("SELECT SERVERPROPERTY('productversion')")->queryScalar();
                $version = explode('.', $version, 2);

It seems like $version can also be of type false and null; however, parameter $string of explode() does only seem to accept string, maybe add an additional type check?

                // "varbinary(max)" added in SQL Server 2012 (version 11.*)
                if ($version < 11) {
                    $dataType = $this->text();
                }
                break;
        }

        $this->createTable('{{%session}}', [
            'id' => $this->string()->notNull(),
            'expire' => $this->integer(),
            'data' => $dataType,
            'PRIMARY KEY ([[id]])',
        ], $tableOptions);
    }