Completed
Pull Request — master (#14679)
by Robert
14:06
created
framework/db/Query.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -768,7 +768,7 @@  discard block
 block discarded – undo
768 768
 
769 769
     /**
770 770
      * Sets the GROUP BY part of the query.
771
-     * @param string|array|Expression $columns the columns to be grouped by.
771
+     * @param string $columns the columns to be grouped by.
772 772
      * Columns can be specified in either a string (e.g. "id, name") or an array (e.g. ['id', 'name']).
773 773
      * The method will automatically quote the column names unless a column contains some parenthesis
774 774
      * (which means the column contains a DB expression).
@@ -967,7 +967,7 @@  discard block
 block discarded – undo
967 967
 
968 968
     /**
969 969
      * Appends a SQL statement using UNION operator.
970
-     * @param string|Query $sql the SQL statement to be appended using UNION
970
+     * @param Query $sql the SQL statement to be appended using UNION
971 971
      * @param bool $all TRUE if using UNION ALL and FALSE if using UNION
972 972
      * @return $this the query object itself
973 973
      */
Please login to merge, or discard this patch.
framework/captcha/CaptchaAction.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -144,7 +144,7 @@
 block discarded – undo
144 144
     /**
145 145
      * Generates a hash code that can be used for client-side validation.
146 146
      * @param string $code the CAPTCHA code
147
-     * @return string a hash code generated from the CAPTCHA code
147
+     * @return integer a hash code generated from the CAPTCHA code
148 148
      */
149 149
     public function generateValidationHash($code)
150 150
     {
Please login to merge, or discard this patch.
framework/db/ActiveQuery.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -392,7 +392,7 @@
 block discarded – undo
392 392
      * @param bool|array $eagerLoading whether to eager load the relations specified in `$with`.
393 393
      * When this is a boolean, it applies to all relations specified in `$with`. Use an array
394 394
      * to explicitly list which relations in `$with` need to be eagerly loaded. Defaults to `true`.
395
-     * @param string|array $joinType the join type of the relations specified in `$with`.
395
+     * @param string $joinType the join type of the relations specified in `$with`.
396 396
      * When this is a string, it applies to all relations specified in `$with`. Use an array
397 397
      * in the format of `relationName => joinType` to specify different join types for different relations.
398 398
      * @return $this the query object itself
Please login to merge, or discard this patch.
framework/db/DataReader.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -114,7 +114,7 @@
 block discarded – undo
114 114
     /**
115 115
      * Returns a single column from the next row of a result set.
116 116
      * @param int $columnIndex zero-based column index
117
-     * @return mixed the column of the current row, false if no more rows available
117
+     * @return string the column of the current row, false if no more rows available
118 118
      */
119 119
     public function readColumn($columnIndex)
120 120
     {
Please login to merge, or discard this patch.
framework/web/Response.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -789,7 +789,7 @@
 block discarded – undo
789 789
      * });
790 790
      * ```
791 791
      *
792
-     * @param string|array $url the URL to be redirected to. This can be in one of the following formats:
792
+     * @param string $url the URL to be redirected to. This can be in one of the following formats:
793 793
      *
794 794
      * - a string representing a URL (e.g. "http://example.com")
795 795
      * - a string representing a URL alias (e.g. "@example.com")
Please login to merge, or discard this patch.
framework/web/User.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
      * stored in session and reconstruct the corresponding identity object, if it has not done so before.
176 176
      * @param bool $autoRenew whether to automatically renew authentication status if it has not been done so before.
177 177
      * This is only useful when [[enableSession]] is true.
178
-     * @return IdentityInterface|null the identity object associated with the currently logged-in user.
178
+     * @return null|boolean the identity object associated with the currently logged-in user.
179 179
      * `null` is returned if the user is not logged in (not authenticated).
180 180
      * @see login()
181 181
      * @see logout()
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
259 259
      * with the provided access token. If successful, it will call [[login()]] to log in the authenticated user.
260 260
      * If authentication fails or [[login()]] is unsuccessful, it will return null.
261 261
      * @param string $token the access token
262
-     * @param mixed $type the type of the token. The value of this parameter depends on the implementation.
262
+     * @param string $type the type of the token. The value of this parameter depends on the implementation.
263 263
      * For example, [[\yii\filters\auth\HttpBearerAuth]] will set this parameter to be `yii\filters\auth\HttpBearerAuth`.
264 264
      * @return IdentityInterface|null the identity associated with the given access token. Null is returned if
265 265
      * the access token is invalid or [[login()]] is unsuccessful.
Please login to merge, or discard this patch.
build/controllers/PhpDocController.php 1 patch
Doc Comments   +24 added lines, -2 removed lines patch added patch discarded remove patch
@@ -113,6 +113,9 @@  discard block
 block discarded – undo
113 113
         return array_merge(parent::options($actionID), ['updateFiles', 'skipFrameworkRequirements']);
114 114
     }
115 115
 
116
+    /**
117
+     * @param string|null $root
118
+     */
116 119
     protected function findFiles($root, $needsInclude = true)
117 120
     {
118 121
         $except = [];
@@ -233,6 +236,9 @@  discard block
 block discarded – undo
233 236
         return FileHelper::findFiles($root, $options);
234 237
     }
235 238
 
239
+    /**
240
+     * @param string $extensionPath
241
+     */
236 242
     private function setUpExtensionAliases($extensionPath)
237 243
     {
238 244
         foreach (scandir($extensionPath) as $extension) {
@@ -340,6 +346,9 @@  discard block
 block discarded – undo
340 346
         }
341 347
     }
342 348
 
349
+    /**
350
+     * @param string $line
351
+     */
343 352
     protected function fixParamTypes($line)
344 353
     {
345 354
         return preg_replace_callback('~@(param|return) ([\w\\|]+)~i', function ($matches) {
@@ -473,6 +482,10 @@  discard block
 block discarded – undo
473 482
         // TODO
474 483
     }
475 484
 
485
+    /**
486
+     * @param null|string $className
487
+     * @param string $propertyDoc
488
+     */
476 489
     protected function updateClassPropertyDocs($file, $className, $propertyDoc)
477 490
     {
478 491
         try {
@@ -553,7 +566,7 @@  discard block
 block discarded – undo
553 566
     /**
554 567
      * remove multi empty lines and trim trailing whitespace
555 568
      *
556
-     * @param $doc
569
+     * @param string $doc
557 570
      * @return string
558 571
      */
559 572
     protected function cleanDocComment($doc)
@@ -572,7 +585,7 @@  discard block
 block discarded – undo
572 585
 
573 586
     /**
574 587
      * Replace property annotations in doc comment
575
-     * @param $doc
588
+     * @param string $doc
576 589
      * @param $properties
577 590
      * @return string
578 591
      */
@@ -739,6 +752,9 @@  discard block
 block discarded – undo
739 752
         return [$className, $phpdoc];
740 753
     }
741 754
 
755
+    /**
756
+     * @param string $pattern
757
+     */
742 758
     protected function match($pattern, $subject, $split = false)
743 759
     {
744 760
         $sets = [];
@@ -762,6 +778,9 @@  discard block
 block discarded – undo
762 778
         return $sets;
763 779
     }
764 780
 
781
+    /**
782
+     * @param string $str
783
+     */
765 784
     protected function fixSentence($str)
766 785
     {
767 786
         // TODO fix word wrap
@@ -771,6 +790,9 @@  discard block
 block discarded – undo
771 790
         return strtoupper(substr($str, 0, 1)) . substr($str, 1) . ($str[strlen($str) - 1] != '.' ? '.' : '');
772 791
     }
773 792
 
793
+    /**
794
+     * @param string $param
795
+     */
774 796
     protected function getPropParam($prop, $param)
775 797
     {
776 798
         return isset($prop['property']) ? $prop['property'][$param] : (isset($prop['get']) ? $prop['get'][$param] : $prop['set'][$param]);
Please login to merge, or discard this patch.
framework/helpers/BaseHtml.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -216,7 +216,7 @@
 block discarded – undo
216 216
 
217 217
     /**
218 218
      * Generates a link tag that refers to an external CSS file.
219
-     * @param array|string $url the URL of the external CSS file. This parameter will be processed by [[Url::to()]].
219
+     * @param string|boolean $url the URL of the external CSS file. This parameter will be processed by [[Url::to()]].
220 220
      * @param array $options the tag options in terms of name-value pairs. The following options are specially handled:
221 221
      *
222 222
      * - condition: specifies the conditional comments for IE, e.g., `lt IE 9`. When this is specified,
Please login to merge, or discard this patch.
framework/db/Migration.php 1 patch
Doc Comments   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
     /**
91 91
      * This method contains the logic to be executed when applying this migration.
92 92
      * Child classes may override this method to provide actual migration logic.
93
-     * @return bool return a false value to indicate the migration fails
93
+     * @return false|null return a false value to indicate the migration fails
94 94
      * and should not proceed further. All other return values mean the migration succeeds.
95 95
      */
96 96
     public function up()
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
      * This method contains the logic to be executed when removing this migration.
120 120
      * The default implementation throws an exception indicating the migration cannot be removed.
121 121
      * Child classes may override this method if the corresponding migrations can be removed.
122
-     * @return bool return a false value to indicate the migration fails
122
+     * @return false|null return a false value to indicate the migration fails
123 123
      * and should not proceed further. All other return values mean the migration succeeds.
124 124
      */
125 125
     public function down()
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
      * please refer to [implicit commit](http://dev.mysql.com/doc/refman/5.7/en/implicit-commit.html). If this is the case,
165 165
      * you should still implement `up()` and `down()`, instead.
166 166
      *
167
-     * @return bool return a false value to indicate the migration fails
167
+     * @return boolean|null return a false value to indicate the migration fails
168 168
      * and should not proceed further. All other return values mean the migration succeeds.
169 169
      */
170 170
     public function safeUp()
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
      * please refer to [implicit commit](http://dev.mysql.com/doc/refman/5.7/en/implicit-commit.html). If this is the case,
183 183
      * you should still implement `up()` and `down()`, instead.
184 184
      *
185
-     * @return bool return a false value to indicate the migration fails
185
+     * @return boolean|null return a false value to indicate the migration fails
186 186
      * and should not proceed further. All other return values mean the migration succeeds.
187 187
      */
188 188
     public function safeDown()
@@ -401,7 +401,7 @@  discard block
 block discarded – undo
401 401
      * The method will properly quote the table and column names.
402 402
      * @param string $name the name of the primary key constraint.
403 403
      * @param string $table the table that the primary key constraint will be added to.
404
-     * @param string|array $columns comma separated string or array of columns that the primary key will consist of.
404
+     * @param string[] $columns comma separated string or array of columns that the primary key will consist of.
405 405
      */
406 406
     public function addPrimaryKey($name, $table, $columns)
407 407
     {
@@ -429,9 +429,9 @@  discard block
 block discarded – undo
429 429
      * The method will properly quote the table and column names.
430 430
      * @param string $name the name of the foreign key constraint.
431 431
      * @param string $table the table that the foreign key constraint will be added to.
432
-     * @param string|array $columns the name of the column to that the constraint will be added on. If there are multiple columns, separate them with commas or use an array.
432
+     * @param string $columns the name of the column to that the constraint will be added on. If there are multiple columns, separate them with commas or use an array.
433 433
      * @param string $refTable the table that the foreign key references to.
434
-     * @param string|array $refColumns the name of the column that the foreign key references to. If there are multiple columns, separate them with commas or use an array.
434
+     * @param string $refColumns the name of the column that the foreign key references to. If there are multiple columns, separate them with commas or use an array.
435 435
      * @param string $delete the ON DELETE option. Most DBMS support these options: RESTRICT, CASCADE, NO ACTION, SET DEFAULT, SET NULL
436 436
      * @param string $update the ON UPDATE option. Most DBMS support these options: RESTRICT, CASCADE, NO ACTION, SET DEFAULT, SET NULL
437 437
      */
@@ -460,7 +460,7 @@  discard block
 block discarded – undo
460 460
      * Builds and executes a SQL statement for creating a new index.
461 461
      * @param string $name the name of the index. The name will be properly quoted by the method.
462 462
      * @param string $table the table that the new index will be created for. The table name will be properly quoted by the method.
463
-     * @param string|array $columns the column(s) that should be included in the index. If there are multiple columns, please separate them
463
+     * @param string $columns the column(s) that should be included in the index. If there are multiple columns, please separate them
464 464
      * by commas or use an array. Each column name will be properly quoted by the method. Quoting will be skipped for column names that
465 465
      * include a left parenthesis "(".
466 466
      * @param bool $unique whether to add UNIQUE constraint on the created index.
Please login to merge, or discard this patch.