ActiveDataProvider::prepareTotalCount() - Code Metrics - Inspection of "Bug fix #20055 causes bad result for pagination us..." - yiisoft/yii2 - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#20176)

by Loban

created 2024-06-01 10:32 UTC

ActiveDataProvider::prepareTotalCount() A

↳ Parent: ActiveDataProvider

Complexity

Conditions	3
Paths	3

Size

Total Lines	12
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	3.0175

Importance

Changes

Metric	Value
cc	3
eloc	7
nc	3
nop	0
dl	0
loc	12
ccs	7
cts	8
cp	0.875
crap	3.0175
rs	10
c	0
b	0
f	0

<?php
/**
 * @link https://www.yiiframework.com/
 * @copyright Copyright (c) 2008 Yii Software LLC
 * @license https://www.yiiframework.com/license/
 */

namespace yii\data;

use yii\base\InvalidConfigException;
use yii\base\Model;
use yii\db\ActiveQueryInterface;
use yii\db\Connection;
use yii\db\QueryInterface;
use yii\di\Instance;

/**
 * ActiveDataProvider implements a data provider based on [[\yii\db\Query]] and [[\yii\db\ActiveQuery]].
 *
 * ActiveDataProvider provides data by performing DB queries using [[query]].
 *
 * The following is an example of using ActiveDataProvider to provide ActiveRecord instances:
 *
 * ```php
 * $provider = new ActiveDataProvider([
 *     'query' => Post::find(),
 *     'pagination' => [
 *         'pageSize' => 20,
 *     ],
 * ]);
 *
 * // get the posts in the current page
 * $posts = $provider->getModels();
 * ```
 *
 * And the following example shows how to use ActiveDataProvider without ActiveRecord:
 *
 * ```php
 * $query = new Query();
 * $provider = new ActiveDataProvider([
 *     'query' => $query->from('post'),
 *     'pagination' => [
 *         'pageSize' => 20,
 *     ],
 * ]);
 *
 * // get the posts in the current page
 * $posts = $provider->getModels();
 * ```
 *
 * For more details and usage information on ActiveDataProvider, see the [guide article on data providers](guide:output-data-providers).
 *
 * @author Qiang Xue <[email protected]>
 * @since 2.0
 */
class ActiveDataProvider extends BaseDataProvider
{
    /**
     * @var QueryInterface|null the query that is used to fetch data models and [[totalCount]] if it is not explicitly set.
     */
    public $query;
    /**
     * @var string|callable|null the column that is used as the key of the data models.
     * This can be either a column name, or a callable that returns the key value of a given data model.
     *
     * If this is not set, the following rules will be used to determine the keys of the data models:
     *
     * - If [[query]] is an [[\yii\db\ActiveQuery]] instance, the primary keys of [[\yii\db\ActiveQuery::modelClass]] will be used.
     * - Otherwise, the keys of the [[models]] array will be used.
     *
     * @see getKeys()
     */
    public $key;
    /**
     * @var Connection|array|string|null the DB connection object or the application component ID of the DB connection.
     * If set it overrides [[query]] default DB connection.
     * Starting from version 2.0.2, this can also be a configuration array for creating the object.
     */
    public $db;


    /**
     * Initializes the DB connection component.
     * This method will initialize the [[db]] property (when set) to make sure it refers to a valid DB connection.
     * @throws InvalidConfigException if [[db]] is invalid.
     */
    public function init()
    {
        parent::init();
        if ($this->db !== null) {
            $this->db = Instance::ensure($this->db);
        }
    }

    /**
     * {@inheritdoc}
     */
    protected function prepareModels()
    {
        if (!$this->query instanceof QueryInterface) {
            throw new InvalidConfigException('The "query" property must be an instance of a class that implements the QueryInterface e.g. yii\db\Query or its subclasses.');
        }
        $query = clone $this->query;
        if (($pagination = $this->getPagination()) !== false) {
            if ($pagination->totalCount === 0) {
                return [];
            }
            $query->limit($pagination->getLimit())->offset($pagination->getOffset());
        }
        if (($sort = $this->getSort()) !== false) {
            $query->addOrderBy($sort->getOrders());
        }
        return $query->all($this->db);
    }

    /**
     * {@inheritdoc}
     */
    protected function prepareKeys($models)
    {
        $keys = [];
        if ($this->key !== null) {
            foreach ($models as $model) {
                if (is_string($this->key)) {
                    $keys[] = $model[$this->key];
                } else {
                    $keys[] = call_user_func($this->key, $model);
                }
            }
            return $keys;
        } elseif ($this->query instanceof ActiveQueryInterface) {
            /* @var $class \yii\db\ActiveRecordInterface */
            $class = $this->query->modelClass;

            $pks = $class::primaryKey();
            if (count($pks) === 1) {
                $pk = $pks[0];
                foreach ($models as $model) {
                    $keys[] = $model[$pk];
                }
            } else {
                foreach ($models as $model) {
                    $kk = [];
                    foreach ($pks as $pk) {
                        $kk[$pk] = $model[$pk];
                    }
                    $keys[] = $kk;
                }
            }
            return $keys;
        }
        return array_keys($models);
    }

    private $_totalCount = [];

    /**
     * {@inheritdoc}
     */
    protected function prepareTotalCount()
    {
        if (!$this->query instanceof QueryInterface) {
            throw new InvalidConfigException('The "query" property must be an instance of a class that implements the QueryInterface e.g. yii\db\Query or its subclasses.');
        }
        $query = (clone $this->query)->limit(-1)->offset(-1)->orderBy([]);
        $key = md5((string)$query);

        if (isset($this->_totalCount[$key]) === false) {
            $this->_totalCount[$key] = (int)$query->count('*', $this->db);
        }
        return $this->_totalCount[$key];
    }

    /**
     * {@inheritdoc}
     */
    public function setSort($value)
    {
        parent::setSort($value);
        if ($this->query instanceof ActiveQueryInterface && ($sort = $this->getSort()) !== false) {
            /* @var $modelClass Model */
            $modelClass = $this->query->modelClass;
            $model = $modelClass::instance();
            if (empty($sort->attributes)) {
                foreach ($model->attributes() as $attribute) {
                    $sort->attributes[$attribute] = [
                        'asc' => [$attribute => SORT_ASC],
                        'desc' => [$attribute => SORT_DESC],
                    ];
                }
            }
            if ($sort->modelClass === null) {
                $sort->modelClass = $modelClass;

            }
        }
    }

    public function __clone()
    {
        if (is_object($this->query)) {
            $this->query = clone $this->query;
        }
        parent::__clone();
    }
}


1		<?php
2		/**
3		* @link https://www.yiiframework.com/
4		* @copyright Copyright (c) 2008 Yii Software LLC
5		* @license https://www.yiiframework.com/license/
6		*/
7
8		namespace yii\data;
9
10		use yii\base\InvalidConfigException;
11		use yii\base\Model;
12		use yii\db\ActiveQueryInterface;
13		use yii\db\Connection;
14		use yii\db\QueryInterface;
15		use yii\di\Instance;
16
17		/**
18		* ActiveDataProvider implements a data provider based on [[\yii\db\Query]] and [[\yii\db\ActiveQuery]].
19		*
20		* ActiveDataProvider provides data by performing DB queries using [[query]].
21		*
22		* The following is an example of using ActiveDataProvider to provide ActiveRecord instances:
23		*
24		* ```php
25		* $provider = new ActiveDataProvider([
26		* 'query' => Post::find(),
27		* 'pagination' => [
28		* 'pageSize' => 20,
29		* ],
30		* ]);
31		*
32		* // get the posts in the current page
33		* $posts = $provider->getModels();
34		* ```
35		*
36		* And the following example shows how to use ActiveDataProvider without ActiveRecord:
37		*
38		* ```php
39		* $query = new Query();
40		* $provider = new ActiveDataProvider([
41		* 'query' => $query->from('post'),
42		* 'pagination' => [
43		* 'pageSize' => 20,
44		* ],
45		* ]);
46		*
47		* // get the posts in the current page
48		* $posts = $provider->getModels();
49		* ```
50		*
51		* For more details and usage information on ActiveDataProvider, see the [guide article on data providers](guide:output-data-providers).
52		*
53		* @author Qiang Xue <[email protected]>
54		* @since 2.0
55		*/
56		class ActiveDataProvider extends BaseDataProvider
57		{
58		/**
59		* @var QueryInterface\|null the query that is used to fetch data models and [[totalCount]] if it is not explicitly set.
60		*/
61		public $query;
62		/**
63		* @var string\|callable\|null the column that is used as the key of the data models.
64		* This can be either a column name, or a callable that returns the key value of a given data model.
65		*
66		* If this is not set, the following rules will be used to determine the keys of the data models:
67		*
68		* - If [[query]] is an [[\yii\db\ActiveQuery]] instance, the primary keys of [[\yii\db\ActiveQuery::modelClass]] will be used.
69		* - Otherwise, the keys of the [[models]] array will be used.
70		*
71		* @see getKeys()
72		*/
73		public $key;
74		/**
75		* @var Connection\|array\|string\|null the DB connection object or the application component ID of the DB connection.
76		* If set it overrides [[query]] default DB connection.
77		* Starting from version 2.0.2, this can also be a configuration array for creating the object.
78		*/
79		public $db;
80
81
82		/**
83		* Initializes the DB connection component.
84		* This method will initialize the [[db]] property (when set) to make sure it refers to a valid DB connection.
85		* @throws InvalidConfigException if [[db]] is invalid.
86		*/
87	35	public function init()
88		{
89	35	parent::init();
90	35	if ($this->db !== null) {
91	12	$this->db = Instance::ensure($this->db);
92		}
93		}
94
95		/**
96		* {@inheritdoc}
97		*/
98	25	protected function prepareModels()
99		{
100	25	if (!$this->query instanceof QueryInterface) {
101		throw new InvalidConfigException('The "query" property must be an instance of a class that implements the QueryInterface e.g. yii\db\Query or its subclasses.');
102		}
103	25	$query = clone $this->query;
104	25	if (($pagination = $this->getPagination()) !== false) {
105	25	if ($pagination->totalCount === 0) {
106	4	return [];
107		}
108	21	$query->limit($pagination->getLimit())->offset($pagination->getOffset());
109		}
110	21	if (($sort = $this->getSort()) !== false) {
111	21	$query->addOrderBy($sort->getOrders());
112		}
113	21	return $query->all($this->db);
114		}
115
116		/**
117		* {@inheritdoc}
118		*/
119	27	protected function prepareKeys($models)
120		{
121	27	$keys = [];
122	27	if ($this->key !== null) {
123		foreach ($models as $model) {
124		if (is_string($this->key)) {
125		$keys[] = $model[$this->key];
126		} else {
127		$keys[] = call_user_func($this->key, $model);
128		}
129		}
130		return $keys;
131	27	} elseif ($this->query instanceof ActiveQueryInterface) {
132		/* @var $class \yii\db\ActiveRecordInterface */
133	15	$class = $this->query->modelClass;
		0 ignored issues – show Bug introduced 2019-02-03 21:14 UTC by Report Bug Copy Issue Report Accessing `modelClass` on the interface `yii\db\ActiveQueryInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
134	15	$pks = $class::primaryKey();
135	15	if (count($pks) === 1) {
136	15	$pk = $pks[0];
137	15	foreach ($models as $model) {
138	14	$keys[] = $model[$pk];
139		}
140		} else {
141		foreach ($models as $model) {
142		$kk = [];
143		foreach ($pks as $pk) {
144		$kk[$pk] = $model[$pk];
145		}
146		$keys[] = $kk;
147		}
148		}
149	15	return $keys;
150		}
151	12	return array_keys($models);
152		}
153
154		private $_totalCount = [];
155
156		/**
157		* {@inheritdoc}
158		*/
159	25	protected function prepareTotalCount()
160		{
161	25	if (!$this->query instanceof QueryInterface) {
162		throw new InvalidConfigException('The "query" property must be an instance of a class that implements the QueryInterface e.g. yii\db\Query or its subclasses.');
163		}
164	25	$query = (clone $this->query)->limit(-1)->offset(-1)->orderBy([]);
165	25	$key = md5((string)$query);
166
167	25	if (isset($this->_totalCount[$key]) === false) {
168	25	$this->_totalCount[$key] = (int)$query->count('*', $this->db);
169		}
170	25	return $this->_totalCount[$key];
171		}
172
173		/**
174		* {@inheritdoc}
175		*/
176	30	public function setSort($value)
177		{
178	30	parent::setSort($value);
179	30	if ($this->query instanceof ActiveQueryInterface && ($sort = $this->getSort()) !== false) {
180		/* @var $modelClass Model */
181	20	$modelClass = $this->query->modelClass;
182	20	$model = $modelClass::instance();
183	20	if (empty($sort->attributes)) {
184	16	foreach ($model->attributes() as $attribute) {
185	16	$sort->attributes[$attribute] = [
186	16	'asc' => [$attribute => SORT_ASC],
187	16	'desc' => [$attribute => SORT_DESC],
188	16	];
189		}
190		}
191	20	if ($sort->modelClass === null) {
192	20	$sort->modelClass = $modelClass;
		0 ignored issues – show Documentation Bug introduced 2023-07-19 18:28 UTC by Report Bug Copy Issue Report It seems like `$modelClass` of type `yii\base\Model` is incompatible with the declared type `null\|string` of property `$modelClass`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
193		}
194		}
195		}
196
197	1	public function __clone()
198		{
199	1	if (is_object($this->query)) {
200	1	$this->query = clone $this->query;
201		}
202	1	parent::__clone();
203		}
204		}
205

yiisoft / yii2

Pull Request — master (#20176)

ActiveDataProvider::prepareTotalCount() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like