yiisoft /
yii2
| Conditions | 12 |
| Paths | 44 |
| Total Lines | 38 |
| Code Lines | 24 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 24 |
| CRAP Score | 12 |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 49 | 105 | public function build(ExpressionInterface $expression, array &$params = []) |
|
| 50 | { |
||
| 51 | 105 | $operator = strtoupper($expression->getOperator()); |
|
|
Bug
introduced
by
|
|||
| 52 | 105 | $column = $expression->getColumn(); |
|
| 53 | 105 | $values = $expression->getValue(); |
|
| 54 | 105 | $escape = $expression->getEscapingReplacements(); |
|
| 55 | 105 | if ($escape === null || $escape === []) { |
|
| 56 | 102 | $escape = $this->escapingReplacements; |
|
| 57 | } |
||
| 58 | |||
| 59 | 105 | list($andor, $not, $operator) = $this->parseOperator($operator); |
|
| 60 | |||
| 61 | 105 | if (!is_array($values)) { |
|
| 62 | 49 | $values = [$values]; |
|
| 63 | } |
||
| 64 | |||
| 65 | 105 | if (empty($values)) { |
|
| 66 | 16 | return $not ? '' : '0=1'; |
|
| 67 | } |
||
| 68 | |||
| 69 | 89 | if ($column instanceof ExpressionInterface) { |
|
| 70 | 3 | $column = $this->queryBuilder->buildExpression($column, $params); |
|
| 71 | 86 | } elseif (is_string($column) && strpos($column, '(') === false) { |
|
| 72 | 86 | $column = $this->queryBuilder->db->quoteColumnName($column); |
|
| 73 | } |
||
| 74 | |||
| 75 | 89 | $escapeSql = $this->getEscapeSql(); |
|
| 76 | 89 | $parts = []; |
|
| 77 | 89 | foreach ($values as $value) { |
|
| 78 | 89 | if ($value instanceof ExpressionInterface) { |
|
| 79 | 48 | $phName = $this->queryBuilder->buildExpression($value, $params); |
|
| 80 | } else { |
||
| 81 | 65 | $phName = $this->queryBuilder->bindParam(empty($escape) ? $value : ('%' . strtr($value, $escape) . '%'), $params); |
|
| 82 | } |
||
| 83 | 89 | $parts[] = "{$column} {$operator} {$phName}{$escapeSql}"; |
|
| 84 | } |
||
| 85 | |||
| 86 | 89 | return implode($andor, $parts); |
|
| 87 | } |
||
| 117 |
Loading history...
