Completed
Pull Request — master (#12699)
by Robert
12:48
created
framework/base/Event.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
      * Returns a value indicating whether there is any handler attached to the specified class-level event.
147 147
      * Note that this method will also check all parent classes to see if there is any handler attached
148 148
      * to the named event.
149
-     * @param string|object $class the object or the fully qualified class name specifying the class-level event.
149
+     * @param Component $class the object or the fully qualified class name specifying the class-level event.
150 150
      * @param string $name the event name.
151 151
      * @return bool whether there is any handler attached to the event.
152 152
      */
@@ -180,7 +180,7 @@  discard block
 block discarded – undo
180 180
      * Triggers a class-level event.
181 181
      * This method will cause invocation of event handlers that are attached to the named event
182 182
      * for the specified class and all its parent classes.
183
-     * @param string|object $class the object or the fully qualified class name specifying the class-level event.
183
+     * @param Component $class the object or the fully qualified class name specifying the class-level event.
184 184
      * @param string $name the event name.
185 185
      * @param Event $event the event parameter. If not set, a default [[Event]] object will be created.
186 186
      */
Please login to merge, or discard this patch.
framework/web/CookieCollection.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
      * Removes a cookie.
135 135
      * If `$removeFromBrowser` is true, the cookie will be removed from the browser.
136 136
      * In this case, a cookie with outdated expiry will be added to the collection.
137
-     * @param Cookie|string $cookie the cookie object or the name of the cookie to be removed.
137
+     * @param string $cookie the cookie object or the name of the cookie to be removed.
138 138
      * @param bool $removeFromBrowser whether to remove the cookie from browser
139 139
      * @throws InvalidCallException if the cookie collection is read only
140 140
      */
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
173 173
 
174 174
     /**
175 175
      * Returns the collection as a PHP array.
176
-     * @return array the array representation of the collection.
176
+     * @return Cookie[] the array representation of the collection.
177 177
      * The array keys are cookie names, and the array values are the corresponding cookie objects.
178 178
      */
179 179
     public function toArray()
Please login to merge, or discard this patch.
build/controllers/ReleaseController.php 1 patch
Doc Comments   +20 added lines, -1 removed lines patch added patch discarded remove patch
@@ -367,7 +367,7 @@  discard block
 block discarded – undo
367 367
 
368 368
     /**
369 369
      * @param array $what list of items
370
-     * @param array $limit list of things to allow, or empty to allow any, can be `app`, `framework`, `extension`
370
+     * @param string[] $limit list of things to allow, or empty to allow any, can be `app`, `framework`, `extension`
371 371
      * @throws \yii\base\Exception
372 372
      */
373 373
     protected function validateWhat(array $what, $limit = [], $ensureGitClean = true)
@@ -547,6 +547,10 @@  discard block
 block discarded – undo
547 547
 
548 548
     }
549 549
 
550
+    /**
551
+     * @param string $name
552
+     * @param string $path
553
+     */
550 554
     protected function releaseApplication($name, $path, $version)
551 555
     {
552 556
         $this->stdout("\n");
@@ -649,6 +653,9 @@  discard block
 block discarded – undo
649 653
         Yii::setAlias('@app', $this->_oldAlias);
650 654
     }
651 655
 
656
+    /**
657
+     * @param string $name
658
+     */
652 659
     protected function packageApplication($name, $version, $packagePath)
653 660
     {
654 661
         FileHelper::createDirectory($packagePath);
@@ -810,6 +817,9 @@  discard block
 block discarded – undo
810 817
     }
811 818
 
812 819
 
820
+    /**
821
+     * @param string[] $what
822
+     */
813 823
     protected function closeChangelogs($what, $version)
814 824
     {
815 825
         $v = str_replace('\\-', '[\\- ]', preg_quote($version, '/'));
@@ -821,6 +831,9 @@  discard block
 block discarded – undo
821 831
         );
822 832
     }
823 833
 
834
+    /**
835
+     * @param string[] $what
836
+     */
824 837
     protected function openChangelogs($what, $version)
825 838
     {
826 839
         $headline = "\n$version under development\n";
@@ -977,6 +990,9 @@  discard block
 block discarded – undo
977 990
             $frameworkPath . '/BaseYii.php');
978 991
     }
979 992
 
993
+    /**
994
+     * @param string $pattern
995
+     */
980 996
     protected function sed($pattern, $replace, $files)
981 997
     {
982 998
         foreach ((array) $files as $file) {
@@ -1009,6 +1025,9 @@  discard block
 block discarded – undo
1009 1025
     const MINOR = 'minor';
1010 1026
     const PATCH = 'patch';
1011 1027
 
1028
+    /**
1029
+     * @param string $type
1030
+     */
1012 1031
     protected function getNextVersions(array $versions, $type)
1013 1032
     {
1014 1033
         foreach ($versions as $k => $v) {
Please login to merge, or discard this patch.
framework/helpers/BaseHtml.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -216,7 +216,7 @@
 block discarded – undo
216 216
 
217 217
     /**
218 218
      * Generates a link tag that refers to an external CSS file.
219
-     * @param array|string $url the URL of the external CSS file. This parameter will be processed by [[Url::to()]].
219
+     * @param string|boolean $url the URL of the external CSS file. This parameter will be processed by [[Url::to()]].
220 220
      * @param array $options the tag options in terms of name-value pairs. The following options are specially handled:
221 221
      *
222 222
      * - condition: specifies the conditional comments for IE, e.g., `lt IE 9`. When this is specified,
Please login to merge, or discard this patch.
framework/db/Migration.php 1 patch
Doc Comments   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
     /**
91 91
      * This method contains the logic to be executed when applying this migration.
92 92
      * Child classes may override this method to provide actual migration logic.
93
-     * @return bool return a false value to indicate the migration fails
93
+     * @return false|null return a false value to indicate the migration fails
94 94
      * and should not proceed further. All other return values mean the migration succeeds.
95 95
      */
96 96
     public function up()
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
      * This method contains the logic to be executed when removing this migration.
120 120
      * The default implementation throws an exception indicating the migration cannot be removed.
121 121
      * Child classes may override this method if the corresponding migrations can be removed.
122
-     * @return bool return a false value to indicate the migration fails
122
+     * @return false|null return a false value to indicate the migration fails
123 123
      * and should not proceed further. All other return values mean the migration succeeds.
124 124
      */
125 125
     public function down()
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
      * please refer to [implicit commit](http://dev.mysql.com/doc/refman/5.7/en/implicit-commit.html). If this is the case,
165 165
      * you should still implement `up()` and `down()`, instead.
166 166
      *
167
-     * @return bool return a false value to indicate the migration fails
167
+     * @return boolean|null return a false value to indicate the migration fails
168 168
      * and should not proceed further. All other return values mean the migration succeeds.
169 169
      */
170 170
     public function safeUp()
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
      * please refer to [implicit commit](http://dev.mysql.com/doc/refman/5.7/en/implicit-commit.html). If this is the case,
183 183
      * you should still implement `up()` and `down()`, instead.
184 184
      *
185
-     * @return bool return a false value to indicate the migration fails
185
+     * @return boolean|null return a false value to indicate the migration fails
186 186
      * and should not proceed further. All other return values mean the migration succeeds.
187 187
      */
188 188
     public function safeDown()
@@ -401,7 +401,7 @@  discard block
 block discarded – undo
401 401
      * The method will properly quote the table and column names.
402 402
      * @param string $name the name of the primary key constraint.
403 403
      * @param string $table the table that the primary key constraint will be added to.
404
-     * @param string|array $columns comma separated string or array of columns that the primary key will consist of.
404
+     * @param string[] $columns comma separated string or array of columns that the primary key will consist of.
405 405
      */
406 406
     public function addPrimaryKey($name, $table, $columns)
407 407
     {
@@ -429,9 +429,9 @@  discard block
 block discarded – undo
429 429
      * The method will properly quote the table and column names.
430 430
      * @param string $name the name of the foreign key constraint.
431 431
      * @param string $table the table that the foreign key constraint will be added to.
432
-     * @param string|array $columns the name of the column to that the constraint will be added on. If there are multiple columns, separate them with commas or use an array.
432
+     * @param string $columns the name of the column to that the constraint will be added on. If there are multiple columns, separate them with commas or use an array.
433 433
      * @param string $refTable the table that the foreign key references to.
434
-     * @param string|array $refColumns the name of the column that the foreign key references to. If there are multiple columns, separate them with commas or use an array.
434
+     * @param string $refColumns the name of the column that the foreign key references to. If there are multiple columns, separate them with commas or use an array.
435 435
      * @param string $delete the ON DELETE option. Most DBMS support these options: RESTRICT, CASCADE, NO ACTION, SET DEFAULT, SET NULL
436 436
      * @param string $update the ON UPDATE option. Most DBMS support these options: RESTRICT, CASCADE, NO ACTION, SET DEFAULT, SET NULL
437 437
      */
@@ -460,7 +460,7 @@  discard block
 block discarded – undo
460 460
      * Builds and executes a SQL statement for creating a new index.
461 461
      * @param string $name the name of the index. The name will be properly quoted by the method.
462 462
      * @param string $table the table that the new index will be created for. The table name will be properly quoted by the method.
463
-     * @param string|array $columns the column(s) that should be included in the index. If there are multiple columns, please separate them
463
+     * @param string $columns the column(s) that should be included in the index. If there are multiple columns, please separate them
464 464
      * by commas or use an array. Each column name will be properly quoted by the method. Quoting will be skipped for column names that
465 465
      * include a left parenthesis "(".
466 466
      * @param bool $unique whether to add UNIQUE constraint on the created index.
Please login to merge, or discard this patch.