DataColumn::getHeaderCellLabel() - Code Metrics - Inspection of "fix 'filters' unit tests" - yiisoft/yii2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 2.1 ( 0cb910...fafa40 )

unknown

created 2018-02-27 22:10 UTC

DataColumn::getHeaderCellLabel() D

↳ Parent: DataColumn

Complexity

Conditions	9
Paths	6

Size

Total Lines	32
Code Lines	22

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	13.0498

Importance

Changes

Metric	Value
dl	0
loc	32
ccs	12
cts	19
cp	0.6316
rs	4.909
c	0
b	0
f	0
cc	9
eloc	22
nc	6
nop	0
crap	13.0498

<?php
/**
 * @link http://www.yiiframework.com/
 * @copyright Copyright (c) 2008 Yii Software LLC
 * @license http://www.yiiframework.com/license/
 */

namespace yii\grid;

use Closure;
use yii\base\Model;
use yii\data\ActiveDataProvider;
use yii\data\ArrayDataProvider;
use yii\db\ActiveQueryInterface;
use yii\helpers\ArrayHelper;
use yii\helpers\Html;
use yii\helpers\Inflector;

/**
 * DataColumn is the default column type for the [[GridView]] widget.
 *
 * It is used to show data columns and allows [[enableSorting|sorting]] and [[filter|filtering]] them.
 *
 * A simple data column definition refers to an attribute in the data model of the
 * GridView's data provider. The name of the attribute is specified by [[attribute]].
 *
 * By setting [[value]] and [[label]], the header and cell content can be customized.
 *
 * A data column differentiates between the [[getDataCellValue|data cell value]] and the
 * [[renderDataCellContent|data cell content]]. The cell value is an un-formatted value that
 * may be used for calculation, while the actual cell content is a [[format|formatted]] version of that
 * value which may contain HTML markup.
 *
 * For more details and usage information on DataColumn, see the [guide article on data widgets](guide:output-data-widgets).
 *
 * @author Qiang Xue <[email protected]>
 * @since 2.0
 */
class DataColumn extends Column
{
    /**
     * @var string the attribute name associated with this column. When neither [[content]] nor [[value]]
     * is specified, the value of the specified attribute will be retrieved from each data model and displayed.
     *
     * Also, if [[label]] is not specified, the label associated with the attribute will be displayed.
     */
    public $attribute;
    /**
     * @var string label to be displayed in the [[header|header cell]] and also to be used as the sorting
     * link label when sorting is enabled for this column.
     * If it is not set and the models provided by the GridViews data provider are instances
     * of [[\yii\db\ActiveRecord]], the label will be determined using [[\yii\db\ActiveRecord::getAttributeLabel()]].
     * Otherwise [[\yii\helpers\Inflector::camel2words()]] will be used to get a label.
     */
    public $label;
    /**
     * @var bool whether the header label should be HTML-encoded.
     * @see label
     * @since 2.0.1
     */
    public $encodeLabel = true;
    /**
     * @var string|Closure an anonymous function or a string that is used to determine the value to display in the current column.
     *
     * If this is an anonymous function, it will be called for each row and the return value will be used as the value to
     * display for every data model. The signature of this function should be: `function ($model, $key, $index, $column)`.
     * Where `$model`, `$key`, and `$index` refer to the model, key and index of the row currently being rendered
     * and `$column` is a reference to the [[DataColumn]] object.
     *
     * You may also set this property to a string representing the attribute name to be displayed in this column.
     * This can be used when the attribute to be displayed is different from the [[attribute]] that is used for
     * sorting and filtering.
     *
     * If this is not set, `$model[$attribute]` will be used to obtain the value, where `$attribute` is the value of [[attribute]].
     */
    public $value;
    /**
     * @var string|array|Closure in which format should the value of each data model be displayed as (e.g. `"raw"`, `"text"`, `"html"`,
     * `['date', 'php:Y-m-d']`). Supported formats are determined by the [[GridView::formatter|formatter]] used by
     * the [[GridView]]. Default format is "text" which will format the value as an HTML-encoded plain text when
     * [[\yii\i18n\Formatter]] is used as the [[GridView::$formatter|formatter]] of the GridView.
     * @see \yii\i18n\Formatter::format()
     */
    public $format = 'text';
    /**
     * @var bool whether to allow sorting by this column. If true and [[attribute]] is found in
     * the sort definition of [[GridView::dataProvider]], then the header cell of this column
     * will contain a link that may trigger the sorting when being clicked.
     */
    public $enableSorting = true;
    /**
     * @var array the HTML attributes for the link tag in the header cell
     * generated by [[\yii\data\Sort::link]] when sorting is enabled for this column.
     * @see \yii\helpers\Html::renderTagAttributes() for details on how attributes are being rendered.
     */
    public $sortLinkOptions = [];
    /**
     * @var string|array|null|false the HTML code representing a filter input (e.g. a text field, a dropdown list)
     * that is used for this data column. This property is effective only when [[GridView::filterModel]] is set.
     *
     * - If this property is not set, a text field will be generated as the filter input with attributes defined
     *   with [[filterInputOptions]]. See [[\yii\helpers\BaseHtml::activeInput]] for details on how an active
     *   input tag is generated.
     * - If this property is an array, a dropdown list will be generated that uses this property value as
     *   the list options.
     * - If you don't want a filter for this data column, set this value to be false.
     */
    public $filter;
    /**
     * @var array the HTML attributes for the filter input fields. This property is used in combination with
     * the [[filter]] property. When [[filter]] is not set or is an array, this property will be used to
     * render the HTML attributes for the generated filter input fields.
     * By default a `'class' => 'form-control'` element will be added if no class has been specified.
     * If you do not want to create a class attribute, you can specify `['class' => null]`.
     * 
     * Empty `id` in the default value ensures that id would not be obtained from the model attribute thus
     * providing better performance.
     *
     * @see \yii\helpers\Html::renderTagAttributes() for details on how attributes are being rendered.
     */
    public $filterInputOptions = [];


    /**
     * {@inheritdoc}
     */
    protected function renderHeaderCellContent()
    {
        if ($this->header !== null || $this->label === null && $this->attribute === null) {
            return parent::renderHeaderCellContent();
        }

        $label = $this->getHeaderCellLabel();
        if ($this->encodeLabel) {
            $label = Html::encode($label);
        }

        if ($this->attribute !== null && $this->enableSorting &&
            ($sort = $this->grid->dataProvider->getSort()) !== false && $sort->hasAttribute($this->attribute)) {
            return $sort->link($this->attribute, array_merge($this->sortLinkOptions, ['label' => $label]));
        }

        return $label;
    }

    /**
     * {@inheritdoc]
     * @since 2.0.8
     */
    protected function getHeaderCellLabel()
    {
        $provider = $this->grid->dataProvider;

        if ($this->label === null) {
            if ($provider instanceof ActiveDataProvider && $provider->query instanceof ActiveQueryInterface) {
                /* @var $modelClass Model */
                $modelClass = $provider->query->modelClass;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                $model = $modelClass::instance();
                $label = $model->getAttributeLabel($this->attribute);
            } elseif ($provider instanceof ArrayDataProvider && $provider->modelClass !== null) {
                /* @var $modelClass Model */
                $modelClass = $provider->modelClass;
                $model = $modelClass::instance();
                $label = $model->getAttributeLabel($this->attribute);
            } elseif ($this->grid->filterModel !== null && $this->grid->filterModel instanceof Model) {
                $label = $this->grid->filterModel->getAttributeLabel($this->attribute);
            } else {
                $models = $provider->getModels();
                if (($model = reset($models)) instanceof Model) {
                    /* @var $model Model */
                    $label = $model->getAttributeLabel($this->attribute);
                } else {
                    $label = Inflector::camel2words($this->attribute);
                }
            }
        } else {
            $label = $this->label;
        }

        return $label;
    }

    /**
     * {@inheritdoc}
     */
    protected function renderFilterCellContent()
    {
        if (is_string($this->filter)) {
            return $this->filter;
        }

        $model = $this->grid->filterModel;

        if ($this->filter !== false && $model instanceof Model && $this->attribute !== null && $model->isAttributeActive($this->attribute)) {
            if ($model->hasErrors($this->attribute)) {
                Html::addCssClass($this->filterOptions, 'has-error');
                $error = ' ' . Html::error($model, $this->attribute, $this->grid->filterErrorOptions);
            } else {
                $error = '';
            }

            $filterOptions = array_merge(['class' => 'form-control', 'id' => null], $this->filterInputOptions);
            if (is_array($this->filter)) {
                $options = array_merge(['prompt' => ''], $filterOptions);
                return Html::activeDropDownList($model, $this->attribute, $this->filter, $options) . $error;
            }
            if ($this->format === 'boolean') {
                $options = array_merge(['prompt' => ''], $filterOptions);
                return Html::activeDropDownList($model, $this->attribute, [
                    1 => $this->grid->formatter->booleanFormat[1],
                    0 => $this->grid->formatter->booleanFormat[0],
                ], $options) . $error;
            }

            return Html::activeTextInput($model, $this->attribute, $filterOptions) . $error;
        }

        return parent::renderFilterCellContent();
    }

    /**
     * Returns the data cell value.
     * @param mixed $model the data model
     * @param mixed $key the key associated with the data model
     * @param int $index the zero-based index of the data model among the models array returned by [[GridView::dataProvider]].
     * @return string the data cell value
     */
    public function getDataCellValue($model, $key, $index)
    {
        if ($this->value !== null) {
            if (is_string($this->value)) {
                return ArrayHelper::getValue($model, $this->value);
            }

            return call_user_func($this->value, $model, $key, $index, $this);
        }
        if ($this->attribute !== null) {
            return ArrayHelper::getValue($model, $this->attribute);
        }

        return null;
    }

    /**
     * {@inheritdoc}
     */
    protected function renderDataCellContent($model, $key, $index)
    {
        if ($this->content === null) {
            return $this->grid->formatter->format($this->getDataCellValue($model, $key, $index), $this->format);
        }

        return parent::renderDataCellContent($model, $key, $index);
    }
}


1		<?php
2		/**
3		* @link http://www.yiiframework.com/
4		* @copyright Copyright (c) 2008 Yii Software LLC
5		* @license http://www.yiiframework.com/license/
6		*/
7
8		namespace yii\grid;
9
10		use Closure;
11		use yii\base\Model;
12		use yii\data\ActiveDataProvider;
13		use yii\data\ArrayDataProvider;
14		use yii\db\ActiveQueryInterface;
15		use yii\helpers\ArrayHelper;
16		use yii\helpers\Html;
17		use yii\helpers\Inflector;
18
19		/**
20		* DataColumn is the default column type for the [[GridView]] widget.
21		*
22		* It is used to show data columns and allows [[enableSorting\|sorting]] and [[filter\|filtering]] them.
23		*
24		* A simple data column definition refers to an attribute in the data model of the
25		* GridView's data provider. The name of the attribute is specified by [[attribute]].
26		*
27		* By setting [[value]] and [[label]], the header and cell content can be customized.
28		*
29		* A data column differentiates between the [[getDataCellValue\|data cell value]] and the
30		* [[renderDataCellContent\|data cell content]]. The cell value is an un-formatted value that
31		* may be used for calculation, while the actual cell content is a [[format\|formatted]] version of that
32		* value which may contain HTML markup.
33		*
34		* For more details and usage information on DataColumn, see the [guide article on data widgets](guide:output-data-widgets).
35		*
36		* @author Qiang Xue <[email protected]>
37		* @since 2.0
38		*/
39		class DataColumn extends Column
40		{
41		/**
42		* @var string the attribute name associated with this column. When neither [[content]] nor [[value]]
43		* is specified, the value of the specified attribute will be retrieved from each data model and displayed.
44		*
45		* Also, if [[label]] is not specified, the label associated with the attribute will be displayed.
46		*/
47		public $attribute;
48		/**
49		* @var string label to be displayed in the [[header\|header cell]] and also to be used as the sorting
50		* link label when sorting is enabled for this column.
51		* If it is not set and the models provided by the GridViews data provider are instances
52		* of [[\yii\db\ActiveRecord]], the label will be determined using [[\yii\db\ActiveRecord::getAttributeLabel()]].
53		* Otherwise [[\yii\helpers\Inflector::camel2words()]] will be used to get a label.
54		*/
55		public $label;
56		/**
57		* @var bool whether the header label should be HTML-encoded.
58		* @see label
59		* @since 2.0.1
60		*/
61		public $encodeLabel = true;
62		/**
63		* @var string\|Closure an anonymous function or a string that is used to determine the value to display in the current column.
64		*
65		* If this is an anonymous function, it will be called for each row and the return value will be used as the value to
66		* display for every data model. The signature of this function should be: `function ($model, $key, $index, $column)`.
67		* Where `$model`, `$key`, and `$index` refer to the model, key and index of the row currently being rendered
68		* and `$column` is a reference to the [[DataColumn]] object.
69		*
70		* You may also set this property to a string representing the attribute name to be displayed in this column.
71		* This can be used when the attribute to be displayed is different from the [[attribute]] that is used for
72		* sorting and filtering.
73		*
74		* If this is not set, `$model[$attribute]` will be used to obtain the value, where `$attribute` is the value of [[attribute]].
75		*/
76		public $value;
77		/**
78		* @var string\|array\|Closure in which format should the value of each data model be displayed as (e.g. `"raw"`, `"text"`, `"html"`,
79		* `['date', 'php:Y-m-d']`). Supported formats are determined by the [[GridView::formatter\|formatter]] used by
80		* the [[GridView]]. Default format is "text" which will format the value as an HTML-encoded plain text when
81		* [[\yii\i18n\Formatter]] is used as the [[GridView::$formatter\|formatter]] of the GridView.
82		* @see \yii\i18n\Formatter::format()
83		*/
84		public $format = 'text';
85		/**
86		* @var bool whether to allow sorting by this column. If true and [[attribute]] is found in
87		* the sort definition of [[GridView::dataProvider]], then the header cell of this column
88		* will contain a link that may trigger the sorting when being clicked.
89		*/
90		public $enableSorting = true;
91		/**
92		* @var array the HTML attributes for the link tag in the header cell
93		* generated by [[\yii\data\Sort::link]] when sorting is enabled for this column.
94		* @see \yii\helpers\Html::renderTagAttributes() for details on how attributes are being rendered.
95		*/
96		public $sortLinkOptions = [];
97		/**
98		* @var string\|array\|null\|false the HTML code representing a filter input (e.g. a text field, a dropdown list)
99		* that is used for this data column. This property is effective only when [[GridView::filterModel]] is set.
100		*
101		* - If this property is not set, a text field will be generated as the filter input with attributes defined
102		* with [[filterInputOptions]]. See [[\yii\helpers\BaseHtml::activeInput]] for details on how an active
103		* input tag is generated.
104		* - If this property is an array, a dropdown list will be generated that uses this property value as
105		* the list options.
106		* - If you don't want a filter for this data column, set this value to be false.
107		*/
108		public $filter;
109		/**
110		* @var array the HTML attributes for the filter input fields. This property is used in combination with
111		* the [[filter]] property. When [[filter]] is not set or is an array, this property will be used to
112		* render the HTML attributes for the generated filter input fields.
113		* By default a `'class' => 'form-control'` element will be added if no class has been specified.
114		* If you do not want to create a class attribute, you can specify `['class' => null]`.
115		*
116		* Empty `id` in the default value ensures that id would not be obtained from the model attribute thus
117		* providing better performance.
118		*
119		* @see \yii\helpers\Html::renderTagAttributes() for details on how attributes are being rendered.
120		*/
121		public $filterInputOptions = [];
122
123
124		/**
125		* {@inheritdoc}
126		*/
127		protected function renderHeaderCellContent()
128		{
129		if ($this->header !== null \|\| $this->label === null && $this->attribute === null) {
130		return parent::renderHeaderCellContent();
131		}
132
133		$label = $this->getHeaderCellLabel();
134		if ($this->encodeLabel) {
135		$label = Html::encode($label);
136		}
137
138		if ($this->attribute !== null && $this->enableSorting &&
139		($sort = $this->grid->dataProvider->getSort()) !== false && $sort->hasAttribute($this->attribute)) {
140		return $sort->link($this->attribute, array_merge($this->sortLinkOptions, ['label' => $label]));
141		}
142
143		return $label;
144		}
145
146		/**
147		* {@inheritdoc]
148		* @since 2.0.8
149		*/
150	2	protected function getHeaderCellLabel()
151		{
152	2	$provider = $this->grid->dataProvider;
153
154	2	if ($this->label === null) {
155	2	if ($provider instanceof ActiveDataProvider && $provider->query instanceof ActiveQueryInterface) {
156		/* @var $modelClass Model */
157		$modelClass = $provider->query->modelClass;
		0 ignored issues – show Bug introduced 2015-11-20 21:52 UTC by Report Bug Copy Issue Report Accessing `modelClass` on the interface `yii\db\ActiveQueryInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
158		$model = $modelClass::instance();
159		$label = $model->getAttributeLabel($this->attribute);
160	2	} elseif ($provider instanceof ArrayDataProvider && $provider->modelClass !== null) {
161		/* @var $modelClass Model */
162	1	$modelClass = $provider->modelClass;
163	1	$model = $modelClass::instance();
164	1	$label = $model->getAttributeLabel($this->attribute);
165	1	} elseif ($this->grid->filterModel !== null && $this->grid->filterModel instanceof Model) {
166	1	$label = $this->grid->filterModel->getAttributeLabel($this->attribute);
167		} else {
168		$models = $provider->getModels();
169		if (($model = reset($models)) instanceof Model) {
170		/* @var $model Model */
171		$label = $model->getAttributeLabel($this->attribute);
172		} else {
173	2	$label = Inflector::camel2words($this->attribute);
174		}
175		}
176		} else {
177		$label = $this->label;
178		}
179
180	2	return $label;
181		}
182
183		/**
184		* {@inheritdoc}
185		*/
186	11	protected function renderFilterCellContent()
187		{
188	11	if (is_string($this->filter)) {
189	1	return $this->filter;
190		}
191
192	10	$model = $this->grid->filterModel;
193
194	10	if ($this->filter !== false && $model instanceof Model && $this->attribute !== null && $model->isAttributeActive($this->attribute)) {
195	10	if ($model->hasErrors($this->attribute)) {
196		Html::addCssClass($this->filterOptions, 'has-error');
197		$error = ' ' . Html::error($model, $this->attribute, $this->grid->filterErrorOptions);
198		} else {
199	10	$error = '';
200		}
201
202	10	$filterOptions = array_merge(['class' => 'form-control', 'id' => null], $this->filterInputOptions);
203	10	if (is_array($this->filter)) {
204	1	$options = array_merge(['prompt' => ''], $filterOptions);
205	1	return Html::activeDropDownList($model, $this->attribute, $this->filter, $options) . $error;
206		}
207	9	if ($this->format === 'boolean') {
208	1	$options = array_merge(['prompt' => ''], $filterOptions);
209	1	return Html::activeDropDownList($model, $this->attribute, [
210	1	1 => $this->grid->formatter->booleanFormat[1],
211	1	0 => $this->grid->formatter->booleanFormat[0],
212	1	], $options) . $error;
213		}
214
215	8	return Html::activeTextInput($model, $this->attribute, $filterOptions) . $error;
216		}
217
218		return parent::renderFilterCellContent();
219		}
220
221		/**
222		* Returns the data cell value.
223		* @param mixed $model the data model
224		* @param mixed $key the key associated with the data model
225		* @param int $index the zero-based index of the data model among the models array returned by [[GridView::dataProvider]].
226		* @return string the data cell value
227		*/
228		public function getDataCellValue($model, $key, $index)
229		{
230		if ($this->value !== null) {
231		if (is_string($this->value)) {
232		return ArrayHelper::getValue($model, $this->value);
233		}
234
235		return call_user_func($this->value, $model, $key, $index, $this);
236		}
237		if ($this->attribute !== null) {
238		return ArrayHelper::getValue($model, $this->attribute);
239		}
240
241		return null;
242		}
243
244		/**
245		* {@inheritdoc}
246		*/
247		protected function renderDataCellContent($model, $key, $index)
248		{
249		if ($this->content === null) {
250		return $this->grid->formatter->format($this->getDataCellValue($model, $key, $index), $this->format);
251		}
252
253		return parent::renderDataCellContent($model, $key, $index);
254		}
255		}
256

yiisoft / yii2

Push — 2.1 ( 0cb910...fafa40 )

DataColumn::getHeaderCellLabel() D

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like