Completed
Pull Request — 2.1 (#14036)
by Angel
21:16 queued 12:09
created
framework/db/Migration.php 1 patch
Doc Comments   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
     /**
87 87
      * This method contains the logic to be executed when applying this migration.
88 88
      * Child classes may override this method to provide actual migration logic.
89
-     * @return bool return a false value to indicate the migration fails
89
+     * @return false|null return a false value to indicate the migration fails
90 90
      * and should not proceed further. All other return values mean the migration succeeds.
91 91
      */
92 92
     public function up()
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
      * This method contains the logic to be executed when removing this migration.
116 116
      * The default implementation throws an exception indicating the migration cannot be removed.
117 117
      * Child classes may override this method if the corresponding migrations can be removed.
118
-     * @return bool return a false value to indicate the migration fails
118
+     * @return false|null return a false value to indicate the migration fails
119 119
      * and should not proceed further. All other return values mean the migration succeeds.
120 120
      */
121 121
     public function down()
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
      * be enclosed within a DB transaction.
156 156
      * Child classes may implement this method instead of [[up()]] if the DB logic
157 157
      * needs to be within a transaction.
158
-     * @return bool return a false value to indicate the migration fails
158
+     * @return boolean|null return a false value to indicate the migration fails
159 159
      * and should not proceed further. All other return values mean the migration succeeds.
160 160
      */
161 161
     public function safeUp()
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
      * be enclosed within a DB transaction.
169 169
      * Child classes may implement this method instead of [[down()]] if the DB logic
170 170
      * needs to be within a transaction.
171
-     * @return bool return a false value to indicate the migration fails
171
+     * @return boolean|null return a false value to indicate the migration fails
172 172
      * and should not proceed further. All other return values mean the migration succeeds.
173 173
      */
174 174
     public function safeDown()
@@ -387,7 +387,7 @@  discard block
 block discarded – undo
387 387
      * The method will properly quote the table and column names.
388 388
      * @param string $name the name of the primary key constraint.
389 389
      * @param string $table the table that the primary key constraint will be added to.
390
-     * @param string|array $columns comma separated string or array of columns that the primary key will consist of.
390
+     * @param string[] $columns comma separated string or array of columns that the primary key will consist of.
391 391
      */
392 392
     public function addPrimaryKey($name, $table, $columns)
393 393
     {
@@ -415,9 +415,9 @@  discard block
 block discarded – undo
415 415
      * The method will properly quote the table and column names.
416 416
      * @param string $name the name of the foreign key constraint.
417 417
      * @param string $table the table that the foreign key constraint will be added to.
418
-     * @param string|array $columns the name of the column to that the constraint will be added on. If there are multiple columns, separate them with commas or use an array.
418
+     * @param string $columns the name of the column to that the constraint will be added on. If there are multiple columns, separate them with commas or use an array.
419 419
      * @param string $refTable the table that the foreign key references to.
420
-     * @param string|array $refColumns the name of the column that the foreign key references to. If there are multiple columns, separate them with commas or use an array.
420
+     * @param string $refColumns the name of the column that the foreign key references to. If there are multiple columns, separate them with commas or use an array.
421 421
      * @param string $delete the ON DELETE option. Most DBMS support these options: RESTRICT, CASCADE, NO ACTION, SET DEFAULT, SET NULL
422 422
      * @param string $update the ON UPDATE option. Most DBMS support these options: RESTRICT, CASCADE, NO ACTION, SET DEFAULT, SET NULL
423 423
      */
@@ -446,7 +446,7 @@  discard block
 block discarded – undo
446 446
      * Builds and executes a SQL statement for creating a new index.
447 447
      * @param string $name the name of the index. The name will be properly quoted by the method.
448 448
      * @param string $table the table that the new index will be created for. The table name will be properly quoted by the method.
449
-     * @param string|array $columns the column(s) that should be included in the index. If there are multiple columns, please separate them
449
+     * @param string $columns the column(s) that should be included in the index. If there are multiple columns, please separate them
450 450
      * by commas or use an array. Each column name will be properly quoted by the method. Quoting will be skipped for column names that
451 451
      * include a left parenthesis "(".
452 452
      * @param bool $unique whether to add UNIQUE constraint on the created index.
Please login to merge, or discard this patch.
framework/db/Query.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -768,7 +768,7 @@  discard block
 block discarded – undo
768 768
 
769 769
     /**
770 770
      * Sets the GROUP BY part of the query.
771
-     * @param string|array|Expression $columns the columns to be grouped by.
771
+     * @param string $columns the columns to be grouped by.
772 772
      * Columns can be specified in either a string (e.g. "id, name") or an array (e.g. ['id', 'name']).
773 773
      * The method will automatically quote the column names unless a column contains some parenthesis
774 774
      * (which means the column contains a DB expression).
@@ -967,7 +967,7 @@  discard block
 block discarded – undo
967 967
 
968 968
     /**
969 969
      * Appends a SQL statement using UNION operator.
970
-     * @param string|Query $sql the SQL statement to be appended using UNION
970
+     * @param Query $sql the SQL statement to be appended using UNION
971 971
      * @param bool $all TRUE if using UNION ALL and FALSE if using UNION
972 972
      * @return $this the query object itself
973 973
      */
Please login to merge, or discard this patch.
framework/captcha/CaptchaAction.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -144,7 +144,7 @@
 block discarded – undo
144 144
     /**
145 145
      * Generates a hash code that can be used for client-side validation.
146 146
      * @param string $code the CAPTCHA code
147
-     * @return string a hash code generated from the CAPTCHA code
147
+     * @return integer a hash code generated from the CAPTCHA code
148 148
      */
149 149
     public function generateValidationHash($code)
150 150
     {
Please login to merge, or discard this patch.
framework/db/ActiveQuery.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -392,7 +392,7 @@
 block discarded – undo
392 392
      * @param bool|array $eagerLoading whether to eager load the relations specified in `$with`.
393 393
      * When this is a boolean, it applies to all relations specified in `$with`. Use an array
394 394
      * to explicitly list which relations in `$with` need to be eagerly loaded. Defaults to `true`.
395
-     * @param string|array $joinType the join type of the relations specified in `$with`.
395
+     * @param string $joinType the join type of the relations specified in `$with`.
396 396
      * When this is a string, it applies to all relations specified in `$with`. Use an array
397 397
      * in the format of `relationName => joinType` to specify different join types for different relations.
398 398
      * @return $this the query object itself
Please login to merge, or discard this patch.
framework/db/DataReader.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -114,7 +114,7 @@
 block discarded – undo
114 114
     /**
115 115
      * Returns a single column from the next row of a result set.
116 116
      * @param int $columnIndex zero-based column index
117
-     * @return mixed the column of the current row, false if no more rows available
117
+     * @return string the column of the current row, false if no more rows available
118 118
      */
119 119
     public function readColumn($columnIndex)
120 120
     {
Please login to merge, or discard this patch.
framework/helpers/BaseHtml.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -208,7 +208,7 @@  discard block
 block discarded – undo
208 208
 
209 209
     /**
210 210
      * Generates a link tag that refers to an external CSS file.
211
-     * @param array|string $url the URL of the external CSS file. This parameter will be processed by [[Url::to()]].
211
+     * @param string|boolean $url the URL of the external CSS file. This parameter will be processed by [[Url::to()]].
212 212
      * @param array $options the tag options in terms of name-value pairs. The following options are specially handled:
213 213
      *
214 214
      * - condition: specifies the conditional comments for IE, e.g., `lt IE 9`. When this is specified,
@@ -1854,7 +1854,7 @@  discard block
 block discarded – undo
1854 1854
      * ```
1855 1855
      *
1856 1856
      * @param array $options the options to be modified.
1857
-     * @param string|array $class the CSS class(es) to be added
1857
+     * @param string $class the CSS class(es) to be added
1858 1858
      */
1859 1859
     public static function addCssClass(&$options, $class)
1860 1860
     {
Please login to merge, or discard this patch.
framework/web/Response.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -789,7 +789,7 @@
 block discarded – undo
789 789
      * });
790 790
      * ```
791 791
      *
792
-     * @param string|array $url the URL to be redirected to. This can be in one of the following formats:
792
+     * @param string $url the URL to be redirected to. This can be in one of the following formats:
793 793
      *
794 794
      * - a string representing a URL (e.g. "http://example.com")
795 795
      * - a string representing a URL alias (e.g. "@example.com")
Please login to merge, or discard this patch.
framework/web/User.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
      * stored in session and reconstruct the corresponding identity object, if it has not done so before.
176 176
      * @param bool $autoRenew whether to automatically renew authentication status if it has not been done so before.
177 177
      * This is only useful when [[enableSession]] is true.
178
-     * @return IdentityInterface|null the identity object associated with the currently logged-in user.
178
+     * @return null|boolean the identity object associated with the currently logged-in user.
179 179
      * `null` is returned if the user is not logged in (not authenticated).
180 180
      * @see login()
181 181
      * @see logout()
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
259 259
      * with the provided access token. If successful, it will call [[login()]] to log in the authenticated user.
260 260
      * If authentication fails or [[login()]] is unsuccessful, it will return null.
261 261
      * @param string $token the access token
262
-     * @param mixed $type the type of the token. The value of this parameter depends on the implementation.
262
+     * @param string $type the type of the token. The value of this parameter depends on the implementation.
263 263
      * For example, [[\yii\filters\auth\HttpBearerAuth]] will set this parameter to be `yii\filters\auth\HttpBearerAuth`.
264 264
      * @return IdentityInterface|null the identity associated with the given access token. Null is returned if
265 265
      * the access token is invalid or [[login()]] is unsuccessful.
Please login to merge, or discard this patch.
framework/helpers/BaseFileHelper.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -636,7 +636,7 @@
 block discarded – undo
636 636
      * @param string $pattern
637 637
      * @param bool $caseSensitive
638 638
      * @throws \yii\base\InvalidArgumentException
639
-     * @return array with keys: (string) pattern, (int) flags, (int|bool) firstWildcard
639
+     * @return string with keys: (string) pattern, (int) flags, (int|bool) firstWildcard
640 640
      */
641 641
     private static function parseExcludePattern($pattern, $caseSensitive)
642 642
     {
Please login to merge, or discard this patch.