Passed
Pull Request — master (#19417)
by Fedonyuk
08:32
created

UniqueValidator::prepareConditions()   A

Complexity

Conditions 5
Paths 4

Size

Total Lines 18
Code Lines 10

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 10
CRAP Score 5

Importance

Changes 0
Metric Value
cc 5
eloc 10
nc 4
nop 3
dl 0
loc 18
ccs 10
cts 10
cp 1
crap 5
rs 9.6111
c 0
b 0
f 0
1
<?php
2
/**
3
 * @link http://www.yiiframework.com/
4
 * @copyright Copyright (c) 2008 Yii Software LLC
5
 * @license http://www.yiiframework.com/license/
6
 */
7
8
namespace yii\validators;
9
10
use Yii;
11
use yii\base\Model;
12
use yii\db\ActiveQuery;
13
use yii\db\ActiveQueryInterface;
14
use yii\db\ActiveRecord;
15
use yii\db\ActiveRecordInterface;
16
use yii\helpers\Inflector;
17
18
/**
19
 * UniqueValidator validates that the attribute value is unique in the specified database table.
20
 *
21
 * UniqueValidator checks if the value being validated is unique in the table column specified by
22
 * the ActiveRecord class [[targetClass]] and the attribute [[targetAttribute]].
23
 *
24
 * The following are examples of validation rules using this validator:
25
 *
26
 * ```php
27
 * // a1 needs to be unique
28
 * ['a1', 'unique']
29
 * // a1 needs to be unique, but column a2 will be used to check the uniqueness of the a1 value
30
 * ['a1', 'unique', 'targetAttribute' => 'a2']
31
 * // a1 and a2 need to be unique together, and they both will receive error message
32
 * [['a1', 'a2'], 'unique', 'targetAttribute' => ['a1', 'a2']]
33
 * // a1 and a2 need to be unique together, only a1 will receive error message
34
 * ['a1', 'unique', 'targetAttribute' => ['a1', 'a2']]
35
 * // a1 needs to be unique by checking the uniqueness of both a2 and a3 (using a1 value)
36
 * ['a1', 'unique', 'targetAttribute' => ['a2', 'a1' => 'a3']]
37
 * ```
38
 *
39
 * @author Qiang Xue <[email protected]>
40
 * @since 2.0
41
 */
42
class UniqueValidator extends Validator
43
{
44
    /**
45
     * @var string|null the name of the ActiveRecord class that should be used to validate the uniqueness
46
     * of the current attribute value. If not set, it will use the ActiveRecord class of the attribute being validated.
47
     * @see targetAttribute
48
     */
49
    public $targetClass;
50
    /**
51
     * @var string|array|null the name of the [[\yii\db\ActiveRecord|ActiveRecord]] attribute that should be used to
52
     * validate the uniqueness of the current attribute value. If not set, it will use the name
53
     * of the attribute currently being validated. You may use an array to validate the uniqueness
54
     * of multiple columns at the same time. The array values are the attributes that will be
55
     * used to validate the uniqueness, while the array keys are the attributes whose values are to be validated.
56
     */
57
    public $targetAttribute;
58
    /**
59
     * @var string|array|\Closure additional filter to be applied to the DB query used to check the uniqueness of the attribute value.
60
     * This can be a string or an array representing the additional query condition (refer to [[\yii\db\Query::where()]]
61
     * on the format of query condition), or an anonymous function with the signature `function ($query)`, where `$query`
62
     * is the [[\yii\db\Query|Query]] object that you can modify in the function.
63
     */
64
    public $filter;
65
    /**
66
     * @var string the user-defined error message.
67
     *
68
     * When validating single attribute, it may contain
69
     * the following placeholders which will be replaced accordingly by the validator:
70
     *
71
     * - `{attribute}`: the label of the attribute being validated
72
     * - `{value}`: the value of the attribute being validated
73
     *
74
     * When validating mutliple attributes, it may contain the following placeholders:
75
     *
76
     * - `{attributes}`: the labels of the attributes being validated.
77
     * - `{values}`: the values of the attributes being validated.
78
     */
79
    public $message;
80
    /**
81
     * @var string
82
     * @since 2.0.9
83
     * @deprecated since version 2.0.10, to be removed in 2.1. Use [[message]] property
84
     * to setup custom message for multiple target attributes.
85
     */
86
    public $comboNotUnique;
87
    /**
88
     * @var string and|or define how target attributes are related
89
     * @since 2.0.11
90
     */
91
    public $targetAttributeJunction = 'and';
92
    /**
93
     * @var bool whether this validator is forced to always use master DB
94
     * @since 2.0.14
95
     */
96
    public $forceMasterDb =  true;
97
98
99
    /**
100
     * {@inheritdoc}
101
     */
102 70
    public function init()
103
    {
104 70
        parent::init();
105 70
        if ($this->message !== null) {
106 3
            return;
107
        }
108 70
        if (is_array($this->targetAttribute) && count($this->targetAttribute) > 1) {
109
            // fallback for deprecated `comboNotUnique` property - use it as message if is set
110 15
            if ($this->comboNotUnique === null) {
0 ignored issues
show
Deprecated Code introduced by
The property yii\validators\UniqueValidator::$comboNotUnique has been deprecated: since version 2.0.10, to be removed in 2.1. Use [[message]] property to setup custom message for multiple target attributes. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-deprecated  annotation

110
            if (/** @scrutinizer ignore-deprecated */ $this->comboNotUnique === null) {

This property has been deprecated. The supplier of the class has supplied an explanatory message.

The explanatory message should give you some clue as to whether and when the property will be removed from the class and what other property to use instead.

Loading history...
111 12
                $this->message = Yii::t('yii', 'The combination {values} of {attributes} has already been taken.');
112
            } else {
113 15
                $this->message = $this->comboNotUnique;
0 ignored issues
show
Deprecated Code introduced by
The property yii\validators\UniqueValidator::$comboNotUnique has been deprecated: since version 2.0.10, to be removed in 2.1. Use [[message]] property to setup custom message for multiple target attributes. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-deprecated  annotation

113
                $this->message = /** @scrutinizer ignore-deprecated */ $this->comboNotUnique;

This property has been deprecated. The supplier of the class has supplied an explanatory message.

The explanatory message should give you some clue as to whether and when the property will be removed from the class and what other property to use instead.

Loading history...
114
            }
115
        } else {
116 58
            $this->message = Yii::t('yii', '{attribute} "{value}" has already been taken.');
117
        }
118 70
    }
119
120
    /**
121
     * {@inheritdoc}
122
     */
123
    public function validateAttributes($model, $attributes = null)
124
    {
125
126
        if (
127
            !$this->skipOnError
128
            || !is_array($attributes)
129
            || count($attributes) < 2
130
            || array_diff($attributes, (array) $this->targetAttribute) !== []
131
        ) {
132
            parent::validateAttributes($model, $attributes);
133
            return;
134
        }
135
136
        $attributes = $this->getValidationAttributes($attributes);
137
        // if any attribute skips validation, other attributes also skip it
138
        foreach ($attributes as $attribute) {
139
            $skip = ($this->skipOnError && $model->hasErrors($attribute))
140
                || ($this->skipOnEmpty && $this->isEmpty($model->$attribute));
141
            if ($skip) {
142
                return;
143
            }
144
        }
145
146
        foreach ($attributes as $attribute) {
147
            if ($this->when === null || call_user_func($this->when, $model, $attribute)) {
148
                $this->validateAttribute($model, $attribute);
149
            }
150
        }
151
    }
152
153
    /**
154
     * {@inheritdoc}
155
     */
156 55
    public function validateAttribute($model, $attribute)
157
    {
158
        /* @var $targetClass ActiveRecordInterface */
159 55
        $targetClass = $this->getTargetClass($model);
160 55
        $targetAttribute = $this->targetAttribute === null ? $attribute : $this->targetAttribute;
161 55
        $rawConditions = $this->prepareConditions($targetAttribute, $model, $attribute);
162 55
        $conditions = [$this->targetAttributeJunction === 'or' ? 'or' : 'and'];
163
164 55
        foreach ($rawConditions as $key => $value) {
165 55
            if (is_array($value)) {
166 6
                $this->addError($model, $attribute, Yii::t('yii', '{attribute} is invalid.'));
167 6
                return;
168
            }
169 52
            $conditions[] = [$key => $value];
170
        }
171
172 52
        $db = $targetClass::getDb();
173
174 52
        $modelExists = false;
175
176 52
        if ($this->forceMasterDb && method_exists($db, 'useMaster')) {
177 52
            $db->useMaster(function () use ($targetClass, $conditions, $model, &$modelExists) {
178 52
                $modelExists = $this->modelExists($targetClass, $conditions, $model);
0 ignored issues
show
Bug introduced by
$targetClass of type yii\db\ActiveRecordInterface is incompatible with the type string expected by parameter $targetClass of yii\validators\UniqueValidator::modelExists(). ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

178
                $modelExists = $this->modelExists(/** @scrutinizer ignore-type */ $targetClass, $conditions, $model);
Loading history...
179 52
            });
180
        } else {
181 3
            $modelExists = $this->modelExists($targetClass, $conditions, $model);
0 ignored issues
show
Bug introduced by
$targetClass of type yii\db\ActiveRecordInterface is incompatible with the type string expected by parameter $targetClass of yii\validators\UniqueValidator::modelExists(). ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

181
            $modelExists = $this->modelExists(/** @scrutinizer ignore-type */ $targetClass, $conditions, $model);
Loading history...
182
        }
183
184 49
        if ($modelExists) {
185 29
            if (is_array($targetAttribute) && count($targetAttribute) > 1) {
186 6
                $this->addComboNotUniqueError($model, $attribute);
187
            } else {
188 29
                $this->addError($model, $attribute, $this->message);
189
            }
190
        }
191 49
    }
192
193
    /**
194
     * @param Model $model the data model to be validated
195
     * @return string Target class name
196
     */
197 64
    private function getTargetClass($model)
198
    {
199 64
        return $this->targetClass === null ? get_class($model) : $this->targetClass;
200
    }
201
202
    /**
203
     * Checks whether the $model exists in the database.
204
     *
205
     * @param string $targetClass the name of the ActiveRecord class that should be used to validate the uniqueness
206
     * of the current attribute value.
207
     * @param array $conditions conditions, compatible with [[\yii\db\Query::where()|Query::where()]] key-value format.
208
     * @param Model $model the data model to be validated
209
     *
210
     * @return bool whether the model already exists
211
     */
212 52
    private function modelExists($targetClass, $conditions, $model)
213
    {
214
        /** @var ActiveRecordInterface|\yii\base\BaseObject $targetClass $query */
215 52
        $query = $this->prepareQuery($targetClass, $conditions);
0 ignored issues
show
Bug introduced by
It seems like $targetClass can also be of type yii\base\BaseObject; however, parameter $targetClass of yii\validators\UniqueValidator::prepareQuery() does only seem to accept yii\db\ActiveRecordInterface, maybe add an additional type check? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

215
        $query = $this->prepareQuery(/** @scrutinizer ignore-type */ $targetClass, $conditions);
Loading history...
216
217 52
        if (!$model instanceof ActiveRecordInterface || $model->getIsNewRecord() || $model->className() !== $targetClass::className()) {
0 ignored issues
show
Bug introduced by
The method className() does not exist on yii\db\ActiveRecordInterface. Since it exists in all sub-types, consider adding an abstract or default implementation to yii\db\ActiveRecordInterface. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

217
        if (!$model instanceof ActiveRecordInterface || $model->getIsNewRecord() || $model->className() !== $targetClass::/** @scrutinizer ignore-call */ className()) {
Loading history...
Deprecated Code introduced by
The function yii\base\BaseObject::className() has been deprecated: since 2.0.14. On PHP >=5.5, use `::class` instead. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-deprecated  annotation

217
        if (!$model instanceof ActiveRecordInterface || $model->getIsNewRecord() || $model->className() !== /** @scrutinizer ignore-deprecated */ $targetClass::className()) {

This function has been deprecated. The supplier of the function has supplied an explanatory message.

The explanatory message should give you some clue as to whether and when the function will be removed and what other function to use instead.

Loading history...
Bug introduced by
The method getIsNewRecord() does not exist on yii\base\Model. Since you implemented __call, consider adding a @method annotation. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

217
        if (!$model instanceof ActiveRecordInterface || $model->/** @scrutinizer ignore-call */ getIsNewRecord() || $model->className() !== $targetClass::className()) {
Loading history...
218
            // if current $model isn't in the database yet then it's OK just to call exists()
219
            // also there's no need to run check based on primary keys, when $targetClass is not the same as $model's class
220 34
            $exists = $query->exists();
221
        } else {
222
            // if current $model is in the database already we can't use exists()
223 29
            if ($query instanceof \yii\db\ActiveQuery) {
224
                // only select primary key to optimize query
225 29
                $columnsCondition = array_flip($targetClass::primaryKey());
0 ignored issues
show
introduced by
The method primaryKey() does not exist on yii\base\BaseObject. Maybe you want to declare this class abstract? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

225
                $columnsCondition = array_flip($targetClass::/** @scrutinizer ignore-call */ primaryKey());
Loading history...
226 29
                $query->select(array_flip($this->applyTableAlias($query, $columnsCondition)));
227
228
                // any with relation can't be loaded because related fields are not selected
229 29
                $query->with = null;
230
231 29
                if (is_array($query->joinWith)) {
232
                    // any joinWiths need to have eagerLoading turned off to prevent related fields being loaded
233 6
                    foreach ($query->joinWith as &$joinWith) {
234
                        // \yii\db\ActiveQuery::joinWith adds eagerLoading at key 1
235 6
                        $joinWith[1] = false;
236
                    }
237 6
                    unset($joinWith);
238
                }
239
            }
240 29
            $models = $query->limit(2)->asArray()->all();
241 29
            $n = count($models);
242 29
            if ($n === 1) {
243
                // if there is one record, check if it is the currently validated model
244 26
                $dbModel = reset($models);
245 26
                $pks = $targetClass::primaryKey();
246 26
                $pk = [];
247 26
                foreach ($pks as $pkAttribute) {
248 26
                    $pk[$pkAttribute] = $dbModel[$pkAttribute];
249
                }
250 26
                $exists = ($pk != $model->getOldPrimaryKey(true));
0 ignored issues
show
Bug introduced by
The method getOldPrimaryKey() does not exist on yii\base\Model. Since you implemented __call, consider adding a @method annotation. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

250
                $exists = ($pk != $model->/** @scrutinizer ignore-call */ getOldPrimaryKey(true));
Loading history...
251
            } else {
252
                // if there is more than one record, the value is not unique
253 6
                $exists = $n > 1;
254
            }
255
        }
256
257 49
        return $exists;
258
    }
259
260
    /**
261
     * Prepares a query by applying filtering conditions defined in $conditions method property
262
     * and [[filter]] class property.
263
     *
264
     * @param ActiveRecordInterface $targetClass the name of the ActiveRecord class that should be used to validate
265
     * the uniqueness of the current attribute value.
266
     * @param array $conditions conditions, compatible with [[\yii\db\Query::where()|Query::where()]] key-value format
267
     *
268
     * @return ActiveQueryInterface|ActiveQuery
269
     */
270 55
    private function prepareQuery($targetClass, $conditions)
271
    {
272 55
        $query = $targetClass::find();
273 55
        $query->andWhere($conditions);
274 55
        if ($this->filter instanceof \Closure) {
275 6
            call_user_func($this->filter, $query);
276 52
        } elseif ($this->filter !== null) {
277 3
            $query->andWhere($this->filter);
0 ignored issues
show
Bug introduced by
It seems like $this->filter can also be of type string; however, parameter $condition of yii\db\QueryInterface::andWhere() does only seem to accept array, maybe add an additional type check? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

277
            $query->andWhere(/** @scrutinizer ignore-type */ $this->filter);
Loading history...
278
        }
279
280 55
        return $query;
281
    }
282
283
    /**
284
     * Processes attributes' relations described in $targetAttribute parameter into conditions, compatible with
285
     * [[\yii\db\Query::where()|Query::where()]] key-value format.
286
     *
287
     * @param string|array $targetAttribute the name of the [[\yii\db\ActiveRecord|ActiveRecord]] attribute that
288
     * should be used to validate the uniqueness of the current attribute value. You may use an array to validate
289
     * the uniqueness of multiple columns at the same time. The array values are the attributes that will be
290
     * used to validate the uniqueness, while the array keys are the attributes whose values are to be validated.
291
     * If the key and the value are the same, you can just specify the value.
292
     * @param Model $model the data model to be validated
293
     * @param string $attribute the name of the attribute to be validated in the $model
294
     *
295
     * @return array conditions, compatible with [[\yii\db\Query::where()|Query::where()]] key-value format.
296
     */
297 58
    private function prepareConditions($targetAttribute, $model, $attribute)
298
    {
299 58
        if (is_array($targetAttribute)) {
300 27
            $conditions = [];
301 27
            foreach ($targetAttribute as $k => $v) {
302 27
                $conditions[$v] = is_int($k) ? $model->$v : $model->$k;
303
            }
304
        } else {
305 40
            $conditions = [$targetAttribute => $model->$attribute];
306
        }
307
308 58
        $targetModelClass = $this->getTargetClass($model);
309 58
        if (!is_subclass_of($targetModelClass, 'yii\db\ActiveRecord')) {
310 6
            return $conditions;
311
        }
312
313
        /** @var ActiveRecord $targetModelClass */
314 58
        return $this->applyTableAlias($targetModelClass::find(), $conditions);
315
    }
316
317
    /**
318
     * Builds and adds [[comboNotUnique]] error message to the specified model attribute.
319
     * @param \yii\base\Model $model the data model.
320
     * @param string $attribute the name of the attribute.
321
     */
322 6
    private function addComboNotUniqueError($model, $attribute)
323
    {
324 6
        $attributeCombo = [];
325 6
        $valueCombo = [];
326 6
        foreach ($this->targetAttribute as $key => $value) {
327 6
            if (is_int($key)) {
328 6
                $attributeCombo[] = $model->getAttributeLabel($value);
329 6
                $valueCombo[] = '"' . $model->$value . '"';
330
            } else {
331
                $attributeCombo[] = $model->getAttributeLabel($key);
332
                $valueCombo[] = '"' . $model->$key . '"';
333
            }
334
        }
335 6
        $this->addError($model, $attribute, $this->message, [
336 6
            'attributes' => Inflector::sentence($attributeCombo),
337 6
            'values' => implode('-', $valueCombo),
338
        ]);
339 6
    }
340
341
    /**
342
     * Returns conditions with alias.
343
     * @param ActiveQuery $query
344
     * @param array $conditions array of condition, keys to be modified
345
     * @param string|null $alias set empty string for no apply alias. Set null for apply primary table alias
346
     * @return array
347
     */
348 58
    private function applyTableAlias($query, $conditions, $alias = null)
349
    {
350 58
        if ($alias === null) {
351 58
            $alias = array_keys($query->getTablesUsedInFrom())[0];
352
        }
353 58
        $prefixedConditions = [];
354 58
        foreach ($conditions as $columnName => $columnValue) {
355 58
            if (strpos($columnName, '(') === false) {
356 58
                $columnName = preg_replace('/^' . preg_quote($alias) . '\.(.*)$/', '$1', $columnName);
357 58
                if (strncmp($columnName, '[[', 2) === 0) {
358 1
                    $prefixedColumn = "{$alias}.{$columnName}";
359
                } else {
360 58
                    $prefixedColumn = "{$alias}.[[{$columnName}]]";
361
                }
362
            } else {
363
                // there is an expression, can't prefix it reliably
364 3
                $prefixedColumn = $columnName;
365
            }
366
367 58
            $prefixedConditions[$prefixedColumn] = $columnValue;
368
        }
369
370 58
        return $prefixedConditions;
371
    }
372
}
373