BasicNetworkResolverTest::schemeDataProvider() - Code Metrics - Inspection of "Add basic network resolver middleware #119 (#125)" - yiisoft/yii-web - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b2599f...653121 )

by Alexander

created 2019-10-23 14:14 UTC

BasicNetworkResolverTest::schemeDataProvider() A

↳ Parent: BasicNetworkResolverTest

Complexity

Conditions	2
Paths	1

Size

Total Lines	66
Code Lines	50

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	50
c	1
b	0
f	0
nc	1
nop	0
dl	0
loc	66
rs	9.0909

How to fix Long Method

<?php


namespace Yiisoft\Yii\Web\Tests\Middleware;

use Nyholm\Psr7\ServerRequest;
use PHPUnit\Framework\TestCase;
use Psr\Http\Message\ServerRequestInterface;
use Yiisoft\Yii\Web\Middleware\BasicNetworkResolver;
use Yiisoft\Yii\Web\Tests\Middleware\Mock\MockRequestHandler;

class BasicNetworkResolverTest extends TestCase
{

    public function schemeDataProvider(): array
    {
        return [
            'httpNotModify' => ['http', [], null, 'http'],
            'httpsNotModify' => ['https', [], null, 'https'],
            'httpNotMatchedProtocolHeader' => [
                'http',
                ['x-forwarded-proto' => ['https']],
                ['test' => ['https' => 'https']],
                'http'
            ],
            'httpNotMatchedProtocolHeaderValue' => [
                'http',
                ['x-forwarded-proto' => ['https']],
                ['x-forwarded-proto' => ['https' => 'test']],
                'http'
            ],
            'httpToHttps' => [
                'http',
                ['x-forwarded-proto' => ['https']],
                ['x-forwarded-proto' => ['https' => 'https']],
                'https'
            ],
            'httpToHttpsDefault' => [
                'http',
                ['x-forwarded-proto' => ['https']],
                ['x-forwarded-proto' => null],
                'https'
            ],
            'httpToHttpsUpperCase' => [
                'http',
                ['x-forwarded-proto' => ['https']],
                ['x-forwarded-proto' => ['https' => 'HTTPS']],
                'https'
            ],
            'httpToHttpsMultiValue' => [
                'http',
                ['x-forwarded-proto' => ['https']],
                ['x-forwarded-proto' => ['https' => ['on', 's', 'https']]],
                'https'
            ],
            'httpsToHttp' => [
                'https',
                ['x-forwarded-proto' => 'http'],
                ['x-forwarded-proto' => ['http' => 'http']],
                'http'
            ],
            'httpToHttpsWithCallback' => [
                'http',
                ['x-forwarded-proto' => 'test any-https **'],
                [
                    'x-forwarded-proto' => function (array $values, String $header, ServerRequestInterface $request) {
                    'x-forwarded-proto' => function (array $values, /** @scrutinizer ignore-unused */ String $header, ServerRequestInterface $request) {
                        return stripos($values[0], 'https') !== false ? 'https' : 'http';
                    },
                ],
                'https',
            ],
            'httpWithCallbackNull' => [
                'http',
                ['x-forwarded-proto' => 'test any-https **'],
                [
                    'x-forwarded-proto' => function (array $values, String $header, ServerRequestInterface $request) {
                    'x-forwarded-proto' => function (array $values, String $header, /** @scrutinizer ignore-unused */ ServerRequestInterface $request) {
                        return null;
                    },
                ],
                'http',
            ]
        ];
    }

    protected function newRequestWithSchemaAndHeaders(
        string $scheme = 'http',
        array $headers = []
    ): ServerRequestInterface {
        $request = new ServerRequest('GET', '/', $headers);
        $uri = $request->getUri()->withScheme($scheme);
        return $request->withUri($uri);
    }

    /**
     * @dataProvider schemeDataProvider
     */
    public function testScheme(string $scheme, array $headers, ?array $protocolHeaders, string $expectedScheme): void
    {
        $request = $this->newRequestWithSchemaAndHeaders($scheme, $headers);
        $requestHandler = new MockRequestHandler();

        $middleware = new BasicNetworkResolver();
        if ($protocolHeaders !== null) {

            foreach ($protocolHeaders as $header => $values) {
                $middleware = $middleware->withAddedProtocolHeader($header, $values);
            }
        }
        $middleware->process($request, $requestHandler);
        $resultRequest = $requestHandler->processedRequest;
        /* @var $resultRequest ServerRequestInterface */
        $this->assertSame($expectedScheme, $resultRequest->getUri()->getScheme());
    }

    public function testWithoutProtocolHeaders(): void
    {
        $request = $this->newRequestWithSchemaAndHeaders('http', [
            'x-forwarded-proto' => ['https'],
        ]);
        $requestHandler = new MockRequestHandler();

        $middleware = (new BasicNetworkResolver())
            ->withAddedProtocolHeader('x-forwarded-proto')
            ->withoutProtocolHeaders();
        $middleware->process($request, $requestHandler);
        $resultRequest = $requestHandler->processedRequest;
        /* @var $resultRequest ServerRequestInterface */
        $this->assertSame('http', $resultRequest->getUri()->getScheme());
    }

    public function testWithoutProtocolHeadersMulti(): void
    {
        $request = $this->newRequestWithSchemaAndHeaders('http', [
            'x-forwarded-proto' => ['https'],
            'x-forwarded-proto-2' => ['https'],
        ]);
        $requestHandler = new MockRequestHandler();

        $middleware = (new BasicNetworkResolver())
            ->withAddedProtocolHeader('x-forwarded-proto')
            ->withAddedProtocolHeader('x-forwarded-proto-2')
            ->withoutProtocolHeaders([
                'x-forwarded-proto',
                'x-forwarded-proto-2',
            ]);
        $middleware->process($request, $requestHandler);
        $resultRequest = $requestHandler->processedRequest;
        /* @var $resultRequest ServerRequestInterface */
        $this->assertSame('http', $resultRequest->getUri()->getScheme());
    }

    public function testWithoutProtocolHeader(): void
    {
        $request = $this->newRequestWithSchemaAndHeaders('https', [
            'x-forwarded-proto' => ['https'],
            'x-forwarded-proto-2' => ['http'],
        ]);
        $requestHandler = new MockRequestHandler();

        $middleware = (new BasicNetworkResolver())
            ->withAddedProtocolHeader('x-forwarded-proto')
            ->withAddedProtocolHeader('x-forwarded-proto-2')
            ->withoutProtocolHeader('x-forwarded-proto');
        $middleware->process($request, $requestHandler);
        $resultRequest = $requestHandler->processedRequest;
        /* @var $resultRequest ServerRequestInterface */
        $this->assertSame('http', $resultRequest->getUri()->getScheme());

        $middleware = $middleware->withoutProtocolHeader('x-forwarded-proto-2');
        $middleware->process($request, $requestHandler);
        $resultRequest = $requestHandler->processedRequest;
        /* @var $resultRequest ServerRequestInterface */
        $this->assertSame('https', $resultRequest->getUri()->getScheme());
    }

}


yiisoft / yii-web

Push — master ( b2599f...653121 )

BasicNetworkResolverTest::schemeDataProvider() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like