Issues in TagRequest.php - Fixed Issues - Inspection of "Add missing return" - yiisoft/yii-web - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 9218d1...27873b )

by Alexander

created 2019-07-09 14:27 UTC

src/Middleware/TagRequest.php (1 issue)

Labels

Severity

Major 1

<?php
namespace Yiisoft\Yii\Web\Middleware;

use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Server\MiddlewareInterface;
use Psr\Http\Server\RequestHandlerInterface;

/**
 * Tags request with a random value that could be later used for identifying it.
 */
class TagRequest implements MiddlewareInterface
{
    public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
    {
        $handler->handle($request->withAttribute('requestTag', $this->getRequestTag()));
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}
    }

    protected function getRequestTag(): string
    {
        return dechex(microtime(true) * 1000000);
    }
}


1			<?php
2			namespace Yiisoft\Yii\Web\Middleware;
3
4			use Psr\Http\Message\ResponseInterface;
5			use Psr\Http\Message\ServerRequestInterface;
6			use Psr\Http\Server\MiddlewareInterface;
7			use Psr\Http\Server\RequestHandlerInterface;
8
9			/**
10			* Tags request with a random value that could be later used for identifying it.
11			*/
12			class TagRequest implements MiddlewareInterface
13			{
14			public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
15			{
16			$handler->handle($request->withAttribute('requestTag', $this->getRequestTag()));
			0 ignored issues – show Bug Best Practice introduced 2019-07-02 12:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `Psr\Http\Message\ResponseInterface`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
17			}
18
19			protected function getRequestTag(): string
20			{
21			return dechex(microtime(true) * 1000000);
22			}
23			}
24

yiisoft / yii-web

Push — master ( 9218d1...27873b )

src/Middleware/TagRequest.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like